Skip to contentSkip to conversation

gpu: drm: gma500: remove two more dead variable

PATCH In review Arnd Bergmann 3 participants 3 messages May 22, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu: drm: gma500: remove two more dead variable

The dead code removal left two unused variables:

drivers/gpu/drm/gma500/mdfld_tpo_vid.c: In function 'tpo_vid_get_config_mode':
drivers/gpu/drm/gma500/mdfld_tpo_vid.c:34:31: error: unused variable 'ti' [-Werror=unused-variable]

This removes them as well.

Fixes 94d7fb4982d2 ("gpu: drm: gma500: remove dead code")
---
 drivers/gpu/drm/gma500/mdfld_tpo_vid.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/gma500/mdfld_tpo_vid.c +0 -2
index d40628e6810d..a9420bf9a419 100644
@@ -30,8 +30,6 @@
 static struct drm_display_mode *tpo_vid_get_config_mode(struct drm_device *dev)
 {
 	struct drm_display_mode *mode;
-	struct drm_psb_private *dev_priv = dev->dev_private;
-	struct oaktrail_timing_info *ti = &dev_priv->gct_data.DTD;
 
 	mode = kzalloc(sizeof(*mode), GFP_KERNEL);
 	if (!mode)
Signature · 6 lines
2.9.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

Hi Arnd,

Quoting Arnd Bergmann <[email protected]>:

Quoted 26 lines

The dead code removal left two unused variables:

drivers/gpu/drm/gma500/mdfld_tpo_vid.c: In function 'tpo_vid_get_config_mode':
drivers/gpu/drm/gma500/mdfld_tpo_vid.c:34:31: error: unused variable 'ti' [-Werror=unused-variable]

This removes them as well.

Fixes 94d7fb4982d2 ("gpu: drm: gma500: remove dead code")
---
 drivers/gpu/drm/gma500/mdfld_tpo_vid.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/gma500/mdfld_tpo_vid.c +0 -2
index d40628e6810d..a9420bf9a419 100644
@@ -30,8 +30,6 @@
 static struct drm_display_mode *tpo_vid_get_config_mode(struct  
 drm_device *dev)
 {
 	struct drm_display_mode *mode;
-	struct drm_psb_private *dev_priv = dev->dev_private;
-	struct oaktrail_timing_info *ti = &dev_priv->gct_data.DTD;
 
 	mode = kzalloc(sizeof(*mode), GFP_KERNEL);
Quoted 3 lines

if (!mode)
--
2.9.0

Thank you!
--
Gustavo A. R. Silva

maintainer
#2 lore raw
In reply to Arnd Bergmann
Quoted 9 lines · Arnd Bergmann

The dead code removal left two unused variables:

drivers/gpu/drm/gma500/mdfld_tpo_vid.c: In function 'tpo_vid_get_config_mode':
drivers/gpu/drm/gma500/mdfld_tpo_vid.c:34:31: error: unused variable 'ti' [-Werror=unused-variable]

This removes them as well.

Fixes 94d7fb4982d2 ("gpu: drm: gma500: remove dead code")

Thanks, I'll take this through drm-misc

Quoted 20 lines
---
 drivers/gpu/drm/gma500/mdfld_tpo_vid.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/gma500/mdfld_tpo_vid.c +0 -3
index d40628e6810d..a9420bf9a419 100644
@@ -30,8 +30,6 @@
 static struct drm_display_mode *tpo_vid_get_config_mode(struct drm_device *dev)
 {
        struct drm_display_mode *mode;
-       struct drm_psb_private *dev_priv = dev->dev_private;
-       struct oaktrail_timing_info *ti = &dev_priv->gct_data.DTD;
 
        mode = kzalloc(sizeof(*mode), GFP_KERNEL);
        if (!mode)
--

2.9.0