Skip to contentSkip to conversation

sttus of the Altix mmtimer driver

DISCUSSION Christoph Hellwig 4 participants 5 messages May 23, 2017 – May 27, 2017

lore
Share & tools
lore
#0 lore raw

Hi folks,

what's the status of the SGI support for the IA64 SN2-specific altic mmtimer (drivers/char/mmtimer.c)? It's the only driver that register a k_lock outside the core kernel, so if we could get rid of it because the remaining IA64 user are all on somewhat old distros anyway it would make our life a whole lot easier.

#1 lore raw

Re: status of the Altix mmtimer driver

On Tue, 23 May 2017, Christoph Hellwig wrote:

Cc + Mike
Quoted 8 lines

Hi folks,

what's the status of the SGI support for the IA64 SN2-specific altic mmtimer (drivers/char/mmtimer.c)? It's the only driver that register a k_lock outside the core kernel, so if we could get rid of it because the remaining IA64 user are all on somewhat old distros anyway it would make our life a whole lot easier.

#2 lore raw

Re: status of the Altix mmtimer driver

Since this is SN2 specific, this can be removed.

Quoted 12 lines · Thomas Gleixner

On Tue, 23 May 2017, Christoph Hellwig wrote:

Cc + Mike
Quoted 8 lines

Hi folks,

what's the status of the SGI support for the IA64 SN2-specific altic mmtimer (drivers/char/mmtimer.c)? It's the only driver that register a k_lock outside the core kernel, so if we could get rid of it because the remaining IA64 user are all on somewhat old distros anyway it would make our life a whole lot easier.

#3 lore raw

Re: status of the Altix mmtimer driver

Note that the mmtimer struct can probably be removed from the k_itimer struct in include/linux/posix-timers.h, just for completeness.

include/linux/posix-timers.h +0 -6
@@ -73,12 +73,6 @@ struct k_itimer {
                } real;
                struct cpu_timer_list cpu;
                struct {
-                       unsigned int clock;
-                       unsigned int node;
-                       unsigned long incr;
-                       unsigned long expires;
-               } mmtimer;
-               struct {
                        struct alarm alarmtimer;
                        ktime_t interval;
                } alarm;
Quoted 15 lines · Dimitri Sivanich

Since this is SN2 specific, this can be removed.

Quoted 12 lines · Thomas Gleixner

On Tue, 23 May 2017, Christoph Hellwig wrote:

Cc + Mike
Quoted 8 lines

Hi folks,

what's the status of the SGI support for the IA64 SN2-specific altic mmtimer (drivers/char/mmtimer.c)? It's the only driver that register a k_lock outside the core kernel, so if we could get rid of it because the remaining IA64 user are all on somewhat old distros anyway it would make our life a whole lot easier.

#4 lore raw

[tip:timers/core] posix-timers: Remove mmtimer leftovers

posix-timers: Remove mmtimer leftovers
Commit-ID:  f822798e3ced63427d57d128ee8d118126455f84
Gitweb:     http://git.kernel.org/tip/f822798e3ced63427d57d128ee8d118126455f84
Author:     Dimitri Sivanich <[email protected]>
AuthorDate: Fri, 26 May 2017 23:30:52 +0200
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Sat, 27 May 2017 12:58:46 +0200

posix-timers: Remove mmtimer leftovers

After removing mmtimer, the mmtimer struct can be removed from the k_itimer struct.

---
 include/linux/posix-timers.h | 6 ------
 1 file changed, 6 deletions(-)
include/linux/posix-timers.h +0 -6
index b313ef2..34e893a 100644
@@ -73,12 +73,6 @@ struct k_itimer {
 		} real;
 		struct cpu_timer_list cpu;
 		struct {
-			unsigned int clock;
-			unsigned int node;
-			unsigned long incr;
-			unsigned long expires;
-		} mmtimer;
-		struct {
 			struct alarm alarmtimer;
 			ktime_t interval;
 		} alarm;