Skip to contentSkip to conversation

dax: set errors in mapping when writeback fails

PATCH In review Jeff Layton 2 participants 3 messages May 25, 2017 – May 26, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dax: set errors in mapping when writeback fails

Jan's description for this patch is much better than mine, so I'm quoting it verbatim here:

DAX currently doesn't set errors in the mapping when cache flushing fails in dax_writeback_mapping_range(). Since this function can get called only from fsync(2) or sync(2), this is actually as good as it can currently get since we correctly propagate the error up from dax_writeback_mapping_range() to filemap_fdatawrite(). However in the future better writeback error handling will enable us to properly report these errors on fsync(2) even if there are multiple file descriptors open against the file or if sync(2) gets called before fsync(2). So convert DAX to using standard error reporting through the mapping.

---
 fs/dax.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
fs/dax.c +3 -1
index c22eaf162f95..441280e15d5b 100644
@@ -856,8 +856,10 @@ int dax_writeback_mapping_range(struct address_space *mapping,
 
 			ret = dax_writeback_one(bdev, dax_dev, mapping,
 					indices[i], pvec.pages[i]);
-			if (ret < 0)
+			if (ret < 0) {
+				mapping_set_error(mapping, ret);
 				goto out;
+			}
 		}
 	}
 out:
Signature · 1 line
2.9.4
#1 lore raw
Quoted 13 lines · Jeff Layton

Jan's description for this patch is much better than mine, so I'm quoting it verbatim here:

DAX currently doesn't set errors in the mapping when cache flushing fails in dax_writeback_mapping_range(). Since this function can get called only from fsync(2) or sync(2), this is actually as good as it can currently get since we correctly propagate the error up from dax_writeback_mapping_range() to filemap_fdatawrite(). However in the future better writeback error handling will enable us to properly report these errors on fsync(2) even if there are multiple file descriptors open against the file or if sync(2) gets called before fsync(2). So convert DAX to using standard error reporting through the mapping.

Quoted 4 lines

Is this still part of a larger series, or are you trying to submit it on its own? On it's own this patch still suffers from the issue I reported here:

https://lkml.org/lkml/2017/3/6/976

Quoted 23 lines
---
 fs/dax.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
fs/dax.c +3 -1
index c22eaf162f95..441280e15d5b 100644
@@ -856,8 +856,10 @@ int dax_writeback_mapping_range(struct address_space *mapping,
 
 			ret = dax_writeback_one(bdev, dax_dev, mapping,
 					indices[i], pvec.pages[i]);
-			if (ret < 0)
+			if (ret < 0) {
+				mapping_set_error(mapping, ret);
 				goto out;
+			}
 		}
 	}
 out:
Signature · 1 line
2.9.4
#2 lore raw
Quoted 14 lines · Ross Zwisler
Quoted 13 lines · Jeff Layton

Jan's description for this patch is much better than mine, so I'm quoting it verbatim here:

DAX currently doesn't set errors in the mapping when cache flushing fails in dax_writeback_mapping_range(). Since this function can get called only from fsync(2) or sync(2), this is actually as good as it can currently get since we correctly propagate the error up from dax_writeback_mapping_range() to filemap_fdatawrite(). However in the future better writeback error handling will enable us to properly report these errors on fsync(2) even if there are multiple file descriptors open against the file or if sync(2) gets called before fsync(2). So convert DAX to using standard error reporting through the mapping.

Quoted 7 lines
Quoted 4 lines

Is this still part of a larger series, or are you trying to submit it on its own?

I was trying to submit it on its own. Trying to get a series merged that sprawls over the tree like this is proving difficult, so I was hoping to get maintainers to pick up individual patches for their subsystems.

Quoted 4 lines

On it's own this patch still suffers from the issue I reported here:

https://lkml.org/lkml/2017/3/6/976

My bad. I remember seeing you mail this and then let it slip through the

Quoted 2 lines · you

I think maybe the missing piece is that our normal DAX fsync call stack doesn't include a call to filemap_check_errors() if we return -EIO.

I think the actual problem is in filemap_write_and_wait_range. When there is an error from __filemap_fdatawrite_range, we probably ought to go ahead and clear the AS_EIO/AS_ENOSPC flags as well even though we're not waiting on writeback.

I think I had a patch to do that in an earlier iteration of this series, but I dropped it when I started pursuing the errseq_t based error tracking.

Now that we're going to have to do this in a more piecemeal way, it may be worth resurrecting that patch as an interim step before merging this one. I'll see if I can dust that patch off after the holiday weekend.

Thanks,

Signature · 1 line
Jeff Layton <[email protected]>