Skip to contentSkip to conversation

fuse: set mapping error in writepage_locked when it fails

PATCH In review Jeff Layton 2 participants 3 messages May 25, 2017 – May 30, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fuse: set mapping error in writepage_locked when it fails

This ensures that we see errors on fsync when writeback fails.

---
 fs/fuse/file.c | 1 +
 1 file changed, 1 insertion(+)
fs/fuse/file.c +1 -0
index 3ee4fdc3da9e..18518298d109 100644
@@ -1669,6 +1669,7 @@ static int fuse_writepage_locked(struct page *page)
 err_free:
 	fuse_request_free(req);
 err:
+	mapping_set_error(page->mapping, error);
 	end_page_writeback(page);
 	return error;
 }
Signature · 1 line
2.9.4
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Jeff Layton

This ensures that we see errors on fsync when writeback fails.

This is currently the only fuse patch for 4.12. Do you plan to send a pull to Linus with related things? If so then please feel free to take this and add my

Thanks,
Miklos

Quoted 19 lines
---
 fs/fuse/file.c | 1 +
 1 file changed, 1 insertion(+)
fs/fuse/file.c +1 -1
index 3ee4fdc3da9e..18518298d109 100644
@@ -1669,6 +1669,7 @@ static int fuse_writepage_locked(struct page *page)
 err_free:
        fuse_request_free(req);
 err:
+       mapping_set_error(page->mapping, error);
        end_page_writeback(page);
        return error;
 }
--

2.9.4

#2 lore raw
Quoted 7 lines · Miklos Szeredi
Quoted 5 lines · Jeff Layton

This ensures that we see errors on fsync when writeback fails.

Quoted 6 lines

This is currently the only fuse patch for 4.12. Do you plan to send a pull to Linus with related things? If so then please feel free to take this and add my

No, I wasn't planning to send a PR to Linus.

I was really expecting these to go into v4.13 anyway (and maybe linux- next for now). I don't think it'll hurt to merge them into v4.12 though if you end up with other FUSE patches for v4.12 and want to merge it earlier.

Quoted 4 lines
Quoted 4 lines
---
 fs/fuse/file.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 15 lines
Quoted 13 lines
fs/fuse/file.c +1 -1
index 3ee4fdc3da9e..18518298d109 100644
@@ -1669,6 +1669,7 @@ static int fuse_writepage_locked(struct page *page)
 err_free:
        fuse_request_free(req);
 err:
+       mapping_set_error(page->mapping, error);
        end_page_writeback(page);
        return error;
 }
--
Quoted 2 lines

2.9.4

Thanks,

Signature · 1 line
Jeff Layton <[email protected]>