staging/lustre/lov: remove set_fs() call from lov_getstripe()
PATCH 1/1 staging/lustre/lov: remove set_fs() call from lov_getstripe()
lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct lov_user_md pointer from user- or kernel-space. This changes the behavior of copy_from_user() on SPARC and may result in a misaligned access exception which in turn oopses the kernel. In fact the relevant argument to lov_getstripe() is never called with a kernel-space pointer and so changing the address limits is unnecessary and so we remove the calls to save, set, and restore the address limits.
Reviewed-on: http://review.whamcloud.com/6150
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221
--- drivers/staging/lustre/lustre/lov/lov_pack.c | 9 --------- 1 file changed, 9 deletions(-)
drivers/staging/lustre/lustre/lov/lov_pack.c +0 -9
@@ -293,18 +293,10 @@ int lov_getstripe(struct lov_object *obj, struct lov_stripe_md *lsm,size_t lmmk_size;size_t lum_size;int rc; -mm_segment_t seg;if (!lsm)return -ENODATA ; -/* -* "Switch to kernel segment" to allow copying from kernel space by -* copy_{to,from}_user(). -*/ - seg =get_fs (); -set_fs (KERNEL_DS ); -if (lsm->lsm_magic !=LOV_MAGIC_V1 && lsm->lsm_magic !=LOV_MAGIC_V3 ) {CERROR ("bad LSM MAGIC: 0x%08X != 0x%08X nor 0x%08X\n" , lsm->lsm_magic,LOV_MAGIC_V1 ,LOV_MAGIC_V3 );
@@ -406,6 +398,5 @@ int lov_getstripe(struct lov_object *obj, struct lov_stripe_md *lsm, out_free:kvfree (lmmk); out: -set_fs (seg);return rc; }
Signature · 1 line
2.9.3
Greg Kroah-Hartman
maintainerQuoted 10 lines · Oleg Drokin
lov_getstripe()callsset_fs(KERNEL_DS)so that it can handle a structlov_user_mdpointer from user- or kernel-space. This changes the behavior ofcopy_from_user()on SPARC and may result in a misaligned access exception which in turn oopses the kernel. In fact the relevant argument tolov_getstripe()is never called with a kernel-space pointer and so changing the address limits is unnecessary and so we remove the calls to save, set, and restore the address limits.Signed-off-by John L. Hammond <[email protected]>
Quoted 8 lines
Reviewed-on: http://review.whamcloud.com/6150
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221Reviewed-by Andreas Dilger <[email protected]>Reviewed-by Li Wei <[email protected]>Signed-off-by Oleg Drokin <[email protected]>--- drivers/staging/lustre/lustre/lov/lov_pack.c | 9 --------- 1 file changed, 9 deletions(-)
So is this the patch that you want applied to the staging tree(s) as well? If so, please let me know, otherwise I have no clue...
Come on, you know better than this...
greg k-h
Quoted 20 lines · Greg Kroah-Hartman
Quoted 10 lines · Oleg Drokin
lov_getstripe()callsset_fs(KERNEL_DS)so that it can handle a structlov_user_mdpointer from user- or kernel-space. This changes the behavior ofcopy_from_user()on SPARC and may result in a misaligned access exception which in turn oopses the kernel. In fact the relevant argument tolov_getstripe()is never called with a kernel-space pointer and so changing the address limits is unnecessary and so we remove the calls to save, set, and restore the address limits.Signed-off-by John L. Hammond <[email protected]>Quoted 8 lines
Reviewed-on: http://review.whamcloud.com/6150
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221Reviewed-by Andreas Dilger <[email protected]>Reviewed-by Li Wei <[email protected]>Signed-off-by Oleg Drokin <[email protected]>---
drivers/staging/lustre/lustre/lov/lov_pack.c| 9 ---------1 file changed, 9 deletions(-)
Quoted 2 lines
So is this the patch that you want applied to the staging tree(s) as well? If so, please let me know, otherwise I have no clue?
Yes, this is it.
Thanks!