amd-xgbe: use PAGE_ALLOC_COSTLY_ORDER in xgbe_map_rx_buffer
Subsystems (3)
PATCH 1/1 amd-xgbe: use PAGE_ALLOC_COSTLY_ORDER in xgbe_map_rx_buffer
From: Michal Hocko <[email protected]>
xgbe_map_rx_buffer is rather confused about what PAGE_ALLOC_COSTLY_ORDER means. It uses PAGE_ALLOC_COSTLY_ORDER-1 assuming that PAGE_ALLOC_COSTLY_ORDER is the first costly order which is not the case actually because orders larger than that are costly. And even that applies only to sleeping allocations which is not the case here. We simply do not perform any costly operations like reclaim or compaction for those. Simplify the code by dropping the order calculation and use PAGE_ALLOC_COSTLY_ORDER directly.
--- drivers/net/ethernet/amd/xgbe/xgbe-desc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/ethernet/amd/xgbe/xgbe-desc.c +2 -3
@@ -324,7 +324,7 @@ static int xgbe_map_rx_buffer(struct xgbe_prv_data *pdata,struct xgbe_ring *ring, struct xgbe_ring_data *rdata) { - int order, ret; + int ret;if (!ring->rx_hdr_pa.pages) { ret =xgbe_alloc_pages (pdata, &ring->rx_hdr_pa,GFP_ATOMIC ,0 );
@@ -333,9 +333,8 @@ static int xgbe_map_rx_buffer(struct xgbe_prv_data *pdata, }if (!ring->rx_buf_pa.pages) { - order =max_t (int,PAGE_ALLOC_COSTLY_ORDER -1 ,0 ); ret =xgbe_alloc_pages (pdata, &ring->rx_buf_pa,GFP_ATOMIC , - order); +PAGE_ALLOC_COSTLY_ORDER );if (ret)return ret; }
Signature · 1 line
2.11.0
Quoted 11 lines · Michal Hocko
From: Michal Hocko <[email protected]>
xgbe_map_rx_bufferis rather confused about whatPAGE_ALLOC_COSTLY_ORDERmeans. It uses PAGE_ALLOC_COSTLY_ORDER-1 assuming thatPAGE_ALLOC_COSTLY_ORDERis the first costly order which is not the case actually because orders larger than that are costly. And even that applies only to sleeping allocations which is not the case here. We simply do not perform any costly operations like reclaim or compaction for those. Simplify the code by dropping the order calculation and usePAGE_ALLOC_COSTLY_ORDERdirectly.
Quoted 1 line
Signed-off-by Michal Hocko <[email protected]>
Quoted 29 lines
--- drivers/net/ethernet/amd/xgbe/xgbe-desc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/net/ethernet/amd/xgbe/xgbe-desc.c +2
-3@@ -324,7 +324,7 @@ static int xgbe_map_rx_buffer(struct xgbe_prv_data *pdata,struct xgbe_ring *ring, struct xgbe_ring_data *rdata) { - int order, ret; + int ret;if (!ring->rx_hdr_pa.pages) { ret =xgbe_alloc_pages (pdata, &ring->rx_hdr_pa,GFP_ATOMIC ,0 );@@ -333,9 +333,8 @@ static int xgbe_map_rx_buffer(struct xgbe_prv_data *pdata, }if (!ring->rx_buf_pa.pages) { - order =max_t (int,PAGE_ALLOC_COSTLY_ORDER -1 ,0 ); ret =xgbe_alloc_pages (pdata, &ring->rx_buf_pa,GFP_ATOMIC , - order); +PAGE_ALLOC_COSTLY_ORDER );if (ret)return ret; }
From: Michal Hocko <[email protected]>
Date: Fri, 2 Jun 2017 17:54:08 +0200
Quoted 11 lines
From: Michal Hocko <[email protected]>
xgbe_map_rx_bufferis rather confused about whatPAGE_ALLOC_COSTLY_ORDERmeans. It uses PAGE_ALLOC_COSTLY_ORDER-1 assuming thatPAGE_ALLOC_COSTLY_ORDERis the first costly order which is not the case actually because orders larger than that are costly. And even that applies only to sleeping allocations which is not the case here. We simply do not perform any costly operations like reclaim or compaction for those. Simplify the code by dropping the order calculation and usePAGE_ALLOC_COSTLY_ORDERdirectly.
Quoted 1 line
Signed-off-by Michal Hocko <[email protected]>
Applied.