ltp: update add_key tests for nonempty NULL payload fix
Hi!
Quoted 3 lines
(The reason I'm not simply changing the
add_key02test is that I don't want it to appear as a regression on old kernels. I'm not sure exactly how this kind of thing is typically handled in LTP, though.)
What exactly do you mean by a regression here? The fact that it may crash older kernels? That is pretty much fine, when test fails/kernel crashes manual intervention is required and one of the first things you do is git log for the test.
Signature · 2 lines
Cyril Hrubis [email protected]
Hi Cyril,
Quoted 10 lines · Cyril Hrubis
Hi!
Quoted 3 lines
(The reason I'm not simply changing the
add_key02test is that I don't want it to appear as a regression on old kernels. I'm not sure exactly how this kind of thing is typically handled in LTP, though.)What exactly do you mean by a regression here? The fact that it may crash older kernels? That is pretty much fine, when test fails/kernel crashes manual intervention is required and one of the first things you do is git log for the test.
When I had tried updating existing tests in xfstests to test more cases, I was told it shouldn't be done because then the test would start failing on some systems as a result of the test change, rather than as a result of a kernel regression. So it would be more difficult to figure out what caused the test regression.
Personally, I don't align quite as strongly with that viewpoint (and maybe you and the other LTP developers don't either) because this can, after all, only be a problem in cases where the test suite is upgraded, and furthermore if a test fails it's helpful to 'git log' the test anyway.
Would you suggest I simply update add_key02 instead?
Eric
Hi!
Quoted 6 lines
Personally, I don't align quite as strongly with that viewpoint (and maybe you and the other LTP developers don't either) because this can, after all, only be a problem in cases where the test suite is upgraded, and furthermore if a test fails it's helpful to 'git log' the test anyway.
Would you suggest I simply update
add_key02instead?
Yes, I would have done that as well.
Signature · 2 lines
Cyril Hrubis [email protected]