Skip to contentSkip to conversation

mux: adg792a: always require I2C support

PATCH In review Arnd Bergmann 3 participants 3 messages Jun 9, 2017 Multiplexer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mux: adg792a: always require I2C support

COMPILE_TEST makes no sense when I2C is disabled, as the driver cannot compile in that configuration:

drivers/mux/mux-adg792a.c: In function 'adg792a_write_cmd':
drivers/mux/mux-adg792a.c:34:9: error: implicit declaration of function 'i2c_smbus_write_byte_data'; did you mean 'i2c_set_clientdata'? [-Werror=implicit-function-declaration] drivers/mux/mux-adg792a.o: In function `adg792a_driver_init':
mux-adg792a.c:(.init.text+0x14): undefined reference to `i2c_register_driver'
drivers/mux/mux-adg792a.o: In function `adg792a_probe':
mux-adg792a.c:(.text.adg792a_probe+0x94): undefined reference to `i2c_smbus_write_byte_data'
drivers/mux/mux-adg792a.o: In function `adg792a_set':
mux-adg792a.c:(.text.adg792a_set+0x80): undefined reference to `i2c_smbus_write_byte_data'

Fixes afda08c4caa9 ("mux: adg792a: add mux controller driver for ADG792A/G")
---
 drivers/mux/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mux/Kconfig +1 -1
index e8f1df74644c..7c754a0f14bb 100644
@@ -19,7 +19,7 @@ if MULTIPLEXER
 
 config MUX_ADG792A
 	tristate "Analog Devices ADG792A/ADG792G Multiplexers"
-	depends on I2C || COMPILE_TEST
+	depends on I2C
 	help
 	  ADG792A and ADG792G Wide Bandwidth Triple 4:1 Multiplexers
 
Signature · 1 line
2.9.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Arnd Bergmann

COMPILE_TEST makes no sense when I2C is disabled, as the driver cannot compile in that configuration:

Ouch, thanks for catching!

Greg, I assume you will you be taking this?

Cheers,
peda

#2 lore raw
Quoted 9 lines · Peter Rosin
Quoted 2 lines · Arnd Bergmann

COMPILE_TEST makes no sense when I2C is disabled, as the driver cannot compile in that configuration:

Ouch, thanks for catching!

Greg, I assume you will you be taking this?

Yes, will do so now, thanks.

greg k-h