tests/chamelium: Set output pipe after mode change to refresh output
PATCH 1/1 tests/chamelium: Set output pipe after mode change to refresh output
This adds a call to igt_output_set_pipe in orde to refresh output via igt_output_refresh and ensure that mode override can take effect.
Without this change, using a lower resolution during frame dumps series with mode changes (e.g. test_display_frame_dump) would not commit the mode change to the output and leave it with a framebuffer too small for the previously-commited resolution.
This would cause the test to fail. This allows it to pass.
--- tests/chamelium.c | 2 ++ 1 file changed, 2 insertions(+)
tests/chamelium.c +2 -0
@@ -322,6 +322,8 @@ enable_output(data_t *data,igt_plane_set_fb (primary, fb);igt_output_override_mode (output, mode); +igt_output_set_pipe (output, output->config.pipe); +/* Clear any color correction values that might be enabled */ igt_pipe_set_degamma_lut (primary->pipe,NULL ,0 );igt_pipe_set_gamma_lut (primary->pipe,NULL ,0 );
Signature · 6 lines
2.13.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Paul Kocialkowski
This adds a call to
igt_output_set_pipein orde to refresh output viaigt_output_refreshand ensure that mode override can take effect.Without this change, using a lower resolution during frame dumps series with mode changes (e.g.
test_display_frame_dump) would not commit the mode change to the output and leave it with a framebuffer too small for the previously-commited resolution.This would cause the test to fail. This allows it to pass.
Signed-off-by Paul Kocialkowski <[email protected]>
Thanks for the important fix! This must have gotten broken with some igt rework someone did down the line while I was gone. Will push in a moment :).
Quoted 18 lines
---
tests/chamelium.c | 2 ++1 file changed, 2 insertions(+)tests/chamelium.c +0
-0@@ -322,6 +322,8 @@ enable_output(data_t *data, igt_plane_set_fb(primary, fb); igt_output_override_mode(output, mode);tests/chamelium.c +2
-0+igt_output_set_pipe (output, output->config.pipe); +/* Clear any color correction values that might be enabled */
igt_pipe_set_degamma_lut(primary->pipe, NULL, 0);igt_pipe_set_gamma_lut(primary->pipe, NULL, 0);
Signature · 6 lines
Cheers, Lyude _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Lyude Paul
Quoted 10 lines · Paul Kocialkowski
This adds a call to
igt_output_set_pipein orde to refresh output viaigt_output_refreshand ensure that mode override can take effect.Without this change, using a lower resolution during frame dumps series with mode changes (e.g.
test_display_frame_dump) would not commit the mode change to the output and leave it with a framebuffer too small for the previously-commited resolution.This would cause the test to fail. This allows it to pass.
Quoted 7 lines
Quoted 1 line
Signed-off-by Paul Kocialkowski <[email protected]>Reviewed-by Lyude Paul <[email protected]>Thanks for the important fix! This must have gotten broken with some igt rework someone did down the line while I was gone. Will push in a moment :).
Thanks for the review!
Quoted 18 lines
Quoted 18 lines
--- tests/chamelium.c | 2 ++ 1 file changed, 2 insertions(+)tests/chamelium.c +2
-0@@ -322,6 +322,8 @@ enable_output(data_t *data,igt_plane_set_fb (primary, fb);igt_output_override_mode (output, mode); +igt_output_set_pipe (output, output->config.pipe); +/* Clear any color correction values that might be enabled */ igt_pipe_set_degamma_lut (primary->pipe,NULL ,0 );
igt_pipe_set_gamma_lut(primary->pipe, NULL, 0);
Signature · 6 lines
Paul Kocialkowski <[email protected]> Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx