Skip to contentSkip to conversation

Fix copy/paste error in error message

PATCH In review Tom St Denis 2 participants 2 messages Jun 22, 2017 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix copy/paste error in error message

Also fix a couple of error message style deviations.

---
 src/lib/mmio.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
src/lib/mmio.c +4 -4
index f0737c43913a..987704cb9944 100644
@@ -39,7 +39,7 @@ static uint32_t umr_smc_read(struct umr_asic *asic, uint64_t addr)
 				umr_write_reg_by_name(asic, "mmMP0PUB_IND_INDEX_1", addr);
 				return umr_read_reg_by_name(asic, "mmMP0PUB_IND_DATA_1");
 			default:
-				fprintf(stderr, "[BUG] Unsupported family type in umr_smc_read()\n");
+				fprintf(stderr, "[BUG]: Unsupported family type in umr_smc_read()\n");
 				return 0;
 		}
 	} else {
@@ -66,7 +66,7 @@ static uint32_t umr_smc_write(struct umr_asic *asic, uint64_t addr, uint32_t val
 				umr_write_reg_by_name(asic, "mmMP0PUB_IND_INDEX_1", addr);
 				return umr_write_reg_by_name(asic, "mmMP0PUB_IND_DATA_1", value);
 			default:
-				fprintf(stderr, "[BUG] Unsupported family type in umr_smc_read()\n");
+				fprintf(stderr, "[BUG]: Unsupported family type in umr_smc_write()\n");
 				return -1;
 		}
 	} else {
@@ -103,7 +103,7 @@ uint32_t umr_read_reg(struct umr_asic *asic, uint64_t addr, enum regclass type)
 		case REG_SMC:
 			return umr_smc_read(asic, addr);
 		default:
-			fprintf(stderr, "[BUG] Unsupported register type in umr_read_reg().\n");
+			fprintf(stderr, "[BUG]: Unsupported register type in umr_read_reg().\n");
 			return 0;
 	}
 }
@@ -131,7 +131,7 @@ int umr_write_reg(struct umr_asic *asic, uint64_t addr, uint32_t value, enum reg
 		case REG_SMC:
 			return umr_smc_write(asic, addr, value);
 		default:
-			fprintf(stderr, "[BUG] Unsupported register type in umr_write_reg().\n");
+			fprintf(stderr, "[BUG]: Unsupported register type in umr_write_reg().\n");
 			return -1;
 	}
 	return 0;
Signature · 6 lines
2.12.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by Alex Deucher
#2 lore raw
Quoted 11 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Tom St Denis
Sent: Thursday, June 22, 2017 9:38 AM
To: [email protected]
Cc: StDenis, Tom
Subject: [PATCH umr] Fix copy/paste error in error message

Also fix a couple of error message style deviations.

Quoted 63 lines
---
 src/lib/mmio.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
src/lib/mmio.c +0 -1
index f0737c43913a..987704cb9944 100644
@@ -39,7 +39,7 @@ static uint32_t umr_smc_read(struct umr_asic *asic,
 uint64_t addr)
 				umr_write_reg_by_name(asic,
 "mmMP0PUB_IND_INDEX_1", addr);
 				return umr_read_reg_by_name(asic,
 "mmMP0PUB_IND_DATA_1");
 			default:
-				fprintf(stderr, "[BUG] Unsupported family

type in umr_smc_read()\n");

src/lib/mmio.c +1 -0
+				fprintf(stderr, "[BUG]: Unsupported family

type in umr_smc_read()\n");

src/lib/mmio.c +0 -0
 				return 0;
 		}
 	} else {
@@ -66,7 +66,7 @@ static uint32_t umr_smc_write(struct umr_asic *asic,

uint64_t addr, uint32_t val
umr_write_reg_by_name(asic,
"mmMP0PUB_IND_INDEX_1", addr);
return umr_write_reg_by_name(asic,
"mmMP0PUB_IND_DATA_1", value);

src/lib/mmio.c +0 -1
 			default:
-				fprintf(stderr, "[BUG] Unsupported family

type in umr_smc_read()\n");

src/lib/mmio.c +1 -0
+				fprintf(stderr, "[BUG]: Unsupported family

type in umr_smc_write()\n");

src/lib/mmio.c +1 -1
 				return -1;
 		}
 	} else {
@@ -103,7 +103,7 @@ uint32_t umr_read_reg(struct umr_asic *asic,
 uint64_t addr, enum regclass type)
 		case REG_SMC:
 			return umr_smc_read(asic, addr);
 		default:
-			fprintf(stderr, "[BUG] Unsupported register type in
 umr_read_reg().\n");
+			fprintf(stderr, "[BUG]: Unsupported register type in
 umr_read_reg().\n");
src/lib/mmio.c +0 -0
 			return 0;
 	}
 }
@@ -131,7 +131,7 @@ int umr_write_reg(struct umr_asic *asic, uint64_t

addr, uint32_t value, enum reg

src/lib/mmio.c +0 -1
 		case REG_SMC:
 			return umr_smc_write(asic, addr, value);
 		default:
-			fprintf(stderr, "[BUG] Unsupported register type in

umr_write_reg().\n");

src/lib/mmio.c +1 -0
+			fprintf(stderr, "[BUG]: Unsupported register type in

umr_write_reg().\n");

src/lib/mmio.c +0 -1
 			return -1;
 	}
 	return 0;
--

2.12.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx