Skip to contentSkip to conversation

igb: Remove incorrect ""unexpected SYS WRAP" log message

PATCH New Corinna Vinschen 2 participants 3 messages Jun 23, 2017 – Jun 28, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 igb: Remove incorrect ""unexpected SYS WRAP" log message

TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000 secs on 80576 (45 bit SYSTIM).

This wrap event sets the TSICR.SysWrap bit unconditionally.

However, checking TSIM at interrupt time shows that this event does not actually cause the interrupt. Rather, it's just bycatch while the actual interrupt is caused by, for instance, TSICR.TXTS.

The conclusion is that the SYS WRAP is actually expected, so the "unexpected SYS WRAP" message is entirely bogus and just helps to confuse users. Drop it.

---
 drivers/net/ethernet/intel/igb/igb_main.c | 2 --
 1 file changed, 2 deletions(-)
drivers/net/ethernet/intel/igb/igb_main.c +0 -2
index 3558ad8..394e77e 100644
@@ -5746,8 +5746,6 @@ static void igb_tsync_interrupt(struct igb_adapter *adapter)
 		event.type = PTP_CLOCK_PPS;
 		if (adapter->ptp_caps.pps)
 			ptp_clock_event(adapter->ptp_clock, &event);
-		else
-			dev_err(&adapter->pdev->dev, "unexpected SYS WRAP");
 		ack |= TSINTR_SYS_WRAP;
 	}
 
Signature · 1 line
2.9.4
#1 lore raw

PATCH 1/1 igb: Remove incorrect ""unexpected SYS WRAP" log message

Quoted 20 lines

-----Original Message-----
From: Corinna Vinschen [mailto:vinschen at redhat.com]
Sent: Friday, June 23, 2017 5:27 AM
To: intel-wired-lan at lists.osuosl.org
Cc: sassmann at kpanic.de; Keller, Jacob E <[email protected]>; jbainbri at redhat.com
Subject: [PATCH] igb: Remove incorrect ""unexpected SYS WRAP" log message

TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000 secs on 80576 (45 bit SYSTIM).

This wrap event sets the TSICR.SysWrap bit unconditionally.

However, checking TSIM at interrupt time shows that this event does not actually cause the interrupt. Rather, it's just bycatch while the actual interrupt is caused by, for instance, TSICR.TXTS.

Quoted 6 lines

The conclusion is that the SYS WRAP is actually expected, so the "unexpected SYS WRAP" message is entirely bogus and just helps to confuse users. Drop it.

---

This reasoning seems sound to me.

Quoted 21 lines
 drivers/net/ethernet/intel/igb/igb_main.c | 2 --
 1 file changed, 2 deletions(-)
drivers/net/ethernet/intel/igb/igb_main.c +0 -2
index 3558ad8..394e77e 100644
@@ -5746,8 +5746,6 @@ static void igb_tsync_interrupt(struct igb_adapter
 *adapter)
 		event.type = PTP_CLOCK_PPS;
 		if (adapter->ptp_caps.pps)
 			ptp_clock_event(adapter->ptp_clock, &event);
-		else
-			dev_err(&adapter->pdev->dev, "unexpected SYS
 WRAP");
 		ack |= TSINTR_SYS_WRAP;

}

--
2.9.4

#2 lore raw

PATCH 1/1 igb: Remove incorrect ""unexpected SYS WRAP" log message

In reply to Corinna Vinschen
Quoted 18 lines

From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Corinna Vinschen
Sent: Friday, June 23, 2017 5:27 AM
To: intel-wired-lan at lists.osuosl.org
Cc: sassmann at kpanic.de; jbainbri at redhat.com
Subject: [Intel-wired-lan] [PATCH] igb: Remove incorrect ""unexpected SYS WRAP" log message

TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000 secs on 80576 (45 bit SYSTIM).

This wrap event sets the TSICR.SysWrap bit unconditionally.

However, checking TSIM at interrupt time shows that this event does not actually cause the interrupt. Rather, it's just bycatch while the actual interrupt is caused by, for instance, TSICR.TXTS.

Quoted 8 lines

The conclusion is that the SYS WRAP is actually expected, so the "unexpected SYS WRAP" message is entirely bogus and just helps to confuse users. Drop it.

---
 drivers/net/ethernet/intel/igb/igb_main.c | 2 --
 1 file changed, 2 deletions(-)