x86: xen: remove unnecessary variable in xen_foreach_remap_area()
Subsystems (2)
PATCH 1/1 x86: xen: remove unnecessary variable in xen_foreach_remap_area()
Remove unnecessary variable mfn in function xen_foreach_remap_area() and, refactor the code.
Variable mfn at line 518:mfn = xen_remap_buf.mfns[i]; is only being used to store a value to be passed as an argument to the xen_update_mem_tables() function. This value can be passed directly, which makes variable mfn unnecessary. Also, value assigned to variable mfn at line 534:mfn = xen_remap_mfn; is never used.
Addresses-Coverity-ID: 1260110
--- arch/x86/xen/setup.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
arch/x86/xen/setup.c +2 -5
@@ -499,7 +499,7 @@ static unsigned long __init xen_foreach_remap_area(unsigned long nr_pages,void __init xen_remap_memory (void ) {unsigned long buf = (unsigned long )&xen_remap_buf; -unsigned long mfn_save, mfn, pfn; +unsigned long mfn_save, pfn;unsigned long remapped =0 ;unsigned int i;unsigned long pfn_s = ~0UL ;
@@ -515,8 +515,7 @@ void __init xen_remap_memory(void) pfn = xen_remap_buf.target_pfn;for (i =0 ; i < xen_remap_buf.size; i++) { - mfn = xen_remap_buf.mfns[i]; -xen_update_mem_tables (pfn, mfn); +xen_update_mem_tables (pfn, xen_remap_buf.mfns[i]); remapped++; pfn++; }
@@ -530,8 +529,6 @@ void __init xen_remap_memory(void) pfn_s = xen_remap_buf.target_pfn; len = xen_remap_buf.size; } - - mfn = xen_remap_mfn; xen_remap_mfn = xen_remap_buf.next_area_mfn; }
Signature · 1 line
2.5.0
Quoted 10 lines · Gustavo A. R. Silva
Remove unnecessary variable mfn in function
xen_foreach_remap_area()and, refactor the code.Variable mfn at line 518:mfn = xen_remap_buf.mfns[i]; is only being used to store a value to be passed as an argument to the
xen_update_mem_tables()function. This value can be passed directly, which makes variable mfn unnecessary. Also, value assigned to variable mfn at line 534:mfn =xen_remap_mfn; is never used.
Quoted 2 lines
Addresses-Coverity-ID: 1260110
Signed-off-by Gustavo A. R. Silva <[email protected]>
Thanks,
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
Quoted 10 lines · Gustavo A. R. Silva
Remove unnecessary variable mfn in function
xen_foreach_remap_area()and, refactor the code.Variable mfn at line 518:mfn = xen_remap_buf.mfns[i]; is only being used to store a value to be passed as an argument to the
xen_update_mem_tables()function. This value can be passed directly, which makes variable mfn unnecessary. Also, value assigned to variable mfn at line 534:mfn =xen_remap_mfn; is never used.
Quoted 2 lines
Addresses-Coverity-ID: 1260110
Signed-off-by Gustavo A. R. Silva <[email protected]>
Thanks,
Juergen
Quoted 10 lines · Gustavo A. R. Silva
Remove unnecessary variable mfn in function
xen_foreach_remap_area()and, refactor the code.Variable mfn at line 518:mfn = xen_remap_buf.mfns[i]; is only being used to store a value to be passed as an argument to the
xen_update_mem_tables()function. This value can be passed directly, which makes variable mfn unnecessary. Also, value assigned to variable mfn at line 534:mfn =xen_remap_mfn; is never used.
Quoted 2 lines
Addresses-Coverity-ID: 1260110
Signed-off-by Gustavo A. R. Silva <[email protected]>
Queued to xen/tip.git for-linus-4.13
Thanks,
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
Quoted 10 lines · Gustavo A. R. Silva
Remove unnecessary variable mfn in function
xen_foreach_remap_area()and, refactor the code.Variable mfn at line 518:mfn = xen_remap_buf.mfns[i]; is only being used to store a value to be passed as an argument to the
xen_update_mem_tables()function. This value can be passed directly, which makes variable mfn unnecessary. Also, value assigned to variable mfn at line 534:mfn =xen_remap_mfn; is never used.
Quoted 2 lines
Addresses-Coverity-ID: 1260110
Signed-off-by Gustavo A. R. Silva <[email protected]>
Queued to xen/tip.git for-linus-4.13
Thanks,
Juergen