powerpc/64s: watchdog false positive warning at CPU unplug
Nicholas Piggin
reviewerPATCH 1/1 powerpc/64s: watchdog false positive warning at CPU unplug
CPU unplug will call stop_wd_on_cpu regardless if the watchdog has been configured to be enabled on that CPU. Don't warn in the case it's not in our enabled mask, this is a valid case.
Fixes powerpc-64s-implement-arch-specific-hardlockup-watchdog.patch
Reported-by Santosh Sivaraj <[email protected]>
Signed-off-by Nicholas Piggin <[email protected]>
--- arch/powerpc/kernel/watchdog.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
arch/powerpc/kernel/watchdog.c +2 -4
@@ -310,10 +310,8 @@ static int start_wd_on_cpu(unsigned int cpu)static int stop_wd_on_cpu (unsigned int cpu) { -if (!cpumask_test_cpu (cpu, &wd_cpus_enabled)) { -WARN_ON (1 ); -return 0 ; - } +if (!cpumask_test_cpu (cpu, &wd_cpus_enabled)) +return 0 ;/* Can happen in CPU unplug case */ stop_watchdog_timer_on (cpu);
Signature · 1 line
2.11.0
Quoted 10 lines · Nicholas Piggin
CPU unplug will call
stop_wd_on_cpuregardless if the watchdog has been configured to be enabled on that CPU. Don't warn in the case it's not in our enabled mask, this is a valid case.Fixes powerpc-64s-implement-arch-specific-hardlockup-watchdog.patchReported-by Santosh Sivaraj <[email protected]>Signed-off-by Nicholas Piggin <[email protected]>--- arch/powerpc/kernel/watchdog.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Acked-by Michael Ellerman <[email protected]>
cheers