irqchip: or1k-pic: Fix interrupt system.
Stafford Horne
Acked-by+CC Kernel List
Quoted 9 lines · Pedro H. Penna
Usually, hardware implicitly acknowledges interruts when reading them. However, if this is not the case, the IRQ gets fired over and over again in the current implementation.
This patch uses the right mask acknowledge function to handle the aforementioned situation on or1k processors that interact with such kind of hardware.
Signed-off-by Pedro H. Penna <[email protected]>
I am ok to take this patch into my tree if no one objects. But if someone wants to take it through the drive tree I am fine too.
Quoted 20 lines
--- drivers/irqchip/irq-or1k-pic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/irqchip/irq-or1k-pic.c +1
-1@@ -70,7 +70,7 @@ static struct or1k_pic_dev or1k_pic_level = { .name = "or1k-PIC-level", .irq_unmask = or1k_pic_unmask, .irq_mask = or1k_pic_mask, - .irq_mask_ack = or1k_pic_mask, + .irq_mask_ack = or1k_pic_mask_ack, }, .handle = handle_level_irq, .flags = IRQ_LEVEL | IRQ_NOPROBE,Signature · 1 line
2.7.4
Quoted 7 lines · Stafford Horne
+CC Kernel List
Quoted 4 lines · Pedro H. Penna
Usually, hardware implicitly acknowledges interruts when reading them. However, if this is not the case, the IRQ gets fired over and over again in the current implementation.
Quoted 7 lines
Quoted 5 lines
This patch uses the right mask acknowledge function to handle the aforementioned situation on or1k processors that interact with such kind of hardware.
Signed-off-by Pedro H. Penna <[email protected]>Acked-by Stafford Horne
Can you please Ack it with an email address?
Quoted 3 lines
I am ok to take this patch into my tree if no one objects. But if someone wants to take it through the drive tree I am fine too.
I'll queue it through my tree, as I have some last minute fixes to send to Thomas.
Thanks,
M.
Signature · 1 line
Jazz is not dead. It just smells funny...
Stafford Horne
Acked-byQuoted 12 lines · Marc Zyngier
Quoted 11 lines · Stafford Horne
+CC Kernel List
Quoted 8 lines · Pedro H. Penna
Usually, hardware implicitly acknowledges interruts when reading them. However, if this is not the case, the IRQ gets fired over and over again in the current implementation.
This patch uses the right mask acknowledge function to handle the aforementioned situation on or1k processors that interact with such kind of hardware.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Pedro H. Penna <[email protected]>Acked-by Stafford HorneCan you please Ack it with an email address?
Sorry about that:
Quoted 6 lines
Quoted 3 lines
I am ok to take this patch into my tree if no one objects. But if someone wants to take it through the drive tree I am fine too.
I'll queue it through my tree, as I have some last minute fixes to send to Thomas.
Thanks,
-Stafford