Skip to contentSkip to conversation

staging: sm750fb: refactor method and fix potential type inconsistence

PATCH In review Lynn Lei 2 participants 2 messages Jul 2, 2017 – Jul 3, 2017

Subsystems (3)
lore
Share & tools
lore

Lynn Lei

author
#0 lore raw

PATCH v2 1/1 staging: sm750fb: refactor method and fix potential type inconsistence

include PANEL_DISPLAY_CTRL_FPVDDEN control mask

---
 drivers/staging/sm750fb/ddk750_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_display.c +1 -1
index 0f666dc2729a..c68367e6cdeb 100644
@@ -89,7 +89,7 @@ static void swPanelPowerSequence(int disp, int delay)
 	u32 reg;
 	u32 opt[] = {
 		PANEL_DISPLAY_CTRL_FPEN, PANEL_DISPLAY_CTRL_DATA,
-		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPEN,
+		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPVDDEN,
 	};
 	u32 size, i;
 
Signature · 1 line
2.13.2
maintainer
#1 lore raw
Quoted 1 line · Lynn Lei

include PANEL_DISPLAY_CTRL_FPVDDEN control mask

Does the subject match this?

Quoted 10 lines
---
 drivers/staging/sm750fb/ddk750_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_display.c +0 -0
index 0f666dc2729a..c68367e6cdeb 100644

drivers/staging/sm750fb/ddk750_display.c static void swPanelPowerSequence(int disp, int delay) · line 92

Quoted 5 lines
drivers/staging/sm750fb/ddk750_display.c +1 -1
@@ -89,7 +89,7 @@ static void swPanelPowerSequence(int disp, int delay)
 	u32 reg;
 	u32 opt[] = {
 		PANEL_DISPLAY_CTRL_FPEN, PANEL_DISPLAY_CTRL_DATA,
-		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPEN,
+		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPVDDEN,

Are you sure this is allowed? Why is this patch correct?

And again, it doesn't match the subject line :(

greg k-h