regulator: qcom_smd: add NULL check on of_match_device() return value

PATCH New Gustavo A. R. Silva 1 participant 1 message Jul 7, 2017

Subsystems (2)

Arm Qualcomm mailing list Voltage and current regulator framework

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-07-07 05:36 UTC #0 lore raw

PATCH 1/1 regulator: qcom_smd: add NULL check on of_match_device() return value

Check return value from call to of_match_device()
in order to prevent a NULL pointer dereference.

In case of NULL print error message and return.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/regulator/qcom_smd-regulator.c | 5 +++++
 1 file changed, 5 insertions(+)

drivers/regulator/qcom_smd-regulator.c +5 -0

index f35994a..940fe1b 100644
@@ -570,6 +570,11 @@ static int rpm_reg_probe(struct platform_device *pdev)
 	}
 
 	match = of_match_device(rpm_of_match, &pdev->dev);
+	if (!match) {
+		dev_err(&pdev->dev, "failed to match device\n");
+		return -ENODEV;
+	}
+
 	for (reg = match->data; reg->name; reg++) {
 		vreg = devm_kzalloc(&pdev->dev, sizeof(*vreg), GFP_KERNEL);
 		if (!vreg)

Signature · 1 line

2.5.0