auxdisplay: cfag12864bfb: constify fb_fix_screeninfo and fb_var_screeninfo structures
Subsystems (2)
PATCH 1/1 auxdisplay: cfag12864bfb: constify fb_fix_screeninfo and fb_var_screeninfo structures
These structures are only used to copy into other structures, so declare them as const.
This issue was detected using Coccinelle and the following semantic patch:
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct fb_fix_screeninfo i@p = { ... };
@ok@
identifier r.i;
expression e;
position p;
@@
e = i@p
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct fb_fix_screeninfo e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct fb_fix_screeninfo i = { ... };
The semantic patch for fb_var_screeninfo is analogous.
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/auxdisplay/cfag12864bfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/auxdisplay/cfag12864bfb.c +2 -2
@@ -37,7 +37,7 @@#define CFAG12864BFB_NAME "cfag12864bfb" -static struct fb_fix_screeninfo cfag12864bfb_fix = { +static const struct fb_fix_screeninfo cfag12864bfb_fix = { .id ="cfag12864b" , .type =FB_TYPE_PACKED_PIXELS , .visual =FB_VISUAL_MONO10 ,
@@ -48,7 +48,7 @@ static struct fb_fix_screeninfo cfag12864bfb_fix = { .accel = FB_ACCEL_NONE, }; -static struct fb_var_screeninfo cfag12864bfb_var = { +static const struct fb_var_screeninfo cfag12864bfb_var = { .xres =CFAG12864B_WIDTH , .yres =CFAG12864B_HEIGHT , .xres_virtual =CFAG12864B_WIDTH ,
Signature · 1 line
2.5.0