usb: chipidea: udc: compress return logic into line

PATCH New Gustavo A. R. Silva 1 participant 1 message Jul 10, 2017

Subsystems (2)

USB Chipidea USB high speed dual role controller

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-07-10 02:08 UTC #0 lore raw

PATCH 1/1 usb: chipidea: udc: compress return logic into line

Simplify return logic to avoid unnecessary variable assignment.

This issue was detected using Coccinelle and the following semantic patch:

@@
local idexpression ret;
expression e;
@@

-ret =
+return

e;

-return ret;

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/usb/chipidea/udc.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

drivers/usb/chipidea/udc.c +1 -4

index d68b125..6502c13 100644
@@ -944,7 +944,6 @@ isr_setup_status_complete(struct usb_ep *ep, struct usb_request *req)
  */
 static int isr_setup_status_phase(struct ci_hdrc *ci)
 {
-	int retval;
 	struct ci_hw_ep *hwep;
 
 	/*

@@ -960,9 +959,7 @@ static int isr_setup_status_phase(struct ci_hdrc *ci)
 	ci->status->context = ci;
 	ci->status->complete = isr_setup_status_complete;
 
-	retval = _ep_queue(&hwep->ep, ci->status, GFP_ATOMIC);
-
-	return retval;
+	return _ep_queue(&hwep->ep, ci->status, GFP_ATOMIC);
 }
 
 /**

Signature · 1 line

2.5.0