ALSA: pcm: Simplify check for dma_mmap_coherent() availability
PATCH 1/1 ALSA: pcm: Simplify check for dma_mmap_coherent() availability
We check the availability of dma_mmap_coherent() in hw_support_mmap() but with an ugly ifdef of lots of arch-checks. Now we have a nice CONFIG_ARCH_NO_COHERENT_DMA_MMAP kconfig, and this can be used together with CONFIG_HAS_DMA check for a cleaner and more comprehensive check.
Signed-off-by Takashi Iwai <[email protected]>
--- sound/core/pcm_native.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
sound/core/pcm_native.c +2 -4
@@ -238,10 +238,8 @@ static bool hw_support_mmap(struct snd_pcm_substream *substream) {if (!(substream->runtime->hw.info &SNDRV_PCM_INFO_MMAP ))return false; -/* check architectures that return -EINVAL from dma_mmap_coherent() */ -/* FIXME: this should be some global flag */ -#if defined(CONFIG_C6X ) || defined(CONFIG_FRV ) || defined(CONFIG_MN10300 ) ||\ - defined(CONFIG_PARISC ) || defined(CONFIG_XTENSA ) +/* architecture supports dma_mmap_coherent()? */ +#if defined(CONFIG_ARCH_NO_COHERENT_DMA_MMAP ) || !defined(CONFIG_HAS_DMA )if (!substream->ops->mmap && substream->dma_buffer.dev.type ==SNDRV_DMA_TYPE_DEV )return false;
Signature · 1 line
2.13.2