Skip to contentSkip to conversation

ARM64: DT: add 'ranges' to chosen node

PATCH In review Rob Clark 1 participant 2 messages Jul 10, 2017

Subsystems (3)
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 ARM64: DT: add 'ranges' to chosen node

Some LK's can populate chosen with a simple-framebuffer node to hand over bootloader display to kernel (or u-boot/etc). But kernel fails to grok it properly without knowing address/size size.

---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/msm8916.dtsi +3 -1
index 56549063396f..5c36a0934989 100644
@@ -30,7 +30,9 @@
 		sdhc2 = &sdhc_2; /* SDC2 SD card slot */
 	};
 
-	chosen { };
+	chosen {
+		ranges;
+	};
 
 	memory {
 		device_type = "memory";
Signature · 1 line
2.13.0
author
#1 lore raw
Quoted 14 lines · Rob Clark

Some LK's can populate chosen with a simple-framebuffer node to hand over bootloader display to kernel (or u-boot/etc). But kernel fails to grok it properly without knowing address/size size.

---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/msm8916.dtsi +0 -0
index 56549063396f..5c36a0934989 100644

arch/arm64/boot/dts/qcom/msm8916.dtsi line 34

Quoted 6 lines
arch/arm64/boot/dts/qcom/msm8916.dtsi +2 -1
@@ -30,7 +30,9 @@
                sdhc2 = &sdhc_2; /* SDC2 SD card slot */
        };
 
-       chosen { };
+       chosen {
+               ranges;

just chatting about this on IRC.. and I think we should also have

  #address-cells = <1>;
  #size-cells = <1>;

too.. since display controller (unless you take iommu out of bypass.. which isn't going to happen in bootloader or early kernel) can only address lower 32b of address space..

BR,
-R

Quoted 7 lines
arch/arm64/boot/dts/qcom/msm8916.dtsi +1 -1
+       };
 
        memory {
                device_type = "memory";
--

2.13.0