Skip to contentSkip to conversation

ARM: dts: imx: add CX9020 Embedded PC device tree

PATCH Superseded [email protected] 6 participants 20 messages Jul 12, 2017 – Jul 25, 2017

Subsystems (6)
Device tree bindings DRM drivers DRM misc Arm i.MX and Layerscape +2 more subsystems

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 ARM: dts: imx: add CX9020 Embedded PC device tree

From: Patrick Br?nn <[email protected]>

The CX9020 differs from i.MX53 Quick Start Board by:
- use uart2 instead of uart1
- DVI-D connector instead of VGA
- no audio
- CCAT FPGA connected to emi
- enable rtc

Signed-off-by Patrick Br?nn <[email protected]>
---
 arch/arm/boot/dts/Makefile         |   1 +
 arch/arm/boot/dts/imx53-cx9020.dts | 377 +++++++++++++++++++++++++++++++++++++
 2 files changed, 378 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx53-cx9020.dts
arch/arm/boot/dts/Makefile +1 -0
index 9c5e1d944d1c..ea60698f9783 100644
@@ -340,6 +340,7 @@ dtb-$(CONFIG_SOC_IMX53) += \
 	imx53-ard.dtb \
 	imx53-m53evk.dtb \
 	imx53-mba53.dtb \
+	imx53-cx9020.dtb \
 	imx53-qsb.dtb \
 	imx53-qsrb.dtb \
 	imx53-smd.dtb \
arch/arm/boot/dts/imx53-cx9020.dts new file +377 -0

377 lines not on this page · raw message

Signature · 1 line
2.11.0
#1 lore raw

Hi,

Quoted 4 lines · linux-kernel-dev at beckhoff.com
arch/arm/boot/dts/imx53-cx9020.dts new file +4 -0
+/dts-v1/;
+#include "imx53.dtsi"
+
+#define MX53_PAD_EIM_D26__UART2_RXD_MUX    0x144 0x48c 0x880 0x2 0x0

arch/arm/boot/dts/imx53-cx9020.dts line 26

Quoted 10 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +10 -0
+#define MX53_PAD_EIM_D27__UART2_TXD_MUX    0x148 0x490 0x000 0x2 0x0
+#define MX53_PAD_EIM_D28__UART2_RTS        0x14c 0x494 0x87c 0x2 0x0
+#define MX53_PAD_EIM_D29__UART2_CTS        0x150 0x498 0x000 0x2 0x0
+
+/ {
+	model = "Freescale i.MX53 based Beckhoff CX9020";
+	compatible = "fsl,imx53-qsb", "fsl,imx53";
+
+	chosen {
+		stdout-path = &uart2;

No baud-rate or bits configuration?

arch/arm/boot/dts/imx53-cx9020.dts line 38

Quoted 12 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +12 -0
+	};
+
+	memory {
+		reg = <0x70000000 0x20000000>,
+		      <0xb0000000 0x20000000>;
+	};
+
+	ccat {
+		compatible = "bhf,emi-ccat";
+	};
+
+	display0: display at di0 {

This unit-address (the bit after the @) isn't valid, as that should match a reg or ranges, but this node has neither.

Just call this display-0.

Quoted 14 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +14 -0
+		#address-cells =<1>;
+		#size-cells = <0>;
+		compatible = "fsl,imx-parallel-display";
+		interface-pix-fmt = "rgb24";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_ipu_disp0>;
+		status = "okay";
+
+		port at 0 {
+			reg = <0>;
+			display0_in: endpoint {
+				remote-endpoint = <&ipu_di0_disp0>;
+			};
+		};

arch/arm/boot/dts/imx53-cx9020.dts line 62

Quoted 10 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +10 -0
+
+		port at 1 {
+			reg = <1>;
+			display0_out: endpoint {
+				remote-endpoint = <&panel_in>;
+			};
+		};
+	};
+
+	dvi_panel: display at 0 {

Likewise you have no reg here, so the unit address isn't valid.

Surely panel-0?

arch/arm/boot/dts/imx53-cx9020.dts line 65

Quoted 3 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +3 -0
+		#address-cells =<1>;
+		#size-cells = <0>;
+		compatible = "simple,ddc-only";

I don't see that compatible string in my Linux tree, and it doesn't make sense to me -- "simple" isn't a vendor-prefix.

Where has this come from?

Quoted 8 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +8 -0
+		ddc-i2c-bus = <&i2c2>;
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&display0_out>;
+			};
+		};
+	};

[...]

arch/arm/boot/dts/imx53-cx9020.dts line 107

Quoted 8 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +8 -0
+	regulators {
+		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		reg_3p2v: regulator at 0 {
+			compatible = "regulator-fixed";
+			reg = <0>;

Meaningless reg entry.

arch/arm/boot/dts/imx53-cx9020.dts line 116

Quoted 9 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +9 -0
+			regulator-name = "3P2V";
+			regulator-min-microvolt = <3200000>;
+			regulator-max-microvolt = <3200000>;
+			regulator-always-on;
+		};
+
+		reg_usb_vbus: regulator at 1 {
+			compatible = "regulator-fixed";
+			reg = <1>;

Likewise.

arch/arm/boot/dts/imx53-cx9020.dts line 123

Quoted 7 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +7 -0
+			regulator-name = "usb_vbus";
+			regulator-min-microvolt = <5000000>;
+			regulator-max-microvolt = <5000000>;
+			gpio = <&gpio7 8 0>;
+			enable-active-high;
+		};
+	};

There's no need for a simple-bus here. It doesn't represent HW, and you can nothing. You can put these directly under the root node, without a synthetic reg or unnecessary container:

	reg_3p2v: regulator-3p2v {
		compatible = "regulator-fixed";
		regulator-name = "3P2V";
		regulator-min-microvolt = <3200000>;
		regulator-max-microvolt = <3200000>;
		regulator-always-on;
	};

	reg_usb_vbus: regulator-usb-vbus {
		compatible = "regulator-fixed";
		regulator-name = "usb_vbus";
		regulator-min-microvolt = <5000000>;
		regulator-max-microvolt = <5000000>;
		gpio = <&gpio7 8 0>;
		enable-active-high;
	}

Otherwise, looks fine to me.

Thanks,
Mark.

#2 lore raw

Hi Mark,
Thanks, for the fast feedback.

Quoted 10 lines

From: Mark Rutland [mailto:mark.rutland at arm.com]
Sent: Mittwoch, 12. Juli 2017 11:47

arch/arm/boot/dts/imx53-cx9020.dts line 26

Quoted 6 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +6 -0
+/ {
+    model = "Freescale i.MX53 based Beckhoff CX9020";
+    compatible = "fsl,imx53-qsb", "fsl,imx53";
+
+    chosen {
+            stdout-path = &uart2;

No baud-rate or bits configuration?

The default config from imx53.dtsi works fine for us.

Quoted 11 lines

arch/arm/boot/dts/imx53-cx9020.dts line 38

Quoted 5 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +5 -0
+    ccat {
+            compatible = "bhf,emi-ccat";
+    };
+
+    display0: display at di0 {

This unit-address (the bit after the @) isn't valid, as that should match a reg or ranges, but this node has neither.

Just call this display-0.

Okay, I will fix this

Quoted 27 lines
Quoted 14 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +14 -0
+            #address-cells =<1>;
+            #size-cells = <0>;
+            compatible = "fsl,imx-parallel-display";
+            interface-pix-fmt = "rgb24";
+            pinctrl-names = "default";
+            pinctrl-0 = <&pinctrl_ipu_disp0>;
+            status = "okay";
+
+            port at 0 {
+                    reg = <0>;
+                    display0_in: endpoint {
+                            remote-endpoint = <&ipu_di0_disp0>;
+                    };
+            };

arch/arm/boot/dts/imx53-cx9020.dts line 62

Quoted 10 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +10 -0
+
+            port at 1 {
+                    reg = <1>;
+                    display0_out: endpoint {
+                            remote-endpoint = <&panel_in>;
+                    };
+            };
+    };
+
+    dvi_panel: display at 0 {

Likewise you have no reg here, so the unit address isn't valid.

Quoted 2 lines

Surely panel-0?

Okay, I will have a closer look, too.

Quoted 9 lines

arch/arm/boot/dts/imx53-cx9020.dts line 65

Quoted 3 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +3 -0
+            #address-cells =<1>;
+            #size-cells = <0>;
+            compatible = "simple,ddc-only";

I don't see that compatible string in my Linux tree, and it doesn't make sense to me -- "simple" isn't a vendor-prefix.

Where has this come from?

Out-of-tree, sorry. Our device has a DVI connector bound to the imx parallel interface. So my idea was to reuse the panel-simple driver and add a very simple panel with only ddc options. Unfortunately, I was too shy to post that upstream[1].
Is there a more elegant solution? Or should I remove all display related nodes from imx53-cx9020.dts?

Quoted 20 lines
Quoted 8 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +8 -0
+            ddc-i2c-bus = <&i2c2>;
+
+            port {
+                    panel_in: endpoint {
+                            remote-endpoint = <&display0_out>;
+                    };
+            };
+    };

[...]

arch/arm/boot/dts/imx53-cx9020.dts line 107

Quoted 8 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +8 -0
+    regulators {
+            compatible = "simple-bus";
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            reg_3p2v: regulator at 0 {
+                    compatible = "regulator-fixed";
+                    reg = <0>;
Quoted 2 lines

Meaningless reg entry.

Okay, I will remove this.

Quoted 10 lines

arch/arm/boot/dts/imx53-cx9020.dts line 116

Quoted 9 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +9 -0
+                    regulator-name = "3P2V";
+                    regulator-min-microvolt = <3200000>;
+                    regulator-max-microvolt = <3200000>;
+                    regulator-always-on;
+            };
+
+            reg_usb_vbus: regulator at 1 {
+                    compatible = "regulator-fixed";
+                    reg = <1>;
Quoted 2 lines

Likewise.

this, too.

Quoted 12 lines

arch/arm/boot/dts/imx53-cx9020.dts line 123

Quoted 7 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +7 -0
+                    regulator-name = "usb_vbus";
+                    regulator-min-microvolt = <5000000>;
+                    regulator-max-microvolt = <5000000>;
+                    gpio = <&gpio7 8 0>;
+                    enable-active-high;
+            };
+    };

There's no need for a simple-bus here. It doesn't represent HW, and you can nothing. You can put these directly under the root node, without a synthetic reg or unnecessary container:

Quoted 17 lines
      reg_3p2v: regulator-3p2v {
              compatible = "regulator-fixed";
              regulator-name = "3P2V";
              regulator-min-microvolt = <3200000>;
              regulator-max-microvolt = <3200000>;
              regulator-always-on;
      };

      reg_usb_vbus: regulator-usb-vbus {
              compatible = "regulator-fixed";
              regulator-name = "usb_vbus";
              regulator-min-microvolt = <5000000>;
              regulator-max-microvolt = <5000000>;
              gpio = <&gpio7 8 0>;
              enable-active-high;
      }

Thanks, I will send a v2 with your simplified version. As soon as I get the display/ panel thing right.

Quoted 4 lines

Otherwise, looks fine to me.

Thanks,
Mark.

[1] https://github.com/Beckhoff/CX9020/blob/master/kernel-patches/0003-drm-panel-simple-Add-support-for-ddc-only-panel.patch
Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff
Registered office: Verl, Germany | Register court: Guetersloh HRA 7075

#3 lore raw
In reply to [email protected]
Quoted 21 lines · linux-kernel-dev at beckhoff.com

From: Patrick Br?nn <[email protected]>

The CX9020 differs from i.MX53 Quick Start Board by:
- use uart2 instead of uart1
- DVI-D connector instead of VGA
- no audio
- CCAT FPGA connected to emi
- enable rtc

Signed-off-by Patrick Br?nn <[email protected]>
---
 arch/arm/boot/dts/Makefile         |   1 +
 arch/arm/boot/dts/imx53-cx9020.dts | 377 +++++++++++++++++++++++++++++++++++++
 2 files changed, 378 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx53-cx9020.dts
arch/arm/boot/dts/Makefile +0 -0
index 9c5e1d944d1c..ea60698f9783 100644

arch/arm/boot/dts/Makefile dtb-$(CONFIG_SOC_IMX53) += \ · line 346

Quoted 7 lines
arch/arm/boot/dts/Makefile +1 -0
@@ -340,6 +340,7 @@ dtb-$(CONFIG_SOC_IMX53) += \
 	imx53-ard.dtb \
 	imx53-m53evk.dtb \
 	imx53-mba53.dtb \
+	imx53-cx9020.dtb \
 	imx53-qsb.dtb \
 	imx53-qsrb.dtb \
 	imx53-smd.dtb \

Hi Patrick

It appears this list is in alphabetic order...

Andrew

#4 lore raw
Quoted 37 lines

From: Andrew Lunn [mailto:andrew at lunn.ch]
Sent: Mittwoch, 12. Juli 2017 16:43

Quoted 9 lines · linux-kernel-dev at beckhoff.com

From: Patrick Br?nn <[email protected]>

The CX9020 differs from i.MX53 Quick Start Board by:
- use uart2 instead of uart1
- DVI-D connector instead of VGA
- no audio
- CCAT FPGA connected to emi
- enable rtc

Quoted 4 lines
Signed-off-by Patrick Br?nn <[email protected]>
---
 arch/arm/boot/dts/Makefile         |   1 +
 arch/arm/boot/dts/imx53-cx9020.dts | 377

+++++++++++++++++++++++++++++++++++++

Quoted 8 lines
 2 files changed, 378 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx53-cx9020.dts
arch/arm/boot/dts/Makefile +0 -0
index 9c5e1d944d1c..ea60698f9783 100644

arch/arm/boot/dts/Makefile dtb-$(CONFIG_SOC_IMX53) += \ · line 346

Quoted 7 lines
arch/arm/boot/dts/Makefile +1 -0
@@ -340,6 +340,7 @@ dtb-$(CONFIG_SOC_IMX53) += \
     imx53-ard.dtb \
     imx53-m53evk.dtb \
     imx53-mba53.dtb \
+    imx53-cx9020.dtb \
     imx53-qsb.dtb \
     imx53-qsrb.dtb \
     imx53-smd.dtb \

Hi Patrick

Quoted 2 lines

It appears this list is in alphabetic order...

Ops, thanks for the hint, will fix this with the next version. Patrick

Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075

author
#5 lore raw

v2 cover Add CX9020 device tree

In reply to [email protected]

From: Patrick Bruenn <[email protected]>

Add device tree for Beckhoff CX9020 Embedded PC.

The CX9020 differs from i.MX53 Quick Start Board by:
- use uart2 instead of uart1
- DVI-D connector instead of VGA
- no audio
- CCAT FPGA connected to emi
- enable rtc

Patrick Bruenn (2):
ARM: dts: imx: add CX9020 Embedded PC device tree drm/panel: simple: Add support for ddc-only panel

 arch/arm/boot/dts/Makefile           |   1 +
 arch/arm/boot/dts/imx53-cx9020.dts   | 370 +++++++++++++++++++++++++++++++++++
 drivers/gpu/drm/panel/panel-simple.c |   6 +
 3 files changed, 377 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx53-cx9020.dts
Signature · 1 line
2.11.0
author
#6 lore raw

PATCH v2 1/2 ARM: dts: imx: add CX9020 Embedded PC device tree

From: Patrick Bruenn <[email protected]>

The CX9020 differs from i.MX53 Quick Start Board by:
- use uart2 instead of uart1
- DVI-D connector instead of VGA
- no audio
- CCAT FPGA connected to emi
- enable rtc

Signed-off-by Patrick Bruenn <[email protected]>
---
 arch/arm/boot/dts/Makefile         |   1 +
 arch/arm/boot/dts/imx53-cx9020.dts | 370 +++++++++++++++++++++++++++++++++++++
 2 files changed, 371 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx53-cx9020.dts
arch/arm/boot/dts/Makefile +1 -0
index 9c5e1d944d1c..590cdb77d972 100644
@@ -338,6 +338,7 @@ dtb-$(CONFIG_SOC_IMX51) += \
 	imx51-ts4800.dtb
 dtb-$(CONFIG_SOC_IMX53) += \
 	imx53-ard.dtb \
+	imx53-cx9020.dtb \
 	imx53-m53evk.dtb \
 	imx53-mba53.dtb \
 	imx53-qsb.dtb \
arch/arm/boot/dts/imx53-cx9020.dts new file +370 -0

370 lines not on this page · raw message

Signature · 1 line
2.11.0
author
#7 lore raw

PATCH v2 2/2 drm/panel: simple: Add support for ddc-only panel

In reply to [email protected]

From: Patrick Bruenn <[email protected]>

This is a fix for the CX9020 Embedded PC. On that device the 24-bit parallel-display signal of the imx53 is combined with an I2C channel and converted to DVI-D port. Devicetree magic always requires a panel connected to the parallel-display port.
We add an empty panel_desc, to get recognized by the panel-simple driver, which can then use the ddc bus to read the panels configuration.

Signed-off-by Patrick Bruenn <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +6 -0
index c4566ce8fda7..52b2a7fb59ed 100644
@@ -1856,6 +1856,9 @@ static const struct panel_desc winstar_wf35ltiacd = {
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
 
+static const struct panel_desc simple_ddc_only = {
+};
+
 static const struct of_device_id platform_of_match[] = {
 	{
 		.compatible = "ampire,am-480272h3tmqw-t01h",

@@ -2050,6 +2053,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "winstar,wf35ltiacd",
 		.data = &winstar_wf35ltiacd,
 	}, {
+		.compatible = "simple,ddc-only",
+		.data = &simple_ddc_only,
+	}, {
 		/* sentinel */
 	}
 };
Signature · 1 line
2.11.0
author
#9 lore raw

v3 cover Add CX9020 device tree

In reply to [email protected]

From: Patrick Bruenn <p.bruenn-QonKdJ6Bx35Wk0Htik3J/[email protected]>

Add device tree for Beckhoff CX9020 Embedded PC.

The CX9020 differs from i.MX53 Quick Start Board by:
- use uart2 instead of uart1
- DVI-D connector instead of VGA
- no audio
- CCAT FPGA connected to emi
- enable rtc

v3: add missing changelog, sorry about the noise v2:
- include simple ddc-only panel patch
- keep alphabetic order of dts/Makefile
- configure uart2 with 'fsl,dte-mode'
- use display-0 and panel-0 as node names
- remove unnecessary "simple-bus" for fixed regulators

Patrick Bruenn (2):
ARM: dts: imx: add CX9020 Embedded PC device tree drm/panel: simple: Add support for ddc-only panel

 arch/arm/boot/dts/Makefile           |   1 +
 arch/arm/boot/dts/imx53-cx9020.dts   | 370 +++++++++++++++++++++++++++++++++++
 drivers/gpu/drm/panel/panel-simple.c |   6 +
 3 files changed, 377 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx53-cx9020.dts
Signature · 7 lines
2.11.0


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author
#10 lore raw

PATCH v3 1/2 ARM: dts: imx: add CX9020 Embedded PC device tree

From: Patrick Bruenn <[email protected]>

The CX9020 differs from i.MX53 Quick Start Board by:
- use uart2 instead of uart1
- DVI-D connector instead of VGA
- no audio
- CCAT FPGA connected to emi
- enable rtc

Signed-off-by Patrick Bruenn <[email protected]>

---
Cc: Andrew Lunn <[email protected]>

v3: add missig changelog
v2:
- keep alphabetic order of dts/Makefile
- configure uart2 with 'fsl,dte-mode'
- use display-0 and panel-0 as node names
- remove unnecessary "simple-bus" for fixed regulators

---
 arch/arm/boot/dts/Makefile         |   1 +
 arch/arm/boot/dts/imx53-cx9020.dts | 370 +++++++++++++++++++++++++++++++++++++
 2 files changed, 371 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx53-cx9020.dts
arch/arm/boot/dts/Makefile +1 -0
index 9c5e1d944d1c..590cdb77d972 100644
@@ -338,6 +338,7 @@ dtb-$(CONFIG_SOC_IMX51) += \
 	imx51-ts4800.dtb
 dtb-$(CONFIG_SOC_IMX53) += \
 	imx53-ard.dtb \
+	imx53-cx9020.dtb \
 	imx53-m53evk.dtb \
 	imx53-mba53.dtb \
 	imx53-qsb.dtb \
arch/arm/boot/dts/imx53-cx9020.dts new file +370 -0

370 lines not on this page · raw message

Signature · 1 line
2.11.0
author
#12 lore raw

PATCH v3 2/2 drm/panel: simple: Add support for ddc-only panel

In reply to [email protected]

From: Patrick Bruenn <[email protected]>

This is a fix for the CX9020 Embedded PC. On that device the 24-bit parallel-display signal of the imx53 is combined with an I2C channel and converted to DVI-D port. Devicetree magic always requires a panel connected to the parallel-display port.
We add an empty panel_desc, to get recognized by the panel-simple driver, which can then use the ddc bus to read the panels configuration.

Signed-off-by Patrick Bruenn <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +6 -0
index c4566ce8fda7..52b2a7fb59ed 100644
@@ -1856,6 +1856,9 @@ static const struct panel_desc winstar_wf35ltiacd = {
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
 
+static const struct panel_desc simple_ddc_only = {
+};
+
 static const struct of_device_id platform_of_match[] = {
 	{
 		.compatible = "ampire,am-480272h3tmqw-t01h",

@@ -2050,6 +2053,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "winstar,wf35ltiacd",
 		.data = &winstar_wf35ltiacd,
 	}, {
+		.compatible = "simple,ddc-only",
+		.data = &simple_ddc_only,
+	}, {
 		/* sentinel */
 	}
 };
Signature · 1 line
2.11.0
#11 lore raw
In reply to [email protected]
Quoted 53 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

The CX9020 differs from i.MX53 Quick Start Board by:
- use uart2 instead of uart1
- DVI-D connector instead of VGA
- no audio
- CCAT FPGA connected to emi
- enable rtc

Signed-off-by Patrick Bruenn <[email protected]>

---
Cc: Andrew Lunn <[email protected]>

v3: add missig changelog
v2:
- keep alphabetic order of dts/Makefile
- configure uart2 with 'fsl,dte-mode'
- use display-0 and panel-0 as node names
- remove unnecessary "simple-bus" for fixed regulators

---
 arch/arm/boot/dts/Makefile         |   1 +
 arch/arm/boot/dts/imx53-cx9020.dts | 370 +++++++++++++++++++++++++++++++++++++
 2 files changed, 371 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx53-cx9020.dts
arch/arm/boot/dts/Makefile +1 -0
index 9c5e1d944d1c..590cdb77d972 100644
@@ -338,6 +338,7 @@ dtb-$(CONFIG_SOC_IMX51) += \
 	imx51-ts4800.dtb
 dtb-$(CONFIG_SOC_IMX53) += \
 	imx53-ard.dtb \
+	imx53-cx9020.dtb \
 	imx53-m53evk.dtb \
 	imx53-mba53.dtb \
 	imx53-qsb.dtb \
arch/arm/boot/dts/imx53-cx9020.dts new file +9 -0
new file mode 100644
index 000000000000..0c3de61a5f4f
@@ -0,0 +1,370 @@
+/*
+ * Copyright 2011 Freescale Semiconductor, Inc.
+ * Copyright 2011 Linaro Ltd.
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html

arch/arm/boot/dts/imx53-cx9020.dts line 19

Quoted 10 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +10 -0
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+#include "imx53.dtsi"
+
+#define MX53_PAD_EIM_D26__UART2_RXD_MUX    0x144 0x48c 0x880 0x2 0x0
+#define MX53_PAD_EIM_D27__UART2_TXD_MUX    0x148 0x490 0x000 0x2 0x0
+#define MX53_PAD_EIM_D28__UART2_RTS        0x14c 0x494 0x87c 0x2 0x0
+#define MX53_PAD_EIM_D29__UART2_CTS        0x150 0x498 0x000 0x2 0x0

Why cannot these be defined in imx53-pinfunc.h?

arch/arm/boot/dts/imx53-cx9020.dts line 22

Quoted 3 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +3 -0
+
+/ {
+	model = "Freescale i.MX53 based Beckhoff CX9020";

This isn't a board manufactured by Freescale, right?

arch/arm/boot/dts/imx53-cx9020.dts line 23

Quoted 1 line
arch/arm/boot/dts/imx53-cx9020.dts new file +1 -0
+	compatible = "fsl,imx53-qsb", "fsl,imx53";

Don't you need a compatible for Beckhoff CX9020 rather than using fsl,imx53-qsb?

arch/arm/boot/dts/imx53-cx9020.dts line 35

Quoted 12 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +12 -0
+
+	chosen {
+		stdout-path = &uart2;
+	};
+
+	memory {
+		reg = <0x70000000 0x20000000>,
+		      <0xb0000000 0x20000000>;
+	};
+
+	ccat {
+		compatible = "bhf,emi-ccat";

Undocumented bindings?

arch/arm/boot/dts/imx53-cx9020.dts line 48

Quoted 13 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +13 -0
+	};
+
+	display-0 {
+		#address-cells =<1>;
+		#size-cells = <0>;
+		compatible = "fsl,imx-parallel-display";
+		interface-pix-fmt = "rgb24";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_ipu_disp0>;
+		status = "okay";
+
+		port at 0 {
+			reg = <0>;

Please a newline between property list and child node.

Quoted 7 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +7 -0
+			display0_in: endpoint {
+				remote-endpoint = <&ipu_di0_disp0>;
+			};
+		};
+
+		port at 1 {
+			reg = <1>;

arch/arm/boot/dts/imx53-cx9020.dts line 65

Quoted 10 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +10 -0
+			display0_out: endpoint {
+				remote-endpoint = <&panel_in>;
+			};
+		};
+	};
+
+	panel-0 {
+		#address-cells =<1>;
+		#size-cells = <0>;
+		compatible = "simple,ddc-only";

Send me the dts change only after the bindings and driver parts land on mainline.

arch/arm/boot/dts/imx53-cx9020.dts line 76

Quoted 11 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +11 -0
+		ddc-i2c-bus = <&i2c2>;
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&display0_out>;
+			};
+		};
+	};
+
+	leds {
+		compatible = "gpio-leds";

newline

arch/arm/boot/dts/imx53-cx9020.dts line 77

Quoted 1 line
arch/arm/boot/dts/imx53-cx9020.dts new file +1 -0
+		pwr_r {

We prefer to use hyphen than underscore in node name.

arch/arm/boot/dts/imx53-cx9020.dts line 78

Quoted 1 line
arch/arm/boot/dts/imx53-cx9020.dts new file +1 -0
+			gpios = <&gpio3 22 0>;

Use the polarity defines in include/dt-bindings/gpio/gpio.h.

arch/arm/boot/dts/imx53-cx9020.dts line 80

Quoted 2 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +2 -0
+			default-state = "off";
+		};

Please have a newline between child nodes.

Quoted 8 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +8 -0
+		pwr_g {
+			gpios = <&gpio3 24 0>;
+			default-state = "on";
+		};
+		pwr_b {
+			gpios = <&gpio3 23 0>;
+			default-state = "off";
+		};

arch/arm/boot/dts/imx53-cx9020.dts line 98

Quoted 10 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +10 -0
+	};
+
+	rtc: rtc at 53fa4000 {
+		compatible = "fsl,imx53-rtc", "fsl,imx25-rtc";
+		reg = <0x53fa4000 0x4000>;
+		interrupts = <24>;
+		interrupt-parent = <&tzic>;
+		clocks = <&clks IMX5_CLK_SRTC_GATE>;
+		clock-names = "ipg";
+	};

It should be added to imx53.dtsi.

arch/arm/boot/dts/imx53-cx9020.dts line 100

Quoted 2 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +2 -0
+
+	reg_3p2v: regulator at 0 {

name at unit-address only applies to device nodes under bus with 'reg' property. You should go regulator-3p2v in your case.

Quoted 32 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +32 -0
+		compatible = "regulator-fixed";
+		regulator-name = "3P2V";
+		regulator-min-microvolt = <3200000>;
+		regulator-max-microvolt = <3200000>;
+		regulator-always-on;
+	};
+
+	reg_usb_vbus: regulator at 1 {
+		compatible = "regulator-fixed";
+		regulator-name = "usb_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		gpio = <&gpio7 8 0>;
+		enable-active-high;
+	};
+};
+
+&esdhc1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_esdhc1>;
+	cd-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;
+	bus-width = <4>;
+	status = "okay";
+};
+
+&esdhc2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_esdhc2>;
+	cd-gpios = <&gpio1 4 GPIO_ACTIVE_LOW>;
+	bus-width = <4>;
+	status = "okay";
+};

arch/arm/boot/dts/imx53-cx9020.dts line 142

Quoted 10 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +10 -0
+
+&ipu_di0_disp0 {
+	remote-endpoint = <&display0_in>;
+};
+
+&ssi2 {
+	status = "okay";
+};
+
+&iomuxc {

We generally sort these labelled nodes alphabetically. Considering iomuxc usually contains a lot of pinctrl data which might impact the readability of the file, it can be put at the bottom of the file.

arch/arm/boot/dts/imx53-cx9020.dts line 146

Quoted 4 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +4 -0
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog>;
+
+	imx53-qsb {

This container node can be dropped to save one level of indent.

arch/arm/boot/dts/imx53-cx9020.dts line 149

Quoted 3 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +3 -0
+		pinctrl_hog: hoggrp {
+			fsl,pins = <
+				MX53_PAD_GPIO_0__CCM_SSI_EXT1_CLK 0x80000000

Please use a proper configuration value rather than relying on the value coming out of reset or firmware setup.

arch/arm/boot/dts/imx53-cx9020.dts line 158

Quoted 9 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +9 -0
+				MX53_PAD_GPIO_8__GPIO1_8          0x80000000
+				MX53_PAD_PATA_DATA14__GPIO2_14    0x80000000
+				MX53_PAD_PATA_DATA15__GPIO2_15    0x80000000
+				MX53_PAD_GPIO_1__GPIO1_1          0x80000000
+				MX53_PAD_GPIO_4__GPIO1_4          0x80000000
+				MX53_PAD_PATA_DA_0__GPIO7_6       0x80000000
+				MX53_PAD_PATA_DA_2__GPIO7_8	  0x80000000
+				MX53_PAD_GPIO_16__GPIO7_11        0x80000000
+

Drop this newline.

Quoted 42 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +42 -0
+				MX53_PAD_EIM_OE__EMI_WEIM_OE            0x80000000
+				MX53_PAD_EIM_WAIT__EMI_WEIM_WAIT        0x80000000
+				MX53_PAD_EIM_LBA__EMI_WEIM_LBA          0x80000000
+				MX53_PAD_EIM_RW__EMI_WEIM_RW            0x80000000
+				MX53_PAD_EIM_EB0__EMI_WEIM_EB_0         0x80000000
+				MX53_PAD_EIM_EB1__EMI_WEIM_EB_1         0x80000000
+				MX53_PAD_EIM_EB2__EMI_WEIM_EB_2         0x80000000
+				MX53_PAD_EIM_EB3__EMI_WEIM_EB_3         0x80000000
+				MX53_PAD_EIM_CS0__EMI_WEIM_CS_0         0x80000000
+				MX53_PAD_EIM_CS1__EMI_WEIM_CS_1         0x80000000
+				MX53_PAD_EIM_A16__EMI_WEIM_A_16         0x80000000
+				MX53_PAD_EIM_A17__EMI_WEIM_A_17         0x80000000
+				MX53_PAD_EIM_A18__EMI_WEIM_A_18         0x80000000
+				MX53_PAD_EIM_A19__EMI_WEIM_A_19         0x80000000
+				MX53_PAD_EIM_A20__EMI_WEIM_A_20         0x80000000
+				MX53_PAD_EIM_A21__EMI_WEIM_A_21         0x80000000
+				MX53_PAD_EIM_A22__EMI_WEIM_A_22         0x80000000
+				MX53_PAD_EIM_DA0__EMI_NAND_WEIM_DA_0    0xa4
+				MX53_PAD_EIM_DA1__EMI_NAND_WEIM_DA_1    0xa4
+				MX53_PAD_EIM_DA2__EMI_NAND_WEIM_DA_2    0xa4
+				MX53_PAD_EIM_DA3__EMI_NAND_WEIM_DA_3    0xa4
+				MX53_PAD_EIM_DA4__EMI_NAND_WEIM_DA_4    0xa4
+				MX53_PAD_EIM_DA5__EMI_NAND_WEIM_DA_5    0xa4
+				MX53_PAD_EIM_DA6__EMI_NAND_WEIM_DA_6    0xa4
+				MX53_PAD_EIM_DA7__EMI_NAND_WEIM_DA_7    0xa4
+				MX53_PAD_EIM_DA8__EMI_NAND_WEIM_DA_8    0xa4
+				MX53_PAD_EIM_DA9__EMI_NAND_WEIM_DA_9    0xa4
+				MX53_PAD_EIM_DA10__EMI_NAND_WEIM_DA_10	0xa4
+				MX53_PAD_EIM_DA11__EMI_NAND_WEIM_DA_11  0xa4
+				MX53_PAD_EIM_DA12__EMI_NAND_WEIM_DA_12  0xa4
+				MX53_PAD_EIM_DA13__EMI_NAND_WEIM_DA_13  0xa4
+				MX53_PAD_EIM_DA14__EMI_NAND_WEIM_DA_14  0xa4
+				MX53_PAD_EIM_DA15__EMI_NAND_WEIM_DA_15  0xa4
+				MX53_PAD_PATA_DATA0__EMI_NANDF_D_0      0xa4
+				MX53_PAD_PATA_DATA1__EMI_NANDF_D_1      0xa4
+				MX53_PAD_PATA_DATA2__EMI_NANDF_D_2      0xa4
+				MX53_PAD_PATA_DATA3__EMI_NANDF_D_3      0xa4
+				MX53_PAD_PATA_DATA4__EMI_NANDF_D_4      0xa4
+				MX53_PAD_PATA_DATA5__EMI_NANDF_D_5      0xa4
+				MX53_PAD_PATA_DATA6__EMI_NANDF_D_6      0xa4
+				MX53_PAD_PATA_DATA7__EMI_NANDF_D_7      0xa4
+				MX53_PAD_PATA_DATA8__EMI_NANDF_D_8      0xa4

arch/arm/boot/dts/imx53-cx9020.dts line 210

Quoted 10 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +10 -0
+				MX53_PAD_PATA_DATA9__EMI_NANDF_D_9      0xa4
+				MX53_PAD_PATA_DATA10__EMI_NANDF_D_10    0xa4
+				MX53_PAD_PATA_DATA11__EMI_NANDF_D_11    0xa4
+				MX53_PAD_PATA_DATA12__EMI_NANDF_D_12    0xa4
+				MX53_PAD_PATA_DATA13__EMI_NANDF_D_13    0xa4
+				MX53_PAD_PATA_DATA14__EMI_NANDF_D_14    0xa4
+				MX53_PAD_PATA_DATA15__EMI_NANDF_D_15    0xa4
+				MX53_PAD_NANDF_CLE__GPIO6_7             0x00000001
+				MX53_PAD_NANDF_WP_B__GPIO6_9            0x00000001
+				MX53_PAD_NANDF_ALE__GPIO6_8             0x00000001

Do you really need so many pin setups in hog group? The hog group is only for those pins that do not have a clear client device.

arch/arm/boot/dts/imx53-cx9020.dts line 214

Quoted 4 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +4 -0
+			>;
+		};
+
+		led_pin_gpio3_23: led_gpio3_23 at 0 {

How is this being used?

Quoted 146 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +146 -0
+			fsl,pins = <
+				MX53_PAD_EIM_D23__GPIO3_23 0x80000000
+			>;
+		};
+
+		pinctrl_audmux: audmuxgrp {
+			fsl,pins = <
+				MX53_PAD_KEY_COL0__AUDMUX_AUD5_TXC	0x80000000
+				MX53_PAD_KEY_ROW0__AUDMUX_AUD5_TXD	0x80000000
+				MX53_PAD_KEY_COL1__AUDMUX_AUD5_TXFS	0x80000000
+				MX53_PAD_KEY_ROW1__AUDMUX_AUD5_RXD	0x80000000
+			>;
+		};
+
+		pinctrl_esdhc1: esdhc1grp {
+			fsl,pins = <
+				MX53_PAD_SD1_DATA0__ESDHC1_DAT0		0x1d5
+				MX53_PAD_SD1_DATA1__ESDHC1_DAT1		0x1d5
+				MX53_PAD_SD1_DATA2__ESDHC1_DAT2		0x1d5
+				MX53_PAD_SD1_DATA3__ESDHC1_DAT3		0x1d5
+				MX53_PAD_SD1_CMD__ESDHC1_CMD		0x1d5
+				MX53_PAD_SD1_CLK__ESDHC1_CLK		0x1d5
+			>;
+		};
+
+		pinctrl_esdhc2: esdhc2grp {
+			fsl,pins = <
+				MX53_PAD_SD2_DATA0__ESDHC2_DAT0		0x1d5
+				MX53_PAD_SD2_DATA1__ESDHC2_DAT1		0x1d5
+				MX53_PAD_SD2_DATA2__ESDHC2_DAT2		0x1d5
+				MX53_PAD_SD2_DATA3__ESDHC2_DAT3		0x1d5
+				MX53_PAD_SD2_CMD__ESDHC2_CMD		0x1d5
+				MX53_PAD_SD2_CLK__ESDHC2_CLK		0x1d5
+			>;
+		};
+
+		pinctrl_fec: fecgrp {
+			fsl,pins = <
+				MX53_PAD_FEC_MDC__FEC_MDC		0x80000000
+				MX53_PAD_FEC_MDIO__FEC_MDIO		0x80000000
+				MX53_PAD_FEC_REF_CLK__FEC_TX_CLK	0x80000000
+				MX53_PAD_FEC_RX_ER__FEC_RX_ER		0x80000000
+				MX53_PAD_FEC_CRS_DV__FEC_RX_DV		0x80000000
+				MX53_PAD_FEC_RXD1__FEC_RDATA_1		0x80000000
+				MX53_PAD_FEC_RXD0__FEC_RDATA_0		0x80000000
+				MX53_PAD_FEC_TX_EN__FEC_TX_EN		0x80000000
+				MX53_PAD_FEC_TXD1__FEC_TDATA_1		0x80000000
+				MX53_PAD_FEC_TXD0__FEC_TDATA_0		0x80000000
+			>;
+		};
+
+		/* open drain */
+		pinctrl_i2c1: i2c1grp {
+			fsl,pins = <
+				MX53_PAD_CSI0_DAT8__I2C1_SDA		0x400001ec
+				MX53_PAD_CSI0_DAT9__I2C1_SCL		0x400001ec
+			>;
+		};
+
+		pinctrl_i2c2: i2c2grp {
+			fsl,pins = <
+				MX53_PAD_KEY_ROW3__I2C2_SDA             0xc0000000
+				MX53_PAD_KEY_COL3__I2C2_SCL             0xc0000000
+			>;
+		};
+
+		pinctrl_ipu_disp0: ipudisp0grp {
+			fsl,pins = <
+				MX53_PAD_DI0_DISP_CLK__IPU_DI0_DISP_CLK	0x5
+				MX53_PAD_DI0_PIN15__IPU_DI0_PIN15	0x5
+				MX53_PAD_DI0_PIN2__IPU_DI0_PIN2		0x5
+				MX53_PAD_DI0_PIN3__IPU_DI0_PIN3		0x5
+				MX53_PAD_DI0_PIN4__IPU_DI0_PIN4		0x5
+				MX53_PAD_DISP0_DAT0__IPU_DISP0_DAT_0	0x5
+				MX53_PAD_DISP0_DAT1__IPU_DISP0_DAT_1	0x5
+				MX53_PAD_DISP0_DAT2__IPU_DISP0_DAT_2	0x5
+				MX53_PAD_DISP0_DAT3__IPU_DISP0_DAT_3	0x5
+				MX53_PAD_DISP0_DAT4__IPU_DISP0_DAT_4	0x5
+				MX53_PAD_DISP0_DAT5__IPU_DISP0_DAT_5	0x5
+				MX53_PAD_DISP0_DAT6__IPU_DISP0_DAT_6	0x5
+				MX53_PAD_DISP0_DAT7__IPU_DISP0_DAT_7	0x5
+				MX53_PAD_DISP0_DAT8__IPU_DISP0_DAT_8	0x5
+				MX53_PAD_DISP0_DAT9__IPU_DISP0_DAT_9	0x5
+				MX53_PAD_DISP0_DAT10__IPU_DISP0_DAT_10	0x5
+				MX53_PAD_DISP0_DAT11__IPU_DISP0_DAT_11	0x5
+				MX53_PAD_DISP0_DAT12__IPU_DISP0_DAT_12	0x5
+				MX53_PAD_DISP0_DAT13__IPU_DISP0_DAT_13	0x5
+				MX53_PAD_DISP0_DAT14__IPU_DISP0_DAT_14	0x5
+				MX53_PAD_DISP0_DAT15__IPU_DISP0_DAT_15	0x5
+				MX53_PAD_DISP0_DAT16__IPU_DISP0_DAT_16	0x5
+				MX53_PAD_DISP0_DAT17__IPU_DISP0_DAT_17	0x5
+				MX53_PAD_DISP0_DAT18__IPU_DISP0_DAT_18	0x5
+				MX53_PAD_DISP0_DAT19__IPU_DISP0_DAT_19	0x5
+				MX53_PAD_DISP0_DAT20__IPU_DISP0_DAT_20	0x5
+				MX53_PAD_DISP0_DAT21__IPU_DISP0_DAT_21	0x5
+				MX53_PAD_DISP0_DAT22__IPU_DISP0_DAT_22	0x5
+				MX53_PAD_DISP0_DAT23__IPU_DISP0_DAT_23	0x5
+			>;
+		};
+
+		pinctrl_uart2: uart2grp {
+			fsl,pins = <
+				MX53_PAD_EIM_D26__UART2_RXD_MUX	0x1e4
+				MX53_PAD_EIM_D27__UART2_TXD_MUX 0x1e4
+				MX53_PAD_EIM_D28__UART2_RTS 0x1e4
+				MX53_PAD_EIM_D29__UART2_CTS 0x1e4
+			>;
+		};
+	};
+};
+
+&uart2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart2>;
+	fsl,dte-mode;
+	status = "okay";
+};
+
+&i2c2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c2>;
+	status = "okay";
+};
+
+&audmux {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_audmux>;
+	status = "okay";
+};
+
+&fec {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_fec>;
+	phy-mode = "rmii";
+	phy-reset-gpios = <&gpio7 6 0>;
+	status = "okay";
+};
+
+&sata {
+	status = "okay";
+};
+
+&vpu {
+	status = "okay";
+};
+

arch/arm/boot/dts/imx53-cx9020.dts line 370

Quoted 10 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +10 -0
+&usbh1 {
+	vbus-supply = <&reg_usb_vbus>;
+	phy_type = "utmi";
+	status = "okay";
+};
+
+&usbotg {
+	dr_mode = "peripheral";
+	status = "okay";
+};

Sort these labelled nodes alphabetically.

Shawn

maintainer
#8 lore raw

Re: [PATCH v2 2/2] drm/panel: simple: Add support for ddc-only panel

In reply to [email protected]
Quoted 6 lines · On Thu, Jul 13, 2017 at 6:04 AM, <[email protected]> wrote:

From: Patrick Bruenn <[email protected]>

This is a fix for the CX9020 Embedded PC. On that device the 24-bit parallel-display signal of the imx53 is combined with an I2C channel and converted to DVI-D port. Devicetree magic always requires a panel connected to the parallel-display port.

Then fix this. It's not the DT that requires this, but limitations in the i.MX driver.

Quoted 23 lines

We add an empty panel_desc, to get recognized by the panel-simple driver, which can then use the ddc bus to read the panels configuration.

Signed-off-by Patrick Bruenn <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +3 -0
index c4566ce8fda7..52b2a7fb59ed 100644
@@ -1856,6 +1856,9 @@ static const struct panel_desc winstar_wf35ltiacd = {
        .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
 
+static const struct panel_desc simple_ddc_only = {
+};
+
 static const struct of_device_id platform_of_match[] = {
        {
                .compatible = "ampire,am-480272h3tmqw-t01h",

drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id platform_of_match[] = { · line 2056

Quoted 4 lines
drivers/gpu/drm/panel/panel-simple.c +1 -0
@@ -2050,6 +2053,9 @@ static const struct of_device_id platform_of_match[] = {
                .compatible = "winstar,wf35ltiacd",
                .data = &winstar_wf35ltiacd,
        }, {
+               .compatible = "simple,ddc-only",

If you notice the rest of the file, we require compatibles be specific for the panels.

What you want here is a "dvi-connector" node.

Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author
#13 lore raw

v4 cover ARM: dts: imx: add CX9020 Embedded PC device tree

In reply to [email protected]

From: Patrick Bruenn <[email protected]>

The CX9020 differs from i.MX53 Quick Start Board by:
- use uart2 instead of uart1
- DVI-D connector instead of VGA
- no audio
- no SATA connector
- CCAT FPGA connected to emi
- enable rtc

Signed-off-by Patrick Bruenn <[email protected]>

---

v4:
- move alternative UART2 pinmux settings to imx53-pinfunc.h
- fix copyright notice and model name to clearify cx9020 is a Beckhoff board and not from Freescale/NXP/Qualcomm
- add "bhf,cx9020" compatible
- remove ccat node and pin configuration as long as the ccat driver is not mainlined
- use dvi-connector + ti,tfp410 instead of panel-simple
- add newlines between property list and child nodes
- replace underscores in node names with hypens
- replace magic number 0 with polarity defines from include/dt-bindings/gpio/gpio.h
- move rtc node into imx53.dtsi, change it's name into 'srtc', to avoid a conflict with 'rtc' node in imx53-m53.dtsi
- rename regulator-3p2v
- drop imx53-qsb container node
- make iomux configuration explicit
- remove unused audmux
- remove unused led_pin_gpio3_23 configuration
- use blue gpio-leds as disk-activity indicators for mmc0 and mmc1
- add mmc indicator leds to sdhc pingroups
- keep node names in alphabetical order
- remove unused sata and ssi2
- remove unused pin configs from hoggrp
- add entry for Beckhoff related files to MAINTAINERS

v3: add missig changelog
v2:
- keep alphabetic order of dts/Makefile
- configure uart2 with 'fsl,dte-mode'
- use display-0 and panel-0 as node names
- remove unnecessary "simple-bus" for fixed regulators

Cc: Andrew Lunn <[email protected]>
Cc: Rob Herring <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,commit_signer:65/78=83%)
Cc: Mark Rutland <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Cc: Jonathan Cameron <[email protected]> (commit_signer:6/78=8%)
Cc: Kevin Hilman <[email protected]> (commit_signer:6/78=8%)
Cc: Thierry Reding <[email protected]> (commit_signer:5/78=6%)
Cc: Maxime Ripard <[email protected]> (commit_signer:5/78=6%)
Cc: "Andreas F?rber" <[email protected]> (authored:4/78=5%)
Cc: Marek Vasut <[email protected]> (authored:4/78=5%)
Cc: Rask Ingemann Lambertsen <[email protected]> (added_lines:14/92=15%,removed_lines:13/14=93%)
Cc: Greg Kroah-Hartman <[email protected]> (removed_lines:1/14=7%,commit_signer:66/621=11%)
Cc: "David S. Miller" <[email protected]> (commit_signer:52/621=8%)
Cc: Mauro Carvalho Chehab <[email protected]> (commit_signer:44/621=7%)
Cc: devicetree at vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
To: linux-kernel at vger.kernel.org (open list)
Cc: Russell King <[email protected]> (maintainer:ARM PORT)
Cc: Shawn Guo <[email protected]> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
Cc: Sascha Hauer <[email protected]> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
Cc: Fabio Estevam <[email protected]> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
Cc: linux-arm-kernel at lists.infradead.org (moderated list:ARM PORT)

Patrick Bruenn (2):
dt-bindings: arm: Add entry for Beckhoff CX9020
ARM: dts: imx: add CX9020 Embedded PC device tree

 Documentation/devicetree/bindings/arm/bhf.txt      |   6 +
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 MAINTAINERS                                        |   6 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/imx53-cx9020.dts                 | 295 +++++++++++++++++++++
 arch/arm/boot/dts/imx53-pinfunc.h                  |   4 +
 arch/arm/boot/dts/imx53.dtsi                       |   9 +
 7 files changed, 322 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/bhf.txt
 create mode 100644 arch/arm/boot/dts/imx53-cx9020.dts
Signature · 1 line
2.11.0
author
#14 lore raw

PATCH v4 1/2 dt-bindings: arm: Add entry for Beckhoff CX9020

From: Patrick Bruenn <p.bruenn-QonKdJ6Bx35Wk0Htik3J/[email protected]>

- add vendor prefix bhf for Beckhoff
- add new board binding bhf,cx9020

Signed-off-by Patrick Bruenn <p.bruenn-QonKdJ6Bx35Wk0Htik3J/[email protected]>
---
 Documentation/devicetree/bindings/arm/bhf.txt         | 6 ++++++
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 MAINTAINERS                                           | 5 +++++
 3 files changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/bhf.txt
Documentation/devicetree/bindings/arm/bhf.txt new file +6 -0
new file mode 100644
index 000000000000..886b503caf9c
@@ -0,0 +1,6 @@
+Beckhoff Automation Platforms Device Tree Bindings
+--------------------------------------------------
+
+CX9020 Embedded PC
+Required root node properties:
+    - compatible = "bhf,cx9020", "fsl,imx53";
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index daf465bef758..20c2cf57ebc9 100644
@@ -47,6 +47,7 @@ avic	Shanghai AVIC Optoelectronics Co., Ltd.
 axentia	Axentia Technologies AB
 axis	Axis Communications AB
 bananapi BIPAI KEJI LIMITED
+bhf	Beckhoff Automation GmbH & Co. KG
 boe	BOE Technology Group Co., Ltd.
 bosch	Bosch Sensortec GmbH
 boundary	Boundary Devices Inc.
MAINTAINERS +5 -0
index 205d3977ac46..1bf282843dc2 100644
@@ -1172,6 +1172,11 @@ M:	Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/[email protected]>
 S:	Maintained
 F:	drivers/clk/at91
 
+ARM/BECKHOFF SUPPORT
+M:	Patrick Bruenn <p.bruenn-QonKdJ6Bx35Wk0Htik3J/[email protected]>
+S:	Maintained
+F:	Documentation/devicetree/bindings/arm/bhf.txt
+
 ARM/CALXEDA HIGHBANK ARCHITECTURE
 M:	Rob Herring <[email protected]>
 L:	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org (moderated for non-subscribers)
Signature · 7 lines
2.11.0


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author
#16 lore raw

PATCH v4 2/2 ARM: dts: imx: add CX9020 Embedded PC device tree

In reply to linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

The CX9020 differs from i.MX53 Quick Start Board by:
- use uart2 instead of uart1
- DVI-D connector instead of VGA
- no audio
- no SATA connector
- CCAT FPGA connected to emi
- enable rtc

Signed-off-by Patrick Bruenn <[email protected]>

---

v4:
- move alternative UART2 pinmux settings to imx53-pinfunc.h
- fix copyright notice and model name to clearify cx9020 is a Beckhoff board and not from Freescale/NXP/Qualcomm
- add "bhf,cx9020" compatible
- remove ccat node and pin configuration as long as the ccat driver is not mainlined
- use dvi-connector + ti,tfp410 instead of panel-simple
- add newlines between property list and child nodes
- replace underscores in node names with hypens
- replace magic number 0 with polarity defines from include/dt-bindings/gpio/gpio.h
- move rtc node into imx53.dtsi, change it's name into 'srtc', to avoid a conflict with 'rtc' node in imx53-m53.dtsi
- rename regulator-3p2v
- drop imx53-qsb container node
- make iomux configuration explicit
- remove unused audmux
- remove unused led_pin_gpio3_23 configuration
- use blue gpio-leds as disk-activity indicators for mmc0 and mmc1
- add mmc indicator leds to sdhc pingroups
- keep node names in alphabetical order
- remove unused sata and ssi2
- remove unused pin configs from hoggrp
- add entry for imx53-cx9020.dts to MAINTAINERS

v3: add missig changelog
v2:
- keep alphabetic order of dts/Makefile
- configure uart2 with 'fsl,dte-mode'
- use display-0 and panel-0 as node names
- remove unnecessary "simple-bus" for fixed regulators

Cc Andrew Lunn <[email protected]>
---
 MAINTAINERS                        |   1 +
 arch/arm/boot/dts/Makefile         |   1 +
 arch/arm/boot/dts/imx53-cx9020.dts | 295 +++++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/imx53-pinfunc.h  |   4 +
 arch/arm/boot/dts/imx53.dtsi       |   9 ++
 5 files changed, 310 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx53-cx9020.dts
MAINTAINERS +1 -0
index 1bf282843dc2..1bd06328f79b 100644
@@ -1176,6 +1176,7 @@ ARM/BECKHOFF SUPPORT
 M:	Patrick Bruenn <[email protected]>
 S:	Maintained
 F:	Documentation/devicetree/bindings/arm/bhf.txt
+F:	arch/arm/boot/dts/imx53-cx9020.dts
 
 ARM/CALXEDA HIGHBANK ARCHITECTURE
 M:	Rob Herring <[email protected]>
arch/arm/boot/dts/Makefile +1 -0
index 4b17f35dc9a7..f0ba9be523e0 100644
@@ -340,6 +340,7 @@ dtb-$(CONFIG_SOC_IMX51) += \
 	imx51-ts4800.dtb
 dtb-$(CONFIG_SOC_IMX53) += \
 	imx53-ard.dtb \
+	imx53-cx9020.dtb \
 	imx53-m53evk.dtb \
 	imx53-mba53.dtb \
 	imx53-qsb.dtb \
arch/arm/boot/dts/imx53-cx9020.dts new file +295 -0

295 lines not on this page · raw message

arch/arm/boot/dts/imx53-pinfunc.h +4 -0
index aec406bc65eb..59f9c29e3fe2 100644
@@ -524,6 +524,7 @@
 #define MX53_PAD_EIM_D25__UART1_DSR				0x140 0x488 0x000 0x7 0x0
 #define MX53_PAD_EIM_D26__EMI_WEIM_D_26				0x144 0x48c 0x000 0x0 0x0
 #define MX53_PAD_EIM_D26__GPIO3_26				0x144 0x48c 0x000 0x1 0x0
+#define MX53_PAD_EIM_D26__UART2_RXD_MUX				0x144 0x48c 0x880 0x2 0x0
 #define MX53_PAD_EIM_D26__UART2_TXD_MUX				0x144 0x48c 0x000 0x2 0x0
 #define MX53_PAD_EIM_D26__FIRI_RXD				0x144 0x48c 0x80c 0x3 0x0
 #define MX53_PAD_EIM_D26__IPU_CSI0_D_1				0x144 0x48c 0x000 0x4 0x0

@@ -533,6 +534,7 @@
 #define MX53_PAD_EIM_D27__EMI_WEIM_D_27				0x148 0x490 0x000 0x0 0x0
 #define MX53_PAD_EIM_D27__GPIO3_27				0x148 0x490 0x000 0x1 0x0
 #define MX53_PAD_EIM_D27__UART2_RXD_MUX				0x148 0x490 0x880 0x2 0x1
+#define MX53_PAD_EIM_D27__UART2_TXD_MUX				0x148 0x490 0x000 0x2 0x0
 #define MX53_PAD_EIM_D27__FIRI_TXD				0x148 0x490 0x000 0x3 0x0
 #define MX53_PAD_EIM_D27__IPU_CSI0_D_0				0x148 0x490 0x000 0x4 0x0
 #define MX53_PAD_EIM_D27__IPU_DI1_PIN13				0x148 0x490 0x000 0x5 0x0

@@ -541,6 +543,7 @@
 #define MX53_PAD_EIM_D28__EMI_WEIM_D_28				0x14c 0x494 0x000 0x0 0x0
 #define MX53_PAD_EIM_D28__GPIO3_28				0x14c 0x494 0x000 0x1 0x0
 #define MX53_PAD_EIM_D28__UART2_CTS				0x14c 0x494 0x000 0x2 0x0
+#define MX53_PAD_EIM_D28__UART2_RTS				0x14c 0x494 0x87c 0x2 0x0
 #define MX53_PAD_EIM_D28__IPU_DISPB0_SER_DIO			0x14c 0x494 0x82c 0x3 0x1
 #define MX53_PAD_EIM_D28__CSPI_MOSI				0x14c 0x494 0x788 0x4 0x1
 #define MX53_PAD_EIM_D28__I2C1_SDA				0x14c 0x494 0x818 0x5 0x1

@@ -548,6 +551,7 @@
 #define MX53_PAD_EIM_D28__IPU_DI0_PIN13				0x14c 0x494 0x000 0x7 0x0
 #define MX53_PAD_EIM_D29__EMI_WEIM_D_29				0x150 0x498 0x000 0x0 0x0
 #define MX53_PAD_EIM_D29__GPIO3_29				0x150 0x498 0x000 0x1 0x0
+#define MX53_PAD_EIM_D29__UART2_CTS				0x150 0x498 0x000 0x2 0x0
 #define MX53_PAD_EIM_D29__UART2_RTS				0x150 0x498 0x87c 0x2 0x1
 #define MX53_PAD_EIM_D29__IPU_DISPB0_SER_RS			0x150 0x498 0x000 0x3 0x0
 #define MX53_PAD_EIM_D29__CSPI_SS0				0x150 0x498 0x78c 0x4 0x2
arch/arm/boot/dts/imx53.dtsi +9 -0
index 2e516f4985e4..8bf0d89cdd35 100644
@@ -433,6 +433,15 @@
 				clock-names = "ipg", "per";
 			};
 
+			srtc: srtc at 53fa4000 {
+				compatible = "fsl,imx53-rtc", "fsl,imx25-rtc";
+				reg = <0x53fa4000 0x4000>;
+				interrupts = <24>;
+				interrupt-parent = <&tzic>;
+				clocks = <&clks IMX5_CLK_SRTC_GATE>;
+				clock-names = "ipg";
+			};
+
 			iomuxc: iomuxc at 53fa8000 {
 				compatible = "fsl,imx53-iomuxc";
 				reg = <0x53fa8000 0x4000>;
Signature · 1 line
2.11.0
maintainer Acked-by on v4 1/2
#15 lore raw

Re: [PATCH v4 1/2] dt-bindings: arm: Add entry for Beckhoff CX9020

In reply to [email protected]
Quoted 5 lines · On Fri, Jul 21, 2017 at 06:06:39AM +0200…

From: Patrick Bruenn <p.bruenn-QonKdJ6Bx35Wk0Htik3J/[email protected]>

- add vendor prefix bhf for Beckhoff
- add new board binding bhf,cx9020

Quoted 7 lines
Signed-off-by Patrick Bruenn <p.bruenn-QonKdJ6Bx35Wk0Htik3J/[email protected]>
---
 Documentation/devicetree/bindings/arm/bhf.txt         | 6 ++++++
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 MAINTAINERS                                           | 5 +++++
 3 files changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/bhf.txt
Acked-by Rob Herring <[email protected]>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#17 lore raw
In reply to [email protected]
Quoted 11 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

The CX9020 differs from i.MX53 Quick Start Board by:
- use uart2 instead of uart1
- DVI-D connector instead of VGA
- no audio
- no SATA connector
- CCAT FPGA connected to emi
- enable rtc

Signed-off-by Patrick Bruenn <[email protected]>

Where is the patch 1/2?

Quoted 36 lines

---

v4:
- move alternative UART2 pinmux settings to imx53-pinfunc.h
- fix copyright notice and model name to clearify cx9020 is a Beckhoff board and not from Freescale/NXP/Qualcomm
- add "bhf,cx9020" compatible
- remove ccat node and pin configuration as long as the ccat driver is not mainlined
- use dvi-connector + ti,tfp410 instead of panel-simple
- add newlines between property list and child nodes
- replace underscores in node names with hypens
- replace magic number 0 with polarity defines from include/dt-bindings/gpio/gpio.h
- move rtc node into imx53.dtsi, change it's name into 'srtc', to avoid a conflict with 'rtc' node in imx53-m53.dtsi
- rename regulator-3p2v
- drop imx53-qsb container node
- make iomux configuration explicit
- remove unused audmux
- remove unused led_pin_gpio3_23 configuration
- use blue gpio-leds as disk-activity indicators for mmc0 and mmc1
- add mmc indicator leds to sdhc pingroups
- keep node names in alphabetical order
- remove unused sata and ssi2
- remove unused pin configs from hoggrp
- add entry for imx53-cx9020.dts to MAINTAINERS

v3: add missig changelog
v2:
- keep alphabetic order of dts/Makefile
- configure uart2 with 'fsl,dte-mode'
- use display-0 and panel-0 as node names
- remove unnecessary "simple-bus" for fixed regulators

Quoted 3 lines
Cc Andrew Lunn <[email protected]>
---
 MAINTAINERS                        |   1 +

I do not take the changes on this file.

Quoted 4 lines
 arch/arm/boot/dts/Makefile         |   1 +
 arch/arm/boot/dts/imx53-cx9020.dts | 295 +++++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/imx53-pinfunc.h  |   4 +
 arch/arm/boot/dts/imx53.dtsi       |   9 ++

Please have separate patches for imx53-pinfunc.h and imx53.dtsi. Do not mix them up with board support dts changes.

Quoted 59 lines
 5 files changed, 310 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx53-cx9020.dts
MAINTAINERS +1 -0
index 1bf282843dc2..1bd06328f79b 100644
@@ -1176,6 +1176,7 @@ ARM/BECKHOFF SUPPORT
 M:	Patrick Bruenn <[email protected]>
 S:	Maintained
 F:	Documentation/devicetree/bindings/arm/bhf.txt
+F:	arch/arm/boot/dts/imx53-cx9020.dts
 
 ARM/CALXEDA HIGHBANK ARCHITECTURE
 M:	Rob Herring <[email protected]>
arch/arm/boot/dts/Makefile +1 -0
index 4b17f35dc9a7..f0ba9be523e0 100644
@@ -340,6 +340,7 @@ dtb-$(CONFIG_SOC_IMX51) += \
 	imx51-ts4800.dtb
 dtb-$(CONFIG_SOC_IMX53) += \
 	imx53-ard.dtb \
+	imx53-cx9020.dtb \
 	imx53-m53evk.dtb \
 	imx53-mba53.dtb \
 	imx53-qsb.dtb \
arch/arm/boot/dts/imx53-cx9020.dts new file +26 -0
new file mode 100644
index 000000000000..c4f9c89668c2
@@ -0,0 +1,295 @@
+/*
+ * Copyright 2017 Beckhoff Automation GmbH & Co. KG
+ * based on imx53-qsb.dts
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+#include "imx53.dtsi"
+
+/ {
+	model = "Beckhoff CX9020 Embedded PC";
+	compatible = "bhf,cx9020", "fsl,imx53";
+
+	chosen {
+		stdout-path = &uart2;
+	};
+
+	memory {
+		reg = <0x70000000 0x20000000>,
+		      <0xb0000000 0x20000000>;

arch/arm/boot/dts/imx53-cx9020.dts line 36

Quoted 10 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +10 -0
+	};
+
+	display-0 {
+		#address-cells =<1>;
+		#size-cells = <0>;
+		compatible = "fsl,imx-parallel-display";
+		interface-pix-fmt = "rgb24";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_ipu_disp0>;
+		status = "okay";

This status line is not necessary. We usually use "okay" to toggle the status which is set "disabled" in <soc>.dtsi.

Quoted 80 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +80 -0
+
+		port at 0 {
+			reg = <0>;
+
+			display0_in: endpoint {
+				remote-endpoint = <&ipu_di0_disp0>;
+			};
+		};
+
+		port at 1 {
+			reg = <1>;
+
+			display0_out: endpoint {
+				remote-endpoint = <&tfp410_in>;
+			};
+		};
+	};
+
+	dvi-connector {
+		compatible = "dvi-connector";
+		ddc-i2c-bus = <&i2c2>;
+		digital;
+
+		port {
+			dvi_connector_in: endpoint {
+				remote-endpoint = <&tfp410_out>;
+			};
+		};
+	};
+
+	dvi-converter {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "ti,tfp410";
+
+		port at 0 {
+			reg = <0>;
+
+			tfp410_in: endpoint {
+				remote-endpoint = <&display0_out>;
+			};
+		};
+
+		port at 1 {
+			reg = <1>;
+
+			tfp410_out: endpoint {
+				remote-endpoint = <&dvi_connector_in>;
+			};
+		};
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		pwr-r {
+			gpios = <&gpio3 22 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		pwr-g {
+			gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>;
+			default-state = "on";
+		};
+
+		pwr-b {
+			gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		sd1-b {
+			linux,default-trigger = "mmc0";
+			gpios = <&gpio3 20 GPIO_ACTIVE_HIGH>;
+		};
+
+		sd2-b {
+			linux,default-trigger = "mmc1";
+			gpios = <&gpio3 17 GPIO_ACTIVE_HIGH>;
+		};
+	};

arch/arm/boot/dts/imx53-cx9020.dts line 126

Quoted 10 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +10 -0
+
+	regulator-3p2v {
+		compatible = "regulator-fixed";
+		regulator-name = "3P2V";
+		regulator-min-microvolt = <3200000>;
+		regulator-max-microvolt = <3200000>;
+		regulator-always-on;
+	};
+
+	reg_usb_vbus: regulator {

The node name "regulator" is too generic. The "regulator-vbus" might be the one you want to use.

Shawn

Quoted 8 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +8 -0
+		compatible = "regulator-fixed";
+		regulator-name = "usb_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		gpio = <&gpio7 8 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+};
#18 lore raw
Quoted 13 lines

From: Shawn Guo [mailto:shawnguo at kernel.org]

Quoted 10 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

The CX9020 differs from i.MX53 Quick Start Board by:
- use uart2 instead of uart1
- DVI-D connector instead of VGA
- no audio
- no SATA connector
- CCAT FPGA connected to emi
- enable rtc

Quoted 4 lines
Quoted 1 line
Signed-off-by Patrick Bruenn <[email protected]>

Where is the patch 1/2?

You can find a copy here [1], or wait for the next revision, I will try to improve my git send-mail skills until then. I used git send-email with "--to-cmd ./scripts/get_maintainer.pl" to send the series. I just discovered it would have been better to use To: and Cc: in the cover letter and send with "--to-cover --cc-cover".
I will drop "--in-reply-to" for the next revision, too...
Is there something like patman [2] from the u-boot project for the kernel, that I am missing?

Quoted 36 lines
Quoted 36 lines

---

v4:
- move alternative UART2 pinmux settings to imx53-pinfunc.h
- fix copyright notice and model name to clearify cx9020 is a Beckhoff board and not from Freescale/NXP/Qualcomm
- add "bhf,cx9020" compatible
- remove ccat node and pin configuration as long as the ccat driver is not mainlined
- use dvi-connector + ti,tfp410 instead of panel-simple
- add newlines between property list and child nodes
- replace underscores in node names with hypens
- replace magic number 0 with polarity defines from include/dt-bindings/gpio/gpio.h
- move rtc node into imx53.dtsi, change it's name into 'srtc', to avoid a conflict with 'rtc' node in imx53-m53.dtsi
- rename regulator-3p2v
- drop imx53-qsb container node
- make iomux configuration explicit
- remove unused audmux
- remove unused led_pin_gpio3_23 configuration
- use blue gpio-leds as disk-activity indicators for mmc0 and mmc1
- add mmc indicator leds to sdhc pingroups
- keep node names in alphabetical order
- remove unused sata and ssi2
- remove unused pin configs from hoggrp
- add entry for imx53-cx9020.dts to MAINTAINERS

v3: add missig changelog
v2:
- keep alphabetic order of dts/Makefile
- configure uart2 with 'fsl,dte-mode'
- use display-0 and panel-0 as node names
- remove unnecessary "simple-bus" for fixed regulators

Quoted 6 lines
Quoted 3 lines
Cc Andrew Lunn <[email protected]>
---
 MAINTAINERS                        |   1 +

I do not take the changes on this file.

Do you mean you keep maintainership for imx53-cx9020.dts, or do you mean I should group it in the patch which adds imx53-cx9020.dts? I am fine with both and would be glad to have your guidance. I just didn't understand clearly what was meant.

Quoted 9 lines
Quoted 2 lines
 arch/arm/boot/dts/Makefile         |   1 +
 arch/arm/boot/dts/imx53-cx9020.dts | 295

+++++++++++++++++++++++++++++++++++++

Quoted 2 lines
 arch/arm/boot/dts/imx53-pinfunc.h  |   4 +
 arch/arm/boot/dts/imx53.dtsi       |   9 ++

Please have separate patches for imx53-pinfunc.h and imx53.dtsi. Do not mix them up with board support dts changes.

Okay, I will split it into three patches?
1. Adding SRTC to imx53.dtsi
2. Adding UART2 pinmux settings to imx53-pinfunc.h
3. Adding CX9020 board support

Quoted 65 lines

Review

Quoted 28 lines
 5 files changed, 310 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx53-cx9020.dts
MAINTAINERS +1 -0
index 1bf282843dc2..1bd06328f79b 100644
@@ -1176,6 +1176,7 @@ ARM/BECKHOFF SUPPORT
 M:  Patrick Bruenn <[email protected]>
 S:  Maintained
 F:  Documentation/devicetree/bindings/arm/bhf.txt
+F:  arch/arm/boot/dts/imx53-cx9020.dts
 
 ARM/CALXEDA HIGHBANK ARCHITECTURE
 M:  Rob Herring <[email protected]>
arch/arm/boot/dts/Makefile +1 -0
index 4b17f35dc9a7..f0ba9be523e0 100644
@@ -340,6 +340,7 @@ dtb-$(CONFIG_SOC_IMX51) += \
     imx51-ts4800.dtb
 dtb-$(CONFIG_SOC_IMX53) += \
     imx53-ard.dtb \
+    imx53-cx9020.dtb \
     imx53-m53evk.dtb \
     imx53-mba53.dtb \
     imx53-qsb.dtb \
(quoted diff) +0 -0

b/arch/arm/boot/dts/imx53-cx9020.dts

Quoted 36 lines

new file mode 100644
index 000000000000..c4f9c89668c2

arch/arm/boot/dts/imx53-cx9020.dts new file +31 -0
@@ -0,0 +1,295 @@
+/*
+ * Copyright 2017 Beckhoff Automation GmbH & Co. KG
+ * based on imx53-qsb.dts
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+#include "imx53.dtsi"
+
+/ {
+    model = "Beckhoff CX9020 Embedded PC";
+    compatible = "bhf,cx9020", "fsl,imx53";
+
+    chosen {
+            stdout-path = &uart2;
+    };
+
+    memory {
+            reg = <0x70000000 0x20000000>,
+                  <0xb0000000 0x20000000>;
+    };
+
+    display-0 {
+            #address-cells =<1>;
+            #size-cells = <0>;
Quoted 9 lines

arch/arm/boot/dts/imx53-cx9020.dts line 36

Quoted 5 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +5 -0
+            compatible = "fsl,imx-parallel-display";
+            interface-pix-fmt = "rgb24";
+            pinctrl-names = "default";
+            pinctrl-0 = <&pinctrl_ipu_disp0>;
+            status = "okay";

This status line is not necessary. We usually use "okay" to toggle the status which is set "disabled" in <soc>.dtsi.

I will drop it in v5

Quoted 85 lines
Quoted 85 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +85 -0
+
+            port at 0 {
+                    reg = <0>;
+
+                    display0_in: endpoint {
+                            remote-endpoint = <&ipu_di0_disp0>;
+                    };
+            };
+
+            port at 1 {
+                    reg = <1>;
+
+                    display0_out: endpoint {
+                            remote-endpoint = <&tfp410_in>;
+                    };
+            };
+    };
+
+    dvi-connector {
+            compatible = "dvi-connector";
+            ddc-i2c-bus = <&i2c2>;
+            digital;
+
+            port {
+                    dvi_connector_in: endpoint {
+                            remote-endpoint = <&tfp410_out>;
+                    };
+            };
+    };
+
+    dvi-converter {
+            #address-cells = <1>;
+            #size-cells = <0>;
+            compatible = "ti,tfp410";
+
+            port at 0 {
+                    reg = <0>;
+
+                    tfp410_in: endpoint {
+                            remote-endpoint = <&display0_out>;
+                    };
+            };
+
+            port at 1 {
+                    reg = <1>;
+
+                    tfp410_out: endpoint {
+                            remote-endpoint = <&dvi_connector_in>;
+                    };
+            };
+    };
+
+    leds {
+            compatible = "gpio-leds";
+
+            pwr-r {
+                    gpios = <&gpio3 22 GPIO_ACTIVE_HIGH>;
+                    default-state = "off";
+            };
+
+            pwr-g {
+                    gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>;
+                    default-state = "on";
+            };
+
+            pwr-b {
+                    gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
+                    default-state = "off";
+            };
+
+            sd1-b {
+                    linux,default-trigger = "mmc0";
+                    gpios = <&gpio3 20 GPIO_ACTIVE_HIGH>;
+            };
+
+            sd2-b {
+                    linux,default-trigger = "mmc1";
+                    gpios = <&gpio3 17 GPIO_ACTIVE_HIGH>;
+            };
+    };
+
+    regulator-3p2v {
+            compatible = "regulator-fixed";
+            regulator-name = "3P2V";
+            regulator-min-microvolt = <3200000>;
Quoted 9 lines

arch/arm/boot/dts/imx53-cx9020.dts line 126

Quoted 5 lines
arch/arm/boot/dts/imx53-cx9020.dts new file +5 -0
+            regulator-max-microvolt = <3200000>;
+            regulator-always-on;
+    };
+
+    reg_usb_vbus: regulator {

The node name "regulator" is too generic. The "regulator-vbus" might be the one you want to use.

Okay, I will call it " regulator-vbus" in the next version

Quoted 2 lines

Shawn

Thanks a lot for your time and patience,
Patrick

[1] https://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1450310.html
[2] http://git.denx.de/?p=u-boot.git;a=blob;f=tools/patman/README
Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075

#19 lore raw
Quoted 15 lines · Patrick Br?nn
Quoted 15 lines

From: Shawn Guo [mailto:shawnguo at kernel.org]

Quoted 11 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

The CX9020 differs from i.MX53 Quick Start Board by:
- use uart2 instead of uart1
- DVI-D connector instead of VGA
- no audio
- no SATA connector
- CCAT FPGA connected to emi
- enable rtc

Signed-off-by Patrick Bruenn <[email protected]>
Quoted 8 lines
Quoted 2 lines

Where is the patch 1/2?

You can find a copy here [1], or wait for the next revision, I will try to improve my git send-mail skills until then. I used git send-email with "--to-cmd ./scripts/get_maintainer.pl" to send the series. I just discovered it would have been better to use To: and Cc: in the cover letter and send with "--to-cover --cc-cover".
I will drop "--in-reply-to" for the next revision, too...
Is there something like patman [2] from the u-boot project for the kernel, that I am missing?

I do not use anything like that, but always manually edit recipients. It's a bit silly, but can make the recipients more precise and limited.

Quoted 40 lines
Quoted 40 lines
Quoted 39 lines

---

v4:
- move alternative UART2 pinmux settings to imx53-pinfunc.h
- fix copyright notice and model name to clearify cx9020 is a Beckhoff board and not from Freescale/NXP/Qualcomm
- add "bhf,cx9020" compatible
- remove ccat node and pin configuration as long as the ccat driver is not mainlined
- use dvi-connector + ti,tfp410 instead of panel-simple
- add newlines between property list and child nodes
- replace underscores in node names with hypens
- replace magic number 0 with polarity defines from include/dt-bindings/gpio/gpio.h
- move rtc node into imx53.dtsi, change it's name into 'srtc', to avoid a conflict with 'rtc' node in imx53-m53.dtsi
- rename regulator-3p2v
- drop imx53-qsb container node
- make iomux configuration explicit
- remove unused audmux
- remove unused led_pin_gpio3_23 configuration
- use blue gpio-leds as disk-activity indicators for mmc0 and mmc1
- add mmc indicator leds to sdhc pingroups
- keep node names in alphabetical order
- remove unused sata and ssi2
- remove unused pin configs from hoggrp
- add entry for imx53-cx9020.dts to MAINTAINERS

v3: add missig changelog
v2:
- keep alphabetic order of dts/Makefile
- configure uart2 with 'fsl,dte-mode'
- use display-0 and panel-0 as node names
- remove unnecessary "simple-bus" for fixed regulators

Cc Andrew Lunn <[email protected]>
---
 MAINTAINERS                        |   1 +
Quoted 6 lines
Quoted 2 lines

I do not take the changes on this file.

Do you mean you keep maintainership for imx53-cx9020.dts, or do you mean I should group it in the patch which adds imx53-cx9020.dts? I am fine with both and would be glad to have your guidance. I just didn't understand clearly what was meant.

I meant that I do not have the authority to take patches that update MAINTAINERS file. But now I think we do not even need to update MAINTAINERS just for imx53-cx9020.dts, since we already have IMX maintainer-ship covering all IMX dts files.

ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
...
F: arch/arm/boot/dts/imx*

Shawn