btrfs-progs: Enable ThreadSanitizer, using D=tsan.
Subsystems (2)
PATCH 1/1 btrfs-progs: Enable ThreadSanitizer, using D=tsan.
Tested with clang-3.9.
--- Makefile | 6 ++++++ 1 file changed, 6 insertions(+)
Makefile +6 -0
@@ -17,6 +17,7 @@ # abort - call abort() on first error (dumps core) # all - shortcut for all of the above # asan - enable address sanitizer compiler feature +# tsan - enable thread sanitizer compiler feature # ubsan - undefined behaviour sanitizer compiler feature # bcheck - extended build checks # W=123 build with warnings (default: off)
@@ -157,6 +158,11 @@ ifneq (,$(findstring asan,$(D))) DEBUG_CFLAGS_INTERNAL += -fsanitize=address endif +ifneq (,$(findstring tsan,$(D))) + DEBUG_CFLAGS_INTERNAL += -fsanitize=thread -fPIE + LD_FLAGS += -fsanitize=thread -ltsan -pie +endif + ifneq (,$(findstring ubsan,$(D))) DEBUG_CFLAGS_INTERNAL += -fsanitize=undefined endif
Signature · 1 line
2.13.2.932.g7449e964c-goog
Quoted 20 lines · Adam Buchbinder
Tested with clang-3.9.
Signed-off-by Adam Buchbinder <[email protected]>--- Makefile | 6 ++++++ 1 file changed, 6 insertions(+)Makefile +1
-0@@ -17,6 +17,7 @@ # abort - call abort() on first error (dumps core) # all - shortcut for all of the above # asan - enable address sanitizer compiler feature +# tsan - enable thread sanitizer compiler feature # ubsan - undefined behaviour sanitizer compiler feature # bcheck - extended build checks # W=123 build with warnings (default: off)
Makefile ifneq (,$(findstring asan,$(D))) · line 163
Quoted 6 lines
Makefile +3
-0@@ -157,6 +158,11 @@ ifneq (,$(findstring asan,$(D))) DEBUG_CFLAGS_INTERNAL += -fsanitize=address endif +ifneq (,$(findstring tsan,$(D))) + DEBUG_CFLAGS_INTERNAL += -fsanitize=thread -fPIE + LD_FLAGS += -fsanitize=thread -ltsan -pie
Why do you need to set PIE here? Is is necessary for tsan?
Quoted 12 lines
Makefile +2
-0+endif + ifneq (,$(findstring ubsan,$(D))) DEBUG_CFLAGS_INTERNAL += -fsanitize=undefined endifSignature · 6 lines
2.13.2.932.g7449e964c-goog -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 27 lines · Adam Buchbinder
Quoted 9 lines · David Sterba
Quoted 7 lines · Adam Buchbinder
Tested with clang-3.9.
Signed-off-by Adam Buchbinder <[email protected]>--- Makefile | 6 ++++++ 1 file changed, 6 insertions(+)Quoted 10 lines
Makefile line 21
Quoted 10 lines
Makefile +1
-0@@ -17,6 +17,7 @@ # abort - call abort() on first error (dumps core) # all - shortcut for all of the above # asan - enable address sanitizer compiler feature +# tsan - enable thread sanitizer compiler feature # ubsan - undefined behaviour sanitizer compilerfeature
Quoted 6 lines
Quoted 6 lines
Makefile +0
-0# bcheck - extended build checks # W=123 build with warnings (default: off)@@ -157,6 +158,11 @@ ifneq (,$(findstring asan,$(D))) DEBUG_CFLAGS_INTERNAL += -fsanitize=address endif
Quoted 8 lines
Quoted 5 lines
Makefile ifneq (,$(findstring asan,$(D))) · line 163
Quoted 3 lines
Makefile +3
-0+ifneq (,$(findstring tsan,$(D))) + DEBUG_CFLAGS_INTERNAL += -fsanitize=thread -fPIE + LD_FLAGS += -fsanitize=thread -ltsan -pieWhy do you need to set PIE here? Is is necessary for tsan?
Yes; see https://clang.llvm.org/docs/ThreadSanitizer.html:
"Non-position-independent executables are not supported."
Thanks, patch applied.
Quoted 20 lines · Adam Buchbinder
Tested with clang-3.9.
Signed-off-by Adam Buchbinder <[email protected]>--- Makefile | 6 ++++++ 1 file changed, 6 insertions(+)Makefile +1
-0@@ -17,6 +17,7 @@ # abort - call abort() on first error (dumps core) # all - shortcut for all of the above # asan - enable address sanitizer compiler feature +# tsan - enable thread sanitizer compiler feature # ubsan - undefined behaviour sanitizer compiler feature # bcheck - extended build checks # W=123 build with warnings (default: off)
Makefile ifneq (,$(findstring asan,$(D))) · line 163
Quoted 6 lines
Makefile +3
-0@@ -157,6 +158,11 @@ ifneq (,$(findstring asan,$(D))) DEBUG_CFLAGS_INTERNAL += -fsanitize=address endif +ifneq (,$(findstring tsan,$(D))) + DEBUG_CFLAGS_INTERNAL += -fsanitize=thread -fPIE + LD_FLAGS += -fsanitize=thread -ltsan -pie
I did not notice that first, but there's no variable LD_FLAGS, it's LDFLAGS. So either clang assumes this variable and used it or this magically worked independent of the flags you set here.
The LDFLAGS should be set in a similar way as DEBUG_CFLAGS_INTERNAL, I'll fix that myself. Then the linker flags are then passed and it also works with gcc.
The libbtrfs library still fails to build, complaining about the missing fPIC flags, which is a bit puzzling as the flags are there.
[CC] send-stream.o
gcc -g -O1 -Wall -D_FORTIFY_SOURCE=2 -std=gnu90 -include config.h -DBTRFS_FLAT_INCLUDES -D_XOPEN_SOURCE=700 -fno-strict-aliasing -fPIC -I/labs/dsterba/gits/btrfs-progs -I/labs/dsterba/gits/btrfs-progs/kernel-lib -O0 -U_FORTIFY_SOURCE -ggdb3 -fsanitize=thread -fPIE -c send-stream.c -o send-stream.o
[LD] libbtrfs.so.0.1
gcc -g -O1 -Wall -D_FORTIFY_SOURCE=2 -std=gnu90 -include config.h -DBTRFS_FLAT_INCLUDES -D_XOPEN_SOURCE=700 -fno-strict-aliasing -fPIC -I/labs/dsterba/gits/btrfs-progs -I/labs/dsterba/gits/btrfs-progs/kernel-lib -O0 -U_FORTIFY_SOURCE -ggdb3 -fsanitize=thread -fPIE send-stream.o send-utils.o kernel-lib/rbtree.o btrfs-list.o kernel-lib/crc32c.o messages.o uuid-tree.o utils-lib.o rbtree-utils.o -rdynamic -L/labs/dsterba/gits/btrfs-progs -fsanitize=thread -ltsan -pie -luuid -lblkid -L. -pthread \
-shared -Wl,-soname,libbtrfs.so.0 -o libbtrfs.so.0.1/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: send-stream.o: relocation R_X86_64_PC32 against symbol `stderr@@GLIBC_2.2.5' can not be used when making a shared object; recompile with -fPIC /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
make: *** [Makefile:347: libbtrfs.so.0.1] Error 1