Skip to contentSkip to conversation

dim: restore cd in update_rerere_cache()

PATCH In review Jani Nikula 3 participants 4 messages Jul 18, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dim: restore cd in update_rerere_cache()

The refactoring dropped a cd to the drm-rerere dir, leading to "cp:
cannot stat 'rr-cache/*': No such file or directory" on dim ub.

Fixes 599eb3db59c9 ("dim: Move all rerere updating into helpers")
Cc Daniel Vetter <[email protected]>
Cc Sean Paul <[email protected]>
---
 dim | 1 +
 1 file changed, 1 insertion(+)
dim +1 -0
index 1fcd8d73fe1e..6ba2c085be16 100755
@@ -495,6 +495,7 @@ function update_rerere_cache
 {
 	echo -n "Updating rerere cache... "
 
+	cd $DIM_PREFIX/drm-rerere/
 	git pull
 	mkdir $(rr_cache_dir) &> /dev/null || true
 	cp rr-cache/* $(rr_cache_dir) -r --preserve=timestamps
Signature · 6 lines
2.11.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Jani Nikula

The refactoring dropped a cd to the drm-rerere dir, leading to "cp:
cannot stat 'rr-cache/*': No such file or directory" on dim ub.

Fixes 599eb3db59c9 ("dim: Move all rerere updating into helpers")
Cc Daniel Vetter <[email protected]>
Cc Sean Paul <[email protected]>

Thx for spotting this.

Quoted 19 lines
---
 dim | 1 +
 1 file changed, 1 insertion(+)
dim +1 -0
index 1fcd8d73fe1e..6ba2c085be16 100755
@@ -495,6 +495,7 @@ function update_rerere_cache
 {
 	echo -n "Updating rerere cache... "
 
+	cd $DIM_PREFIX/drm-rerere/
 	git pull
 	mkdir $(rr_cache_dir) &> /dev/null || true
 	cp rr-cache/* $(rr_cache_dir) -r --preserve=timestamps
Signature · 1 line
2.11.0
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tested-by
#2 lore raw
Quoted 10 lines · Daniel Vetter
Quoted 8 lines · Jani Nikula

The refactoring dropped a cd to the drm-rerere dir, leading to "cp:
cannot stat 'rr-cache/*': No such file or directory" on dim ub.

Fixes 599eb3db59c9 ("dim: Move all rerere updating into helpers")
Cc Daniel Vetter <[email protected]>
Cc Sean Paul <[email protected]>
Quoted 3 lines

Thx for spotting this.

Thanks, works for me now.

Quoted 20 lines
Quoted 19 lines
---
  dim | 1 +
  1 file changed, 1 insertion(+)
dim +1 -0
index 1fcd8d73fe1e..6ba2c085be16 100755
@@ -495,6 +495,7 @@ function update_rerere_cache
  {
  	echo -n "Updating rerere cache... "
 
+	cd $DIM_PREFIX/drm-rerere/
  	git pull
  	mkdir $(rr_cache_dir) &> /dev/null || true
  	cp rr-cache/* $(rr_cache_dir) -r --preserve=timestamps
Signature · 1 line
2.11.0
Signature · 6 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw
Quoted 11 lines · Archit Taneja
Quoted 10 lines · Daniel Vetter
Quoted 8 lines · Jani Nikula

The refactoring dropped a cd to the drm-rerere dir, leading to "cp:
cannot stat 'rr-cache/*': No such file or directory" on dim ub.

Fixes 599eb3db59c9 ("dim: Move all rerere updating into helpers")
Cc Daniel Vetter <[email protected]>
Cc Sean Paul <[email protected]>
Quoted 7 lines
Quoted 3 lines

Thx for spotting this.

Thanks, works for me now.

Thanks, pushed.

BR,
Jani.

Quoted 21 lines
Quoted 21 lines
Quoted 20 lines
---
  dim | 1 +
  1 file changed, 1 insertion(+)
dim +1 -0
index 1fcd8d73fe1e..6ba2c085be16 100755
@@ -495,6 +495,7 @@ function update_rerere_cache
  {
  	echo -n "Updating rerere cache... "
 
+	cd $DIM_PREFIX/drm-rerere/
  	git pull
  	mkdir $(rr_cache_dir) &> /dev/null || true
  	cp rr-cache/* $(rr_cache_dir) -r --preserve=timestamps
Signature · 1 line
2.11.0
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx