Skip to contentSkip to conversation

common/attr: fix check for _require_attrs()

PATCH New Ernesto A. Fernández 1 participant 1 message Jul 19, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common/attr: fix check for _require_attrs()

As of now xfstests decides if a filesystem supports attributes by trying to write one to the mount point. For some reason this fails on reiserfs, making it impossible to run tests that _require_attrs.

Fix this by checking against $TEST_DIR/syscalltest instead of $TEST_DIR.

This is probably what was intended, since the syscalltest file is touched right before running attr. It is also consistent with how the check for acl support is done.

---
 common/attr | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/attr +1 -1
index c840ce4..21ebbcd 100644
@@ -217,7 +217,7 @@ _require_attrs()
     # stored on disk.
     #
     touch $TEST_DIR/syscalltest
-    attr -s "user.xfstests" -V "attr" $TEST_DIR > $TEST_DIR/syscalltest.out 2>&1
+    attr -s "user.xfstests" -V "attr" $TEST_DIR/syscalltest > $TEST_DIR/syscalltest.out 2>&1
     cat $TEST_DIR/syscalltest.out >> $seqres.full
 
     if grep -q 'Function not implemented' $TEST_DIR/syscalltest.out; then
Signature · 1 line
2.1.4