Skip to contentSkip to conversation

igbvf: convert msleep to mdelay in atomic context

PATCH New Greg Edwards 2 participants 2 messages Jul 20, 2017 – Jul 29, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 igbvf: convert msleep to mdelay in atomic context

This fixes a "scheduling while atomic" splat seen with CONFIG_DEBUG_ATOMIC_SLEEP enabled.

---
 drivers/net/ethernet/intel/igbvf/vf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/igbvf/vf.c +1 -1
index 1d3aa9adcaa8..9577ccf4b26a 100644
@@ -149,7 +149,7 @@ static s32 e1000_reset_hw_vf(struct e1000_hw *hw)
 		msgbuf[0] = E1000_VF_RESET;
 		mbx->ops.write_posted(hw, msgbuf, 1);
 
-		msleep(10);
+		mdelay(10);
 
 		/* set our "perm_addr" based on info provided by PF */
 		ret_val = mbx->ops.read_posted(hw, msgbuf, 3);
Signature · 1 line
2.13.3
#1 lore raw

PATCH 1/1 igbvf: convert msleep to mdelay in atomic context

Quoted 8 lines

From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Greg Edwards
Sent: Thursday, July 20, 2017 9:15 AM
To: intel-wired-lan at lists.osuosl.org
Cc: Greg Edwards <[email protected]>
Subject: [Intel-wired-lan] [PATCH] igbvf: convert msleep to mdelay in atomic context

Quoted 8 lines

This fixes a "scheduling while atomic" splat seen with CONFIG_DEBUG_ATOMIC_SLEEP enabled.

---
 drivers/net/ethernet/intel/igbvf/vf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This could be considered a 3 of 3 for the 2 mbox related igbvf patches I just replied to as those introduce a call trace on driver load which this resolves.