Skip to contentSkip to conversation

Only handle reflection in the driver with Xorg < 1.16

PATCH In review Michel Dänzer 2 participants 2 messages Jul 26, 2017 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Only handle reflection in the driver with Xorg < 1.16

From: Michel Dänzer <[email protected]>

Xorg doesn't handle the hardware cursor correctly in that case for rotation and general transforms, and we can't force the SW cursor.

Fixes f2bc882f1c10 ("Handle rotation in the driver also with Xorg
                      1.12-1.18")
---
 src/drmmode_display.c | 6 ++++++
 1 file changed, 6 insertions(+)
src/drmmode_display.c +6 -0
index 840071fe7..245a92fb0 100644
@@ -677,10 +677,16 @@ drmmode_handle_transform(xf86CrtcPtr crtc)
 {
 	Bool ret;
 
+#if XORG_VERSION_CURRENT >= XORG_VERSION_NUMERIC(1,15,99,903,0)
 	if (crtc->transformPresent || crtc->rotation != RR_Rotate_0)
 	    crtc->driverIsPerformingTransform = XF86DriverTransformOutput;
 	else
 	    crtc->driverIsPerformingTransform = XF86DriverTransformNone;
+#else
+	crtc->driverIsPerformingTransform = !crtc->transformPresent &&
+		crtc->rotation != RR_Rotate_0 &&
+		(crtc->rotation & 0xf) == RR_Rotate_0;
+#endif
 
 	ret = xf86CrtcRotate(crtc);
 
Signature · 6 lines
2.13.3

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20170726094116.28302-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

Reviewed-by Alex Deucher
#2 lore raw
Quoted 8 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Michel Dänzer
Sent: Wednesday, July 26, 2017 5:41 AM
To: [email protected]
Subject: [PATCH xf86-video-ati] Only handle reflection in the driver with Xorg < 1.16

Quoted 8 lines

From: Michel Dänzer <[email protected]>

Xorg doesn't handle the hardware cursor correctly in that case for rotation and general transforms, and we can't force the SW cursor.

Fixes f2bc882f1c10 ("Handle rotation in the driver also with Xorg
                      1.12-1.18")
Quoted 28 lines
---
 src/drmmode_display.c | 6 ++++++
 1 file changed, 6 insertions(+)
src/drmmode_display.c +6 -1
index 840071fe7..245a92fb0 100644
@@ -677,10 +677,16 @@ drmmode_handle_transform(xf86CrtcPtr crtc)
 {
 	Bool ret;
 
+#if XORG_VERSION_CURRENT >= XORG_VERSION_NUMERIC(1,15,99,903,0)
 	if (crtc->transformPresent || crtc->rotation != RR_Rotate_0)
 	    crtc->driverIsPerformingTransform = XF86DriverTransformOutput;
 	else
 	    crtc->driverIsPerformingTransform = XF86DriverTransformNone;
+#else
+	crtc->driverIsPerformingTransform = !crtc->transformPresent &&
+		crtc->rotation != RR_Rotate_0 &&
+		(crtc->rotation & 0xf) == RR_Rotate_0;
+#endif
 
 	ret = xf86CrtcRotate(crtc);
 
--

2.13.3

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx