Skip to contentSkip to conversation

tinydrm: repaper: add CONFIG_THERMAL dependency

PATCH In review Arnd Bergmann 2 participants 2 messages Jul 27, 2017 – Jul 29, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tinydrm: repaper: add CONFIG_THERMAL dependency

The new RePaper driver uses the thermal subsystem, and fails to link when it is built-in but thermal is a loadable module:

drivers/gpu/drm/tinydrm/repaper.o: In function `repaper_probe':
repaper.c:(.text+0x540): undefined reference to thermal_zone_get_zone_by_name' drivers/gpu/drm/tinydrm/repaper.o: In function repaper_fb_dirty':
repaper.c:(.text+0xff4): undefined reference to `thermal_zone_get_temp'

This adds another Kconfig dependency to prevent the broken configuration, forcing repaper to be a module too.

Fixes 3589211e9b03 ("drm/tinydrm: Add RePaper e-ink driver")
---
 drivers/gpu/drm/tinydrm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/tinydrm/Kconfig +1 -0
index 9596e447f877..f17c3caceab2 100644
@@ -23,6 +23,7 @@ config TINYDRM_MI0283QT
 config TINYDRM_REPAPER
 	tristate "DRM support for Pervasive Displays RePaper panels (V231)"
 	depends on DRM_TINYDRM && SPI
+	depends on THERMAL || !THERMAL
 	help
 	  DRM driver for the following Pervasive Displays panels:
 	  1.44" TFT EPD Panel (E1144CS021)
Signature · 1 line
2.9.0
#1 lore raw

Den 27.07.2017 11.58, skrev Arnd Bergmann:

Quoted 8 lines

The new RePaper driver uses the thermal subsystem, and fails to link when it is built-in but thermal is a loadable module:

drivers/gpu/drm/tinydrm/repaper.o: In function `repaper_probe':
repaper.c:(.text+0x540): undefined reference to thermal_zone_get_zone_by_name' drivers/gpu/drm/tinydrm/repaper.o: In function repaper_fb_dirty':
repaper.c:(.text+0xff4): undefined reference to `thermal_zone_get_temp'

Quoted 6 lines

This adds another Kconfig dependency to prevent the broken configuration, forcing repaper to be a module too.

Fixes 3589211e9b03 ("drm/tinydrm: Add RePaper e-ink driver")

---

Thanks for fixing this, applied to drm-misc.

Noralf.

Quoted 15 lines
  drivers/gpu/drm/tinydrm/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/tinydrm/Kconfig +1 -0
index 9596e447f877..f17c3caceab2 100644
@@ -23,6 +23,7 @@ config TINYDRM_MI0283QT
  config TINYDRM_REPAPER
  	tristate "DRM support for Pervasive Displays RePaper panels (V231)"
  	depends on DRM_TINYDRM && SPI
+	depends on THERMAL || !THERMAL
  	help
  	  DRM driver for the following Pervasive Displays panels:
  	  1.44" TFT EPD Panel (E1144CS021)