RCU/hotplug fix
Hello, Ingo,
This pull request is for an RCU change that permits waiting for grace periods started by CPUs late in the process of going offline. Lack of this capability is causing failures:
http://lkml.kernel.org/r/[email protected]
Although these failures predate v4.12, and thus are in some sense not regressions, it would be good for them to be fixed sooner rather than later, hence this RFC pull request.
This commit was posted to LKML:
http://lkml.kernel.org/r/[email protected]
This commit has been exposed to 0day test robot and -next testing and is available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo
for you to fetch changes up to a58163d8ca2c8d288ee9f95989712f98473a5ac2:
rcu: Migrate callbacks earlier in the CPU-offline timeline (2017-07-25 13:03:43 -0700)
----------------------------------------------------------------
Paul E. McKenney (1):
rcu: Migrate callbacks earlier in the CPU-offline timeline
include/linux/rcupdate.h | 1 + kernel/cpu.c | 1 + kernel/rcu/tree.c | 209 +++++++++++++++++++++++++---------------------- 3 files changed, 115 insertions(+), 96 deletions(-)
Quoted 25 lines · Paul E. McKenney
Hello, Ingo,
This pull request is for an RCU change that permits waiting for grace periods started by CPUs late in the process of going offline. Lack of this capability is causing failures:
http://lkml.kernel.org/r/[email protected]
Although these failures predate v4.12, and thus are in some sense not regressions, it would be good for them to be fixed sooner rather than later, hence this RFC pull request.
This commit was posted to LKML:
http://lkml.kernel.org/r/[email protected]This commit has been exposed to 0day test robot and -next testing and is available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.gitfor-mingofor you to fetch changes up to
a58163d8ca2c8d288ee9f95989712f98473a5ac2:rcu: Migrate callbacks earlier in the CPU-offline timeline (2017-07-25 13:03:43 -0700)
Quoted 8 lines
----------------------------------------------------------------
Paul E. McKenney (1):
rcu: Migrate callbacks earlier in the CPU-offline timelineinclude/linux/rcupdate.h | 1 + kernel/cpu.c | 1 + kernel/rcu/tree.c | 209 +++++++++++++++++++++++++---------------------- 3 files changed, 115 insertions(+), 96 deletions(-)
Pulled, thanks Paul!
Ingo
Quoted 32 lines · Ingo Molnar
Quoted 29 lines · Paul E. McKenney
Hello, Ingo,
This pull request is for an RCU change that permits waiting for grace periods started by CPUs late in the process of going offline. Lack of this capability is causing failures:
http://lkml.kernel.org/r/[email protected]
Although these failures predate v4.12, and thus are in some sense not regressions, it would be good for them to be fixed sooner rather than later, hence this RFC pull request.
This commit was posted to LKML:
http://lkml.kernel.org/r/[email protected]This commit has been exposed to 0day test robot and -next testing and is available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.gitfor-mingofor you to fetch changes up to
a58163d8ca2c8d288ee9f95989712f98473a5ac2:rcu: Migrate callbacks earlier in the CPU-offline timeline (2017-07-25 13:03:43 -0700)
----------------------------------------------------------------
Paul E. McKenney (1):
rcu: Migrate callbacks earlier in the CPU-offline timeline
Quoted 9 lines
Quoted 4 lines
include/linux/rcupdate.h | 1 + kernel/cpu.c | 1 + kernel/rcu/tree.c | 209 +++++++++++++++++++++++++---------------------- 3 files changed, 115 insertions(+), 96 deletions(-)Pulled, thanks Paul!
Ingo
Ingo,
We've been keeping an eye on this fix, so I'm trying to ascertain it's status. For my information, is this expected to hit Linus' tree in 4.13, or wait until the 4.14 merge window?
Thanks
Signature · 4 lines
Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Quoted 20 lines · Jeffrey Hugo
Quoted 20 lines
Quoted 9 lines
This commit has been exposed to 0day test robot and -next testing and is available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.gitfor-mingofor you to fetch changes up to
a58163d8ca2c8d288ee9f95989712f98473a5ac2:rcu: Migrate callbacks earlier in the CPU-offline timeline (2017-07-25 13:03:43 -0700)
Quoted 8 lines
----------------------------------------------------------------
Paul E. McKenney (1):
rcu: Migrate callbacks earlier in the CPU-offline timelineinclude/linux/rcupdate.h | 1 + kernel/cpu.c | 1 + kernel/rcu/tree.c | 209 +++++++++++++++++++++++++---------------------- 3 files changed, 115 insertions(+), 96 deletions(-)Pulled, thanks Paul!
Quoted 8 lines
Quoted 2 lines
Ingo
Ingo,
We've been keeping an eye on this fix, so I'm trying to ascertain it's status. For my information, is this expected to hit Linus' tree in 4.13, or wait until the 4.14 merge window?
It's for v4.14, it's a pretty large (and thus risky) commit that came in relatively late. If it's problem-free it can be sent to -stable.
If Paul insists I can try and send it to Linus, but it's getting fairly late in the cycle.
Thanks,
Ingo
Quoted 32 lines · Ingo Molnar
Quoted 20 lines · Jeffrey Hugo
Quoted 20 lines
Quoted 9 lines
This commit has been exposed to 0day test robot and -next testing and is available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.gitfor-mingofor you to fetch changes up to
a58163d8ca2c8d288ee9f95989712f98473a5ac2:rcu: Migrate callbacks earlier in the CPU-offline timeline (2017-07-25 13:03:43 -0700)
Quoted 8 lines
----------------------------------------------------------------
Paul E. McKenney (1):
rcu: Migrate callbacks earlier in the CPU-offline timelineinclude/linux/rcupdate.h | 1 + kernel/cpu.c | 1 + kernel/rcu/tree.c | 209 +++++++++++++++++++++++++---------------------- 3 files changed, 115 insertions(+), 96 deletions(-)Pulled, thanks Paul!
Quoted 8 lines
Quoted 2 lines
Ingo
Ingo,
We've been keeping an eye on this fix, so I'm trying to ascertain it's status. For my information, is this expected to hit Linus' tree in 4.13, or wait until the 4.14 merge window?
Quoted 5 lines
It's for v4.14, it's a pretty large (and thus risky) commit that came in relatively late. If it's problem-free it can be sent to -stable.
If Paul insists I can try and send it to Linus, but it's getting fairly late in the cycle.
Hugo, I was interpreting your email of August 22nd as meaning that the problem no longer existed in mainline:
https://marc.info/?l=linux-kernel&m=150343524911301&w=2
If my interpretation is correct, then this commit can wait until the upcoming merge window. As Ingo says, I can send patches to -stable (and backporting is required, BTW).
If my interpretation is incorrect, please let me know what the situation really is.
Thanx, Paul
Quoted 44 lines · Paul E. McKenney
Quoted 32 lines · Ingo Molnar
Quoted 20 lines · Jeffrey Hugo
Quoted 20 lines
Quoted 9 lines
This commit has been exposed to 0day test robot and -next testing and is available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.gitfor-mingofor you to fetch changes up to
a58163d8ca2c8d288ee9f95989712f98473a5ac2:rcu: Migrate callbacks earlier in the CPU-offline timeline (2017-07-25 13:03:43 -0700)Quoted 8 lines
----------------------------------------------------------------
Paul E. McKenney (1):
rcu: Migrate callbacks earlier in the CPU-offline timelineinclude/linux/rcupdate.h | 1 + kernel/cpu.c | 1 + kernel/rcu/tree.c | 209 +++++++++++++++++++++++++---------------------- 3 files changed, 115 insertions(+), 96 deletions(-)Pulled, thanks Paul!
Quoted 8 lines
Quoted 2 lines
Ingo
Ingo,
We've been keeping an eye on this fix, so I'm trying to ascertain it's status. For my information, is this expected to hit Linus' tree in 4.13, or wait until the 4.14 merge window?
Quoted 5 lines
It's for v4.14, it's a pretty large (and thus risky) commit that came in relatively late. If it's problem-free it can be sent to -stable.
If Paul insists I can try and send it to Linus, but it's getting fairly late in the cycle.
Hugo, I was interpreting your email of August 22nd as meaning that the problem no longer existed in mainline:
Quoted 9 lines
If my interpretation is correct, then this commit can wait until the upcoming merge window. As Ingo says, I can send patches to -stable (and backporting is required, BTW).
If my interpretation is incorrect, please let me know what the situation really is.
Thanx, Paul
Sorry for any confusion. Yes, that interpretation is correct. I agree, it is late in the cycle, and I am not advocating for inclusion into 4.13. We have internal processes concerning upstream fixes, and it is helpful to identify exactly when a fix is expected to hit Linus' tree - none of which is particularly important or relevant to the community, I'm just trying to bridge a few gaps.
4.14 merge window is perfectly fine. I will plan on that. Thanks for the clarification, and a huge thanks for looking at the issue and solving it.
Signature · 4 lines
Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.