Skip to contentSkip to conversation

kvm: x86: fix a race condition result to lost INIT

PATCH Wanpeng Li 1 participant 1 message Jul 30, 2017 1 message not in the archive KVM

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Wanpeng Li

author
#1 lore raw

2017-07-30 18:42 GMT+08:00 <[email protected]>:

Quoted 38 lines
Quoted 21 lines

2017-07-31 0:24 GMT+08:00 Peng Hao <[email protected]>:

Quoted 19 lines

when SMP VM start, AP may lost INIT because of receiving INIT between kvm_vcpu_ioctl_x86_get/set_vcpu_events.

vcpu 0 vcpu 1

                               kvm_vcpu_ioctl_x86_get_vcpu_events
                                       events->smi.latched_init=0

send INIT to vcpu1
set vcpu1's pending_events
kvm_vcpu_ioctl_x86_set_vcpu_events
events->smi.latched_init == 0
clear INIT in pending_events
I don't think it need set/clear kernel state according to userspace's info.

---
 arch/x86/kvm/x86.c | 6 ------
 1 file changed, 6 deletions(-)
Quoted 16 lines

arch/x86/kvm/x86.c static int · line 3161

Quoted 13 lines
arch/x86/kvm/x86.c +0 -3
index 6c7266f..393a7b7 100644
@@ -3157,12 +3157,6 @@ static int
 kvm_vcpu_ioctl_x86_set_vcpu_events(struct kvm_vcpu *vcpu,
                        vcpu->arch.hflags |= HF_SMM_INSIDE_NMI_MASK;
                else
                        vcpu->arch.hflags &= ~HF_SMM_INSIDE_NMI_MASK;
-               if (lapic_in_kernel(vcpu)) {
-                       if (events->smi.latched_init)
-                               set_bit(KVM_APIC_INIT,
 &vcpu->arch.apic->pending_events);

This is not correct, you will lose the INIT after live migration. I just send out another patch to fix it. Thanks for the report.

Quoted 1 line

yes, you're right. I should modify on qemu not kernel.

There is a patch here to fix it in kvm, https://lkml.org/lkml/2017/7/30/72

Regards,
Wanpeng Li

Quoted 9 lines
Quoted 6 lines
Quoted 6 lines
arch/x86/kvm/x86.c +0 -3
-                       else
-                               clear_bit(KVM_APIC_INIT,
 &vcpu->arch.apic->pending_events);
-               }
        }