Skip to contentSkip to conversation

lib/hexdump: Return -EINVAL in case of error in hex2bin()

PATCH Applied Andy Shevchenko 1 participant 1 message Jul 31, 2017 Library code

lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 lib/hexdump: Return -EINVAL in case of error in hex2bin()

In some cases caller would like to use error code directly without shadowing.

-EINVAL feels a rightful code to return in case of error in hex2bin().

Signed-off-by Andy Shevchenko <[email protected]>
---
 lib/hexdump.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
lib/hexdump.c +3 -2
index 992457b1284c..81b70ed37209 100644
@@ -9,6 +9,7 @@
 
 #include <linux/types.h>
 #include <linux/ctype.h>
+#include <linux/errno.h>
 #include <linux/kernel.h>
 #include <linux/export.h>
 #include <asm/unaligned.h>

@@ -42,7 +43,7 @@ EXPORT_SYMBOL(hex_to_bin);
  * @src: ascii hexadecimal string
  * @count: result length
  *
- * Return 0 on success, -1 in case of bad input.
+ * Return 0 on success, -EINVAL in case of bad input.
  */
 int hex2bin(u8 *dst, const char *src, size_t count)
 {

@@ -51,7 +52,7 @@ int hex2bin(u8 *dst, const char *src, size_t count)
 		int lo = hex_to_bin(*src++);
 
 		if ((hi < 0) || (lo < 0))
-			return -1;
+			return -EINVAL;
 
 		*dst++ = (hi << 4) | lo;
 	}
Signature · 1 line
2.13.2