usb: dwc3: omap: fix error return code in dwc3_omap_probe()
Subsystems (3)
PATCH 1/1 usb: dwc3: omap: fix error return code in dwc3_omap_probe()
platform_get_irq() returns an error code, but the dwc3-omap driver ignores it and always returns -EINVAL. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
Print and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/usb/dwc3/dwc3-omap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/dwc3/dwc3-omap.c +2 -2
@@ -478,8 +478,8 @@ static int dwc3_omap_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (dev,"missing IRQ resource\n" ); -return -EINVAL ; +dev_err (dev,"missing IRQ resource: %d\n" , irq); +return irq; } res =platform_get_resource (pdev,IORESOURCE_MEM ,0 );
Signature · 1 line
2.5.0