gpu: host1x: fix error return code in host1x_probe()
PATCH 1/1 gpu: host1x: fix error return code in host1x_probe()
platform_get_irq() returns an error code, but the host1x driver ignores it and always returns -ENXIO. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
Print and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
--- drivers/gpu/host1x/dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/host1x/dev.c +2 -2
@@ -134,8 +134,8 @@ static int host1x_probe(struct platform_device *pdev) syncpt_irq =platform_get_irq (pdev,0 );if (syncpt_irq <0 ) { -dev_err (&pdev->dev,"failed to get IRQ\n" ); -return -ENXIO ; +dev_err (&pdev->dev,"failed to get IRQ: %d\n" , syncpt_irq); +return syncpt_irq; } host =devm_kzalloc (&pdev->dev,sizeof (*host),GFP_KERNEL );
Signature · 1 line
2.5.0
Thierry Reding
AppliedQuoted 7 lines · Gustavo A. R. Silva
platform_get_irq()returns an error code, but the host1x driver ignores it and always returns-ENXIO. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.Notice that
platform_get_irq()no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
Quoted 8 lines
Print and propagate the return value of
platform_get_irqon failure.This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <gustavo-L1vi/[email protected]>--- drivers/gpu/host1x/dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry