drm/i915: Introduce intel_ddi_dp_level.
Subsystems (2)
Rodrigo Vivi
maintainerPATCH 1/6 drm/i915: Introduce intel_ddi_dp_level.
No functional changes. This only moves the DP level selection to a separated function that will be later used to organize better the vswing sequences.
--- drivers/gpu/drm/i915/intel_ddi.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +10 -6
@@ -2054,18 +2054,22 @@ static uint32_t translate_signal_level(int signal_levels)return 0 ; } +static uint32_t intel_ddi_dp_level (struct intel_dp *intel_dp) +{ +uint8_t train_set = intel_dp->train_set[0 ]; +int signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK | +DP_TRAIN_PRE_EMPHASIS_MASK ); + +return translate_signal_level (signal_levels); +} +uint32_t ddi_signal_levels (struct intel_dp *intel_dp) {struct intel_digital_port *dport =dp_to_dig_port (intel_dp);struct drm_i915_private *dev_priv =to_i915 (dport->base.base.dev);struct intel_encoder *encoder = &dport->base; -uint8_t train_set = intel_dp->train_set[0 ]; -int signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK | -DP_TRAIN_PRE_EMPHASIS_MASK );enum port port = dport->port; -uint32_t level; - - level =translate_signal_level (signal_levels); +uint32_t level =intel_ddi_dp_level (intel_dp);if (IS_GEN9_BC (dev_priv))skl_ddi_set_iboost (encoder, level);
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerPATCH 2/6 drm/i915: Align vswing sequences with old ddi buffer registers.
Vswing sequences on BXT and CNL are equivalent to the ddi buffer registers setting on other platforms.
For some reason it got aligned with skl_ddi_set_iboost what is semantically incorrect. This forced us to keep skipping ddi buffer translation tables on the platforms that has the vswing sequences.
--- drivers/gpu/drm/i915/intel_ddi.c | 36 ++++++++++++++++-------------------- 1 file changed, 16 insertions(+), 20 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +16 -20
@@ -688,9 +688,6 @@ static void intel_prepare_dp_ddi_buffers(struct intel_encoder *encoder)enum port port =intel_ddi_get_encoder_port (encoder);const struct ddi_buf_trans *ddi_translations; -if (IS_GEN9_LP (dev_priv)) -return ; -switch (encoder->type) {case INTEL_OUTPUT_EDP : ddi_translations = intel_ddi_get_buf_trans_edp(dev_priv,
@@ -741,9 +738,6 @@ static void intel_prepare_hdmi_ddi_buffers(struct intel_encoder *encoder)enum port port =intel_ddi_get_encoder_port (encoder);const struct ddi_buf_trans *ddi_translations_hdmi; -if (IS_GEN9_LP (dev_priv)) -return ; - hdmi_level =intel_ddi_hdmi_level (dev_priv, port);if (IS_GEN9_BC (dev_priv)) {
@@ -2068,18 +2062,11 @@ uint32_t ddi_signal_levels(struct intel_dp *intel_dp)struct intel_digital_port *dport =dp_to_dig_port (intel_dp);struct drm_i915_private *dev_priv =to_i915 (dport->base.base.dev);struct intel_encoder *encoder = &dport->base; -enum port port = dport->port;uint32_t level =intel_ddi_dp_level (intel_dp);if (IS_GEN9_BC (dev_priv))skl_ddi_set_iboost (encoder, level); -else if (IS_GEN9_LP (dev_priv)) -bxt_ddi_vswing_sequence (dev_priv, level, port, encoder->type); -else if (IS_CANNONLAKE (dev_priv)) { -cnl_ddi_vswing_sequence (encoder, level); -/* DDI_BUF_CTL bits 27:24 are reserved on CNL */ -return 0 ; - } +return DDI_BUF_TRANS_SELECT (level); }
@@ -2133,6 +2120,7 @@ static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder,struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);enum port port =intel_ddi_get_encoder_port (encoder);struct intel_digital_port *dig_port =enc_to_dig_port (&encoder->base); +uint32_t level =intel_ddi_dp_level (intel_dp);WARN_ON (link_mst && (port ==PORT_A || port ==PORT_E ));
@@ -2145,7 +2133,13 @@ static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder,intel_display_power_get (dev_priv, dig_port->ddi_io_power_domain); -intel_prepare_dp_ddi_buffers (encoder); +if (IS_CANNONLAKE (dev_priv)) +cnl_ddi_vswing_sequence (encoder, level); +else if (IS_GEN9_LP (dev_priv)) +bxt_ddi_vswing_sequence (dev_priv, level, port, encoder->type); +else +intel_prepare_dp_ddi_buffers (encoder); +intel_ddi_init_dp_buf_reg (encoder);intel_dp_sink_dpms (intel_dp,DRM_MODE_DPMS_ON );intel_dp_start_link_train (intel_dp);
@@ -2171,14 +2165,16 @@ static void intel_ddi_pre_enable_hdmi(struct intel_encoder *encoder,intel_display_power_get (dev_priv, dig_port->ddi_io_power_domain); -intel_prepare_hdmi_ddi_buffers (encoder); -if (IS_GEN9_BC (dev_priv)) -skl_ddi_set_iboost (encoder, level); +if (IS_CANNONLAKE (dev_priv)) +cnl_ddi_vswing_sequence (encoder, level);else if (IS_GEN9_LP (dev_priv))bxt_ddi_vswing_sequence (dev_priv, level, port,INTEL_OUTPUT_HDMI ); -else if (IS_CANNONLAKE (dev_priv)) -cnl_ddi_vswing_sequence (encoder, level); +else +intel_prepare_hdmi_ddi_buffers (encoder); + +if (IS_GEN9_BC (dev_priv)) +skl_ddi_set_iboost (encoder, level); intel_hdmi->set_infoframes(drm_encoder, has_hdmi_sink,
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerPATCH 3/6 drm/i915/cnl: Move voltage check into ddi buf trans functions.
In reply to Rodrigo ViviLet's start converging CNL buf translations to same style used on previous platforms. So first thing is to use the standard signature so we don't need to propagate the voltage check into other parts of the code, but only on the parts that it is really useful.
--- drivers/gpu/drm/i915/intel_ddi.c | 48 ++++++++++++++++++---------------------- 1 file changed, 21 insertions(+), 27 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +21 -27
@@ -1830,9 +1830,10 @@ u8 intel_ddi_dp_voltage_max(struct intel_encoder *encoder) }static const struct cnl_ddi_buf_trans * -cnl_get_buf_trans_hdmi (struct drm_i915_private *dev_priv, -u32 voltage,int *n_entries) +cnl_get_buf_trans_hdmi (struct drm_i915_private *dev_priv,int *n_entries) { +u32 voltage =I915_READ (CNL_PORT_COMP_DW3 ) &VOLTAGE_INFO_MASK ; +if (voltage ==VOLTAGE_INFO_0_85V ) { *n_entries =ARRAY_SIZE (cnl_ddi_translations_hdmi_0_85V);return cnl_ddi_translations_hdmi_0_85V;
@@ -1842,14 +1843,16 @@ cnl_get_buf_trans_hdmi(struct drm_i915_private *dev_priv, }else if (voltage ==VOLTAGE_INFO_1_05V ) { *n_entries =ARRAY_SIZE (cnl_ddi_translations_hdmi_1_05V);return cnl_ddi_translations_hdmi_1_05V; - } + }else +MISSING_CASE (voltage);return NULL ; }static const struct cnl_ddi_buf_trans * -cnl_get_buf_trans_dp (struct drm_i915_private *dev_priv, -u32 voltage,int *n_entries) +cnl_get_buf_trans_dp (struct drm_i915_private *dev_priv,int *n_entries) { +u32 voltage =I915_READ (CNL_PORT_COMP_DW3 ) &VOLTAGE_INFO_MASK ; +if (voltage ==VOLTAGE_INFO_0_85V ) { *n_entries =ARRAY_SIZE (cnl_ddi_translations_dp_0_85V);return cnl_ddi_translations_dp_0_85V;
@@ -1859,14 +1862,16 @@ cnl_get_buf_trans_dp(struct drm_i915_private *dev_priv, }else if (voltage ==VOLTAGE_INFO_1_05V ) { *n_entries =ARRAY_SIZE (cnl_ddi_translations_dp_1_05V);return cnl_ddi_translations_dp_1_05V; - } + }else +MISSING_CASE (voltage);return NULL ; }static const struct cnl_ddi_buf_trans * -cnl_get_buf_trans_edp (struct drm_i915_private *dev_priv, -u32 voltage,int *n_entries) +cnl_get_buf_trans_edp (struct drm_i915_private *dev_priv,int *n_entries) { +u32 voltage =I915_READ (CNL_PORT_COMP_DW3 ) &VOLTAGE_INFO_MASK ; +if (dev_priv->vbt.edp.low_vswing) {if (voltage ==VOLTAGE_INFO_0_85V ) { *n_entries =ARRAY_SIZE (cnl_ddi_translations_edp_0_85V);
@@ -1877,10 +1882,11 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv, }else if (voltage ==VOLTAGE_INFO_1_05V ) { *n_entries =ARRAY_SIZE (cnl_ddi_translations_edp_1_05V);return cnl_ddi_translations_edp_1_05V; - } + }else +MISSING_CASE (voltage);return NULL ; }else { -return cnl_get_buf_trans_dp (dev_priv, voltage, n_entries); +return cnl_get_buf_trans_dp (dev_priv, n_entries); } }
@@ -1888,31 +1894,19 @@ static void cnl_ddi_vswing_program(struct drm_i915_private *dev_priv, u32 level, enum port port, int type) { const struct cnl_ddi_buf_trans *ddi_translations = NULL; -u32 n_entries, val, voltage; +u32 n_entries, val;int ln; -/* -* Values for each port type are listed in -* voltage swing programming tables. -* Vccio voltage found in PORT_COMP_DW3. -*/ - voltage =I915_READ (CNL_PORT_COMP_DW3 ) &VOLTAGE_INFO_MASK ; -if (type ==INTEL_OUTPUT_HDMI ) { - ddi_translations =cnl_get_buf_trans_hdmi (dev_priv, - voltage, &n_entries); + ddi_translations =cnl_get_buf_trans_hdmi (dev_priv, &n_entries); }else if (type ==INTEL_OUTPUT_DP ) { - ddi_translations =cnl_get_buf_trans_dp (dev_priv, - voltage, &n_entries); + ddi_translations =cnl_get_buf_trans_dp (dev_priv, &n_entries); }else if (type ==INTEL_OUTPUT_EDP ) { - ddi_translations =cnl_get_buf_trans_edp (dev_priv, - voltage, &n_entries); + ddi_translations =cnl_get_buf_trans_edp (dev_priv, &n_entries); } -if (ddi_translations ==NULL ) { -MISSING_CASE (voltage); +if (WARN_ON (ddi_translations ==NULL ))return ; - }if (level >= n_entries) {DRM_DEBUG_KMS ("DDI translation not found for level %d. Using %d instead." , level, n_entries -1 );
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerPATCH 4/6 drm/i915/cnl: Move ddi buf trans related functions up.
In reply to Rodrigo ViviNo functional changes. But those functions will be needed to get max level for HDMI and DP, so let's move those up closer to other similar functions existent for previous platforms.
--- drivers/gpu/drm/i915/intel_ddi.c | 122 +++++++++++++++++++-------------------- 1 file changed, 61 insertions(+), 61 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +61 -61
@@ -588,6 +588,67 @@ skl_get_buf_trans_hdmi(struct drm_i915_private *dev_priv, int *n_entries) } } +static const struct cnl_ddi_buf_trans * +cnl_get_buf_trans_hdmi (struct drm_i915_private *dev_priv,int *n_entries) +{ +u32 voltage =I915_READ (CNL_PORT_COMP_DW3 ) &VOLTAGE_INFO_MASK ; + +if (voltage ==VOLTAGE_INFO_0_85V ) { + *n_entries =ARRAY_SIZE (cnl_ddi_translations_hdmi_0_85V); +return cnl_ddi_translations_hdmi_0_85V; + }else if (voltage ==VOLTAGE_INFO_0_95V ) { + *n_entries =ARRAY_SIZE (cnl_ddi_translations_hdmi_0_95V); +return cnl_ddi_translations_hdmi_0_95V; + }else if (voltage ==VOLTAGE_INFO_1_05V ) { + *n_entries =ARRAY_SIZE (cnl_ddi_translations_hdmi_1_05V); +return cnl_ddi_translations_hdmi_1_05V; + }else +MISSING_CASE (voltage); +return NULL ; +} + +static const struct cnl_ddi_buf_trans * +cnl_get_buf_trans_dp (struct drm_i915_private *dev_priv,int *n_entries) +{ +u32 voltage =I915_READ (CNL_PORT_COMP_DW3 ) &VOLTAGE_INFO_MASK ; + +if (voltage ==VOLTAGE_INFO_0_85V ) { + *n_entries =ARRAY_SIZE (cnl_ddi_translations_dp_0_85V); +return cnl_ddi_translations_dp_0_85V; + }else if (voltage ==VOLTAGE_INFO_0_95V ) { + *n_entries =ARRAY_SIZE (cnl_ddi_translations_dp_0_95V); +return cnl_ddi_translations_dp_0_95V; + }else if (voltage ==VOLTAGE_INFO_1_05V ) { + *n_entries =ARRAY_SIZE (cnl_ddi_translations_dp_1_05V); +return cnl_ddi_translations_dp_1_05V; + }else +MISSING_CASE (voltage); +return NULL ; +} + +static const struct cnl_ddi_buf_trans * +cnl_get_buf_trans_edp (struct drm_i915_private *dev_priv,int *n_entries) +{ +u32 voltage =I915_READ (CNL_PORT_COMP_DW3 ) &VOLTAGE_INFO_MASK ; + +if (dev_priv->vbt.edp.low_vswing) { +if (voltage ==VOLTAGE_INFO_0_85V ) { + *n_entries =ARRAY_SIZE (cnl_ddi_translations_edp_0_85V); +return cnl_ddi_translations_dp_0_85V; + }else if (voltage ==VOLTAGE_INFO_0_95V ) { + *n_entries =ARRAY_SIZE (cnl_ddi_translations_edp_0_95V); +return cnl_ddi_translations_edp_0_95V; + }else if (voltage ==VOLTAGE_INFO_1_05V ) { + *n_entries =ARRAY_SIZE (cnl_ddi_translations_edp_1_05V); +return cnl_ddi_translations_edp_1_05V; + }else +MISSING_CASE (voltage); +return NULL ; + }else { +return cnl_get_buf_trans_dp (dev_priv, n_entries); + } +} +static int intel_ddi_hdmi_level (struct drm_i915_private *dev_priv,enum port port) {int n_hdmi_entries;
@@ -1829,67 +1890,6 @@ u8 intel_ddi_dp_voltage_max(struct intel_encoder *encoder)DP_TRAIN_VOLTAGE_SWING_MASK ; } -static const struct cnl_ddi_buf_trans * -cnl_get_buf_trans_hdmi (struct drm_i915_private *dev_priv,int *n_entries) -{ -u32 voltage =I915_READ (CNL_PORT_COMP_DW3 ) &VOLTAGE_INFO_MASK ; - -if (voltage ==VOLTAGE_INFO_0_85V ) { - *n_entries =ARRAY_SIZE (cnl_ddi_translations_hdmi_0_85V); -return cnl_ddi_translations_hdmi_0_85V; - }else if (voltage ==VOLTAGE_INFO_0_95V ) { - *n_entries =ARRAY_SIZE (cnl_ddi_translations_hdmi_0_95V); -return cnl_ddi_translations_hdmi_0_95V; - }else if (voltage ==VOLTAGE_INFO_1_05V ) { - *n_entries =ARRAY_SIZE (cnl_ddi_translations_hdmi_1_05V); -return cnl_ddi_translations_hdmi_1_05V; - }else -MISSING_CASE (voltage); -return NULL ; -} - -static const struct cnl_ddi_buf_trans * -cnl_get_buf_trans_dp (struct drm_i915_private *dev_priv,int *n_entries) -{ -u32 voltage =I915_READ (CNL_PORT_COMP_DW3 ) &VOLTAGE_INFO_MASK ; - -if (voltage ==VOLTAGE_INFO_0_85V ) { - *n_entries =ARRAY_SIZE (cnl_ddi_translations_dp_0_85V); -return cnl_ddi_translations_dp_0_85V; - }else if (voltage ==VOLTAGE_INFO_0_95V ) { - *n_entries =ARRAY_SIZE (cnl_ddi_translations_dp_0_95V); -return cnl_ddi_translations_dp_0_95V; - }else if (voltage ==VOLTAGE_INFO_1_05V ) { - *n_entries =ARRAY_SIZE (cnl_ddi_translations_dp_1_05V); -return cnl_ddi_translations_dp_1_05V; - }else -MISSING_CASE (voltage); -return NULL ; -} - -static const struct cnl_ddi_buf_trans * -cnl_get_buf_trans_edp (struct drm_i915_private *dev_priv,int *n_entries) -{ -u32 voltage =I915_READ (CNL_PORT_COMP_DW3 ) &VOLTAGE_INFO_MASK ; - -if (dev_priv->vbt.edp.low_vswing) { -if (voltage ==VOLTAGE_INFO_0_85V ) { - *n_entries =ARRAY_SIZE (cnl_ddi_translations_edp_0_85V); -return cnl_ddi_translations_dp_0_85V; - }else if (voltage ==VOLTAGE_INFO_0_95V ) { - *n_entries =ARRAY_SIZE (cnl_ddi_translations_edp_0_95V); -return cnl_ddi_translations_edp_0_95V; - }else if (voltage ==VOLTAGE_INFO_1_05V ) { - *n_entries =ARRAY_SIZE (cnl_ddi_translations_edp_1_05V); -return cnl_ddi_translations_edp_1_05V; - }else -MISSING_CASE (voltage); -return NULL ; - }else { -return cnl_get_buf_trans_dp (dev_priv, n_entries); - } -} -static void cnl_ddi_vswing_program (struct drm_i915_private *dev_priv,u32 level,enum port port,int type) {
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerPATCH 5/6 drm/i915/cnl: Fix DDI hdmi level selection.
In reply to Rodrigo ViviLet's get a proper HDMI DDI entry level for vswing programming sequences on CNL.
Spec doesn't specify any default for HDMI tables, so let's pick the last entry as the default for now.
--- drivers/gpu/drm/i915/intel_ddi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_ddi.c +4 -1
@@ -660,7 +660,10 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port porif (IS_GEN9_LP (dev_priv))return hdmi_level; -if (IS_GEN9_BC (dev_priv)) { +if (IS_CANNONLAKE (dev_priv)) { +cnl_get_buf_trans_hdmi (dev_priv, &n_hdmi_entries); + hdmi_default_entry = n_hdmi_entries -1 ; + }else if (IS_GEN9_BC (dev_priv)) {skl_get_buf_trans_hdmi (dev_priv, &n_hdmi_entries); hdmi_default_entry =8 ; }else if (IS_BROADWELL (dev_priv)) {
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerPATCH 6/6 drm/i915/cnl: Fix DP max voltage
In reply to Rodrigo ViviOn clock recovery this function is called to find out the max voltage swing level that we could go.
However gen 9 functions use the old buffer translation tables to figure that out. That table is not valid for CNL causing an invalid number of entries and an invalid selection on the max voltage swing level.
v2: Let's use same approach that previous platforms.
--- drivers/gpu/drm/i915/intel_ddi.c | 35 +++++++++++++++++++++++++++++++---- 1 file changed, 31 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +31 -4
@@ -649,6 +649,29 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv, int *n_entries) } } +static int cnl_max_level (struct drm_i915_private *dev_priv, +enum intel_output_type type) +{ +int n_entries =0 ; + +switch (type) { +case INTEL_OUTPUT_DP : +cnl_get_buf_trans_dp (dev_priv, &n_entries); +break ; +case INTEL_OUTPUT_EDP : +cnl_get_buf_trans_edp (dev_priv, &n_entries); +break ; +case INTEL_OUTPUT_HDMI : +cnl_get_buf_trans_hdmi (dev_priv, &n_entries); +break ; +default : +MISSING_CASE (type); +return 0 ; + } + +return n_entries -1 ; +} +static int intel_ddi_hdmi_level (struct drm_i915_private *dev_priv,enum port port) {int n_hdmi_entries;
@@ -1879,10 +1902,14 @@ u8 intel_ddi_dp_voltage_max(struct intel_encoder *encoder)struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);int n_entries; -if (encoder->type ==INTEL_OUTPUT_EDP ) -intel_ddi_get_buf_trans_edp (dev_priv, &n_entries); -else -intel_ddi_get_buf_trans_dp (dev_priv, &n_entries); +if (IS_CANNONLAKE (dev_priv)) { +cnl_max_level (dev_priv, encoder->type); + }else { +if (encoder->type ==INTEL_OUTPUT_EDP ) +intel_ddi_get_buf_trans_edp (dev_priv, &n_entries); +else +intel_ddi_get_buf_trans_dp (dev_priv, &n_entries); + }if (WARN_ON (n_entries <1 )) n_entries =1 ;
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Introduce intel_ddi_dp_level.
In reply to Rodrigo Vivi== Series Details ==
== Series Details ==
Series: series starting with [1/6] drm/i915: Introduce intel_ddi_dp_level.
URL : https://patchwork.freedesktop.org/series/28499/
State : success
== Summary ==
Series 28499v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/28499/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
pass -> FAIL (fi-snb-2600) fdo#100007fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:436s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:422s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:356s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:494s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:503s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:521s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:511s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:583s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:427s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:406s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:417s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:501s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:480s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:459s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:568s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:579s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:524s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:448s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:645s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:467s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:426s fi-skl-x1585l total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:488s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:547s fi-snb-2600 total:279 pass:249 dwarn:0 dfail:0 fail:1 skip:29 time:411s
b7a69d408ccdcc8d4976baa3fc4b6dcdc5c21c8b drm-tip: 2017y-08m-08d-13h-56m-35s UTC integration manifest f45c43823f65 drm/i915/cnl: Fix DP max voltage81a935cee04c drm/i915/cnl: Fix DDI hdmi level selection.62bd6a4f6c5c drm/i915/cnl: Move ddi buf trans related functions up.993326e1212f drm/i915/cnl: Move voltage check into ddi buf trans functions. 6027699cafe7 drm/i915: Align vswing sequences with old ddi buffer registers. af03eefc23ab drm/i915: Introduce intel_ddi_dp_level.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5342/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 1 line · Rodrigo Vivi
+static
uint32_tintel_ddi_dp_level(struct intel_dp *intel_dp)
Sorry to pick on specifically this patch when there continue to be offenders all over the place... but shouldn't we prefer the kernel types over standard C types? Not that checkpatch is an authority here, but with --strict it complains about using e.g. uint32_t.
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Vivi, Rodrigo
maintainerQuoted 5 lines · Jani Nikula
Quoted 1 line · Rodrigo Vivi
+static
uint32_tintel_ddi_dp_level(struct intel_dp *intel_dp)Sorry to pick on specifically this patch when there continue to be offenders all over the place...
don't be sorry.
I'm glad that you spotted this ;)
I'm always confused about this and try to get the closest one, although I prefer the linux style u32.
Quoted 3 lines
but shouldn't we prefer the kernel types
over standard C types? Not that checkpatch is an authority here, but with --strict it complains about using e.g.uint32_t.
I went to
https://www.kernel.org/doc/html/v4.10/process/coding-style.html
"""
d. New types which are identical to standard C99 types, in certain exceptional circumstances.
Although it would only take a short amount of time for the eyes and brain to become accustomed to the standard types like uint32_t, some people object to their use anyway.
Therefore, the Linux-specific u8/u16/u32/u64 types and their signed equivalents which are identical to standard types are permitted – although they are not mandatory in new code of your own.
When editing existing code which already uses one or the other set of types, you should conform to the existing choices in that code. """
I wonder if we should do a one time replace in all our code and start accepting only one to avoid confusion.
Quoted 5 lines
BR,
Jani.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx