drm/vc4: Fix leak of HDMI EDID
Subsystems (3)
PATCH 1/1 drm/vc4: Fix leak of HDMI EDID
We don't keep a pointer to it around anywhere, so it's our job to free it.
Cc Stefan Wahren <[email protected]>
Fixes c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
Signed-off-by Eric Anholt <[email protected]>
--- drivers/gpu/drm/vc4/vc4_hdmi.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/vc4/vc4_hdmi.c +1 -0
@@ -288,6 +288,7 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)drm_mode_connector_update_edid_property (connector, edid); ret =drm_add_edid_modes (connector, edid);drm_edid_to_eld (connector, edid); +kfree (edid);return ret; }
Signature · 6 lines
2.13.3 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Eric Anholt
We don't keep a pointer to it around anywhere, so it's our job to free it.
Cc Stefan Wahren <[email protected]>Fixes c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")Signed-off-by Eric Anholt <[email protected]>
Reviewed-by Daniel Vetter <[email protected]>
Quoted 23 lines
--- drivers/gpu/drm/vc4/vc4_hdmi.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/vc4/vc4_hdmi.c +1
-0@@ -288,6 +288,7 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)drm_mode_connector_update_edid_property (connector, edid); ret =drm_add_edid_modes (connector, edid);drm_edid_to_eld (connector, edid); +kfree (edid);return ret; }Signature · 6 lines
2.13.3 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 9 lines · Daniel Vetter
Quoted 7 lines · Eric Anholt
We don't keep a pointer to it around anywhere, so it's our job to free it.
Cc Stefan Wahren <[email protected]>Fixes c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")Signed-off-by Eric Anholt <[email protected]>Reviewed-by Daniel Vetter <[email protected]>
Pushed. Thanks!
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 10 lines
Eric Anholt <[email protected]> hat am 8. August 2017 um 22:56 geschrieben:
We don't keep a pointer to it around anywhere, so it's our job to free it.
Cc Stefan Wahren <[email protected]>Fixes c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")Signed-off-by Eric Anholt <[email protected]>
Tested-by Stefan Wahren <[email protected]>