PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe()
PATCH 1/1 PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe()
platform_get_irq() returns an error code, but the pci-dra7xx driver ignores it and always returns -EINVAL. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.
Print and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
--- drivers/pci/dwc/pci-dra7xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/dwc/pci-dra7xx.c +2 -2
@@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (dev,"missing IRQ resource\n" ); -return -EINVAL ; +dev_err (dev,"missing IRQ resource: %d\n" , irq); +return irq; } res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"ti_conf" );
Signature · 1 line
2.5.0
Quoted 9 lines · Gustavo A. R. Silva
platform_get_irq()returns an error code, but the pci-dra7xx driver ignores it and always returns-EINVAL. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.Print and propagate the return value of
platform_get_irqon failure.This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Quoted 20 lines
--- drivers/pci/dwc/pci-dra7xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/pci/dwc/pci-dra7xx.c +2
-2@@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (dev,"missing IRQ resource\n" ); -return -EINVAL ; +dev_err (dev,"missing IRQ resource: %d\n" , irq); +return irq; } res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"ti_conf" );
Quoted 9 lines · Gustavo A. R. Silva
platform_get_irq()returns an error code, but the pci-dra7xx driver ignores it and always returns-EINVAL. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.Print and propagate the return value of
platform_get_irqon failure.This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied with Kishon's ack to pci/host-dra7xx for v4.14, thanks!
Quoted 22 lines
--- drivers/pci/dwc/pci-dra7xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/pci/dwc/pci-dra7xx.c +2
-2@@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (dev,"missing IRQ resource\n" ); -return -EINVAL ; +dev_err (dev,"missing IRQ resource: %d\n" , irq); +return irq; } res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"ti_conf" );Signature · 1 line
2.5.0
Hi Bjorn,
Quoted 5 lines · Bjorn Helgaas
Quoted 4 lines · Gustavo A. R. Silva
platform_get_irq()returns an error code, but the pci-dra7xx driver ignores it and always returns-EINVAL. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.
Quoted 8 lines
Quoted 5 lines
Print and propagate the return value of
platform_get_irqon failure.This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>Applied with Kishon's ack to pci/host-dra7xx for v4.14, thanks!
Glad to help. :)
Quoted 22 lines
Quoted 22 lines
--- drivers/pci/dwc/pci-dra7xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/pci/dwc/pci-dra7xx.c +2
-3@@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (dev,"missing IRQ resource\n" ); -return -EINVAL ; +dev_err (dev,"missing IRQ resource: %d\n" , irq); +return irq; } res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"ti_conf" ); --2.5.0
Signature · 1 line
Gustavo A. R. Silva