Skip to contentSkip to conversation

auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM

PATCH In review Thomas Meyer 3 participants 4 messages Aug 10, 2017 – Nov 27, 2017 Auxiliary display drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM

This avoids the MODPOST error:
ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] undefined!

---
 drivers/auxdisplay/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/auxdisplay/Kconfig +1 -0
index 9ae6681c90ad..9088c66e4c08 100644
@@ -135,6 +135,7 @@ config CFAG12864B_RATE
 
 config IMG_ASCII_LCD
 	tristate "Imagination Technologies ASCII LCD Display"
+	depends on HAS_IOMEM
 	default y if MIPS_MALTA || MIPS_SEAD3
 	select SYSCON
 	help
Signature · 1 line
2.13.3
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Thomas Meyer

This avoids the MODPOST error:
ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] undefined!

---
 drivers/auxdisplay/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/auxdisplay/Kconfig +0 -0
index 9ae6681c90ad..9088c66e4c08 100644

drivers/auxdisplay/Kconfig config CFAG12864B_RATE · line 141

Quoted 7 lines
drivers/auxdisplay/Kconfig +1 -0
@@ -135,6 +135,7 @@ config CFAG12864B_RATE
 
 config IMG_ASCII_LCD
 	tristate "Imagination Technologies ASCII LCD Display"
+	depends on HAS_IOMEM
 	default y if MIPS_MALTA || MIPS_SEAD3
 	select SYSCON
 	help

I posted the same patch on 2017-JAN-01, so I agree with it.

https://lkml.org/lkml/2017/1/1/87

Signature · 1 line
~Randy
#2 lore raw
Quoted 25 lines · Randy Dunlap
Quoted 14 lines · Thomas Meyer

This avoids the MODPOST error:
ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] undefined!

---
 drivers/auxdisplay/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/auxdisplay/Kconfig +0 -0
index 9ae6681c90ad..9088c66e4c08 100644

drivers/auxdisplay/Kconfig config CFAG12864B_RATE · line 141

Quoted 7 lines
drivers/auxdisplay/Kconfig +1 -0
@@ -135,6 +135,7 @@ config CFAG12864B_RATE
 
 config IMG_ASCII_LCD
 	tristate "Imagination Technologies ASCII LCD Display"
+	depends on HAS_IOMEM
 	default y if MIPS_MALTA || MIPS_SEAD3
 	select SYSCON
 	help

I posted the same patch on 2017-JAN-01, so I agree with it.

Quoted 3 lines

https://lkml.org/lkml/2017/1/1/87

No response from the maintainer yet. I think this driver is actually unmaintained. What to do now?

Quoted 3 lines
Signature · 2 lines
-- 
~Randy
#3 lore raw
Quoted 3 lines · Thomas Meyer

No response from the maintainer yet. I think this driver is actually unmaintained. What to do now?

Applied directly.

Linus