tests/kms_mmap_write_crc: Add drmModeDirtyFB after dirtying fb
PATCH 1/1 tests/kms_mmap_write_crc: Add drmModeDirtyFB after dirtying fb
The test shows the need for coherency through the dma-buf sync ioctl's, but forgets to call dirtyfb, without this the FB Is never updated and we will fail anyway.
Solve this by adding a drmModeDirtyFB, I've confirmed by adding -n that the test will still faill without prime_sync_end anyway, so the test is still useful.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101109
--- tests/kms_mmap_write_crc.c | 2 ++ 1 file changed, 2 insertions(+)
tests/kms_mmap_write_crc.c +2 -0
@@ -156,6 +156,8 @@ static void test(data_t *data)if (ioctl_sync)prime_sync_end (dma_buf_fd, true); +do_or_die (drmModeDirtyFB (data->drm_fd, fb->fb_id,NULL ,0 )); +/* check that the crc is as expected, which requires that caches got flushed */ igt_pipe_crc_collect_crc (data->pipe_crc, &crc);igt_assert_crc_equal (&crc, &data->ref_crc);
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: warning for tests/kms_mmap_write_crc: Add drmModeDirtyFB after dirtying fb
== Series Details ==
== Series Details ==
Series: tests/kms_mmap_write_crc: Add drmModeDirtyFB after dirtying fb
URL : https://patchwork.freedesktop.org/series/28624/
State : warning
== Summary ==
IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic.
with latest DRM-Tip kernel build CI_DRM_29440f3edcc5d407 drm-tip: 2017y-08m-10d-11h-21m-35s UTC integration manifest
Test gem_exec_suspend:
Subgroup basic-s3:
pass -> DMESG-WARN (fi-kbl-7560u)
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
fail -> PASS (fi-snb-2600) fdo#100215 +1
Test kms_flip:
Subgroup basic-flip-vs-modeset:
skip -> PASS (fi-skl-x1585l) fdo#101781fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:437s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:417s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:357s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:503s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:486s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:520s fi-byt-n2820 total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:516s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:583s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:441s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:407s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:419s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:515s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:478s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:457s fi-kbl-7560u total:279 pass:268 dwarn:1 dfail:0 fail:0 skip:10 time:570s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:577s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:519s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:454s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:643s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:464s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:428s fi-skl-x1585l total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:491s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:551s fi-snb-2600 total:279 pass:249 dwarn:0 dfail:0 fail:1 skip:29 time:406s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_53/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Maarten Lankhorst (2017-08-10 13:41:56)
Quoted 11 lines
The test shows the need for coherency through the dma-buf sync ioctl's, but forgets to call dirtyfb, without this the FB Is never updated and we will fail anyway.
Solve this by adding a drmModeDirtyFB, I've confirmed by adding -n that the test will still faill without
prime_sync_endanyway, so the test is still useful.Signed-off-by Maarten Lankhorst <[email protected]>Cc Marta Löfstedt <[email protected]>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101109
Have a patch for the failure in the first check, yet more object coherency mess.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 39 lines
-----Original Message-----
From: Maarten Lankhorst [mailto:[email protected]]
Sent: Thursday, August 10, 2017 3:42 PM
To: [email protected]
Cc: Maarten Lankhorst <[email protected]>; Lofstedt, Marta <[email protected]>
Subject: [PATCH i-g-t] tests/kms_mmap_write_crc: Add drmModeDirtyFB after dirtying fbThe test shows the need for coherency through the dma-buf sync ioctl's, but forgets to call dirtyfb, without this the FB Is never updated and we will fail anyway.
Solve this by adding a drmModeDirtyFB, I've confirmed by adding -n that the test will still faill without
prime_sync_endanyway, so the test is still useful.Signed-off-by Maarten Lankhorst <[email protected]>Cc Marta Löfstedt <[email protected]>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101109
--- tests/kms_mmap_write_crc.c | 2 ++ 1 file changed, 2 insertions(+)tests/kms_mmap_write_crc.c +2
-0@@ -156,6 +156,8 @@ static void test(data_t *data)if (ioctl_sync)prime_sync_end (dma_buf_fd, true); +do_or_die (drmModeDirtyFB (data->drm_fd, fb->fb_id,NULL ,0 )); +/* check that the crc is as expected, which requires that caches got flushed */
tests/kms_mmap_write_crc.c +0
-1igt_pipe_crc_collect_crc (data->pipe_crc, &crc);igt_assert_crc_equal (&crc, &data->ref_crc); --
Quoted 1 line
2.11.0
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx