Skip to contentSkip to conversation

uapi/linux/quota.h: Do not include linux/errno.h

PATCH In review Florian Weimer 2 participants 2 messages Aug 11, 2017 – Aug 14, 2017

Subsystems (2)
VFS Diskquota
lore
Share & tools
lore

Florian Weimer

author
#0 lore raw

PATCH 1/1 uapi/linux/quota.h: Do not include linux/errno.h

linux/errno.h is very sensitive to coordination with libc headers. Nothing in linux/quota.h needs it, so this change allows using this header in more contexts.

Signed-off-by Florian Weimer <[email protected]>
---
 include/uapi/linux/quota.h | 1 -
 1 file changed, 1 deletion(-)
include/uapi/linux/quota.h +0 -1
index 4d2489ef6f10..f17c9636a859 100644
@@ -33,7 +33,6 @@
 #ifndef _UAPI_LINUX_QUOTA_
 #define _UAPI_LINUX_QUOTA_
 
-#include <linux/errno.h>
 #include <linux/types.h>
 
 #define __DQUOT_VERSION__	"dquot_6.6.0"
Signature · 1 line
2.13.4
reviewer
#1 lore raw
Quoted 5 lines · Florian Weimer

linux/errno.h is very sensitive to coordination with libc headers. Nothing in linux/quota.h needs it, so this change allows using this header in more contexts.

Signed-off-by Florian Weimer <[email protected]>

Thanks! Added to my tree.

Honza

Quoted 20 lines
---
 include/uapi/linux/quota.h | 1 -
 1 file changed, 1 deletion(-)
include/uapi/linux/quota.h +0 -1
index 4d2489ef6f10..f17c9636a859 100644
@@ -33,7 +33,6 @@
 #ifndef _UAPI_LINUX_QUOTA_
 #define _UAPI_LINUX_QUOTA_
 
-#include <linux/errno.h>
 #include <linux/types.h>
 
 #define __DQUOT_VERSION__	"dquot_6.6.0"
Signature · 1 line
2.13.4
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR