Skip to contentSkip to conversation

fs: fat: fix fatwrite overflow calculation

PATCH In review Reno Farnesi 2 participants 2 messages Aug 13, 2017 – Aug 26, 2017 VFAT/FAT/msdos filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: fat: fix fatwrite overflow calculation

The overflow calculation was incorrect. Adding the start block of the partition is not needed because the sectors are already relative to the beginning of the partition. If you attempted to write a file smaller than cur_part_info.start blocks on a full partition the old calculation fails to catch the overflow. This would cause an infinite loop in the determine_fatent function.

Old, incorrect calculation:

ending sector of new file = start sector + file size (in sectors) last sector = partition start + total sectors on the partition

Adding the partition start block number is not needed because sectors are already relative to the start of the partition.

New calculation:

ending sector of new file = start sector + file size (in sectors) last sector = total sectors on the partition

---

 fs/fat/fat_write.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fat/fat_write.c +1 -1
index f6f06289f4..4ca024c208 100644
@@ -762,7 +762,7 @@ static int check_overflow(fsdata *mydata, __u32 clustnum, loff_t size)
 	if (offset != 0)
 		sect_num++;
 
-	if (startsect + sect_num > cur_part_info.start + total_sector)
+	if (startsect + sect_num > total_sector)
 		return -1;
 	return 0;
 }
Signature · 1 line
2.13.3
#1 lore raw
Quoted 15 lines · Reno Farnesi

The overflow calculation was incorrect. Adding the start block of the partition is not needed because the sectors are already relative to the beginning of the partition. If you attempted to write a file smaller than cur_part_info.start blocks on a full partition the old calculation fails to catch the overflow. This would cause an infinite loop in the determine_fatent function.

Old, incorrect calculation:

ending sector of new file = start sector + file size (in sectors) last sector = partition start + total sectors on the partition

Adding the partition start block number is not needed because sectors are already relative to the start of the partition.

Quoted 6 lines

New calculation:

ending sector of new file = start sector + file size (in sectors) last sector = total sectors on the partition

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170826/2d3b263d/attachment.sig>