drm/i915: Work around GCC anonymous union initialization bug
PATCH 1/2 drm/i915: Work around GCC anonymous union initialization bug
GCC 4.4 can't cope with anonymous union initializers which seems to be a bug in that version (see the Reference) and is fixed since GCC version 4.6. A workaround which is also used elsewhere in the kernel for the same purpose is to wrap the initialization in curly braces, so do the same here.
Reference: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676
--- drivers/gpu/drm/i915/intel_runtime_pm.c | 78 +++++++++++++++++++++++---------- 1 file changed, 54 insertions(+), 24 deletions(-)
drivers/gpu/drm/i915/intel_runtime_pm.c +54 -24
@@ -1920,7 +1920,9 @@ static struct i915_power_well hsw_power_wells[] = { .domains = HSW_DISPLAY_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = HSW_DISP_PW_GLOBAL, - .hsw.has_vga = true, + { + .hsw.has_vga = true, + }, }, };
@@ -1937,8 +1939,10 @@ static struct i915_power_well bdw_power_wells[] = { .domains = BDW_DISPLAY_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = HSW_DISP_PW_GLOBAL, - .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), - .hsw.has_vga = true, + { + .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), + .hsw.has_vga = true, + }, }, };
@@ -2080,7 +2084,9 @@ static struct i915_power_well skl_power_wells[] = { .domains = 0, .ops = &hsw_power_well_ops, .id = SKL_DISP_PW_1, - .hsw.has_fuses = true, + { + .hsw.has_fuses = true, + }, }, { .name = "MISC IO power well",
@@ -2100,9 +2106,11 @@ static struct i915_power_well skl_power_wells[] = { .domains = SKL_DISPLAY_POWERWELL_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = SKL_DISP_PW_2, - .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), - .hsw.has_vga = true, - .hsw.has_fuses = true, + { + .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), + .hsw.has_vga = true, + .hsw.has_fuses = true, + }, }, { .name = "DDI A/E IO power well",
@@ -2143,7 +2151,9 @@ static struct i915_power_well bxt_power_wells[] = { .domains = 0, .ops = &hsw_power_well_ops, .id = SKL_DISP_PW_1, - .hsw.has_fuses = true, + { + .hsw.has_fuses = true, + }, }, { .name = "DC off",
@@ -2156,23 +2166,29 @@ static struct i915_power_well bxt_power_wells[] = { .domains = BXT_DISPLAY_POWERWELL_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = SKL_DISP_PW_2, - .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), - .hsw.has_vga = true, - .hsw.has_fuses = true, + { + .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), + .hsw.has_vga = true, + .hsw.has_fuses = true, + }, }, { .name = "dpio-common-a", .domains = BXT_DPIO_CMN_A_POWER_DOMAINS, .ops = &bxt_dpio_cmn_power_well_ops, .id = BXT_DPIO_CMN_A, - .bxt.phy = DPIO_PHY1, + { + .bxt.phy = DPIO_PHY1, + }, }, { .name = "dpio-common-bc", .domains = BXT_DPIO_CMN_BC_POWER_DOMAINS, .ops = &bxt_dpio_cmn_power_well_ops, .id = BXT_DPIO_CMN_BC, - .bxt.phy = DPIO_PHY0, + { + .bxt.phy = DPIO_PHY0, + }, }, };
@@ -2190,7 +2206,9 @@ static struct i915_power_well glk_power_wells[] = { .domains = 0, .ops = &hsw_power_well_ops, .id = SKL_DISP_PW_1, - .hsw.has_fuses = true, + { + .hsw.has_fuses = true, + }, }, { .name = "DC off",
@@ -2203,30 +2221,38 @@ static struct i915_power_well glk_power_wells[] = { .domains = GLK_DISPLAY_POWERWELL_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = SKL_DISP_PW_2, - .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), - .hsw.has_vga = true, - .hsw.has_fuses = true, + { + .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), + .hsw.has_vga = true, + .hsw.has_fuses = true, + }, }, { .name = "dpio-common-a", .domains = GLK_DPIO_CMN_A_POWER_DOMAINS, .ops = &bxt_dpio_cmn_power_well_ops, .id = BXT_DPIO_CMN_A, - .bxt.phy = DPIO_PHY1, + { + .bxt.phy = DPIO_PHY1, + }, }, { .name = "dpio-common-b", .domains = GLK_DPIO_CMN_B_POWER_DOMAINS, .ops = &bxt_dpio_cmn_power_well_ops, .id = BXT_DPIO_CMN_BC, - .bxt.phy = DPIO_PHY0, + { + .bxt.phy = DPIO_PHY0, + }, }, { .name = "dpio-common-c", .domains = GLK_DPIO_CMN_C_POWER_DOMAINS, .ops = &bxt_dpio_cmn_power_well_ops, .id = GLK_DPIO_CMN_C, - .bxt.phy = DPIO_PHY2, + { + .bxt.phy = DPIO_PHY2, + }, }, { .name = "AUX A",
@@ -2280,7 +2306,9 @@ static struct i915_power_well cnl_power_wells[] = { .domains = 0, .ops = &hsw_power_well_ops, .id = SKL_DISP_PW_1, - .hsw.has_fuses = true, + { + .hsw.has_fuses = true, + }, }, { .name = "AUX A",
@@ -2317,9 +2345,11 @@ static struct i915_power_well cnl_power_wells[] = { .domains = CNL_DISPLAY_POWERWELL_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = SKL_DISP_PW_2, - .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), - .hsw.has_vga = true, - .hsw.has_fuses = true, + { + .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), + .hsw.has_vga = true, + .hsw.has_fuses = true, + }, }, { .name = "DDI A IO power well",
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 drm/i915/hsw+: Add support for multiple power well regs
Future platforms increase the number of power wells which require additional control registers. A convenient way to select the correct register is to use the high bits of the power well ID as index. This patch only prepares for this, while upcoming platform enabling patches will add the actual new power well IDs and corresponding power well control registers.
---
[ Added documentation for the layout of power well request and
status flags as requested by Rakshmi. ]
--- drivers/gpu/drm/i915/gvt/handlers.c | 19 ++++++++++------- drivers/gpu/drm/i915/i915_reg.h | 32 +++++++++++++++++++++------- drivers/gpu/drm/i915/intel_display.c | 6 ++++-- drivers/gpu/drm/i915/intel_runtime_pm.c | 37 ++++++++++++++++++--------------- 4 files changed, 61 insertions(+), 33 deletions(-)
drivers/gpu/drm/i915/gvt/handlers.c +12 -7
@@ -2244,10 +2244,14 @@ static int init_generic_mmio_info(struct intel_gvt *gvt)MMIO_D (GEN6_RC6p_THRESHOLD,D_ALL );MMIO_D (GEN6_RC6pp_THRESHOLD,D_ALL );MMIO_D (GEN6_PMINTRMSK ,D_ALL ); -MMIO_DH (HSW_PWR_WELL_BIOS ,D_BDW ,NULL , power_well_ctl_mmio_write); -MMIO_DH (HSW_PWR_WELL_DRIVER ,D_BDW ,NULL , power_well_ctl_mmio_write); -MMIO_DH (HSW_PWR_WELL_KVMR ,D_BDW ,NULL , power_well_ctl_mmio_write); -MMIO_DH (HSW_PWR_WELL_DEBUG ,D_BDW ,NULL , power_well_ctl_mmio_write); +/* Use an arbitrary power well controlled by the PWR_WELL_CTL register */ +MMIO_DH (HSW_PWR_WELL_CTL_BIOS (HSW_DISP_PW_GLOBAL ),D_BDW ,NULL , + power_well_ctl_mmio_write); +MMIO_DH (HSW_PWR_WELL_CTL_DRIVER (HSW_DISP_PW_GLOBAL ),D_BDW ,NULL , + power_well_ctl_mmio_write); +MMIO_DH (HSW_PWR_WELL_CTL_KVMR ,D_BDW ,NULL , power_well_ctl_mmio_write); +MMIO_DH (HSW_PWR_WELL_CTL_DEBUG (HSW_DISP_PW_GLOBAL ),D_BDW ,NULL , + power_well_ctl_mmio_write);MMIO_DH (HSW_PWR_WELL_CTL5 ,D_BDW ,NULL , power_well_ctl_mmio_write);MMIO_DH (HSW_PWR_WELL_CTL6 ,D_BDW ,NULL , power_well_ctl_mmio_write);
@@ -2638,9 +2642,10 @@ static int init_skl_mmio_info(struct intel_gvt *gvt)MMIO_F (_DPD_AUX_CH_CTL,6 *4 ,0 ,0 ,0 ,D_SKL_PLUS ,NULL , dp_aux_ch_ctl_mmio_write); -MMIO_D (HSW_PWR_WELL_BIOS ,D_SKL_PLUS ); -MMIO_DH (HSW_PWR_WELL_DRIVER ,D_SKL_PLUS ,NULL , - skl_power_well_ctl_write); +/* Use an arbitrary power well controlled by the PWR_WELL_CTL register */ +MMIO_D (HSW_PWR_WELL_CTL_BIOS (SKL_DISP_PW_MISC_IO ),D_SKL_PLUS ); +MMIO_DH (HSW_PWR_WELL_CTL_DRIVER (SKL_DISP_PW_MISC_IO ),D_SKL_PLUS ,NULL , + skl_power_well_ctl_write);MMIO_DH (GEN6_PCODE_MAILBOX ,D_SKL_PLUS ,NULL , mailbox_write);MMIO_D (0xa210 ,D_SKL_PLUS );
drivers/gpu/drm/i915/i915_reg.h +25 -7
@@ -1254,13 +1254,13 @@ enum i915_power_well_id {/* * HSW/BDW -* - HSW_PWR_WELL_DRIVER (status bit: id*2, req bit: id*2+1) +* - HSW_PWR_WELL_CTL_DRIVER(0) (status bit: id*2, req bit: id*2+1) */ HSW_DISP_PW_GLOBAL =15 ,/* * GEN9+ -* - HSW_PWR_WELL_DRIVER (status bit: id*2, req bit: id*2+1) +* - HSW_PWR_WELL_CTL_DRIVER(0) (status bit: id*2, req bit: id*2+1) */ SKL_DISP_PW_MISC_IO =0 , SKL_DISP_PW_DDI_A_E,
@@ -8189,11 +8189,29 @@ enum {#define SKL_AUD_CODEC_WAKE_SIGNAL (1 << 15)/* HSW Power Wells */ -#define HSW_PWR_WELL_BIOS _MMIO(0x45400)/* CTL1 */ -#define HSW_PWR_WELL_DRIVER _MMIO(0x45404)/* CTL2 */ -#define HSW_PWR_WELL_KVMR _MMIO(0x45408)/* CTL3 */ -#define HSW_PWR_WELL_DEBUG _MMIO(0x4540C)/* CTL4 */ -#define _HSW_PW_SHIFT (pw) ((pw) * 2) +#define _HSW_PWR_WELL_CTL1 0x45400 +#define _HSW_PWR_WELL_CTL2 0x45404 +#define _HSW_PWR_WELL_CTL3 0x45408 +#define _HSW_PWR_WELL_CTL4 0x4540C + +/* +* Each power well control register contains up to 16 (request, status) HW +* flag tuples. The register index and HW flag shift is determined by the +* power well ID (see i915_power_well_id). There are 4 possible sources of +* power well requests each source having its own set of control registers: +* BIOS, DRIVER, KVMR, DEBUG. +*/ +#define _HSW_PW_REG_IDX (pw) ((pw) >> 4) +#define _HSW_PW_SHIFT (pw) (((pw) & 0xf) * 2) +/* TODO: Add all PWR_WELL_CTL registers below for new platforms */ +#define HSW_PWR_WELL_CTL_BIOS (pw) _MMIO(_PICK(_HSW_PW_REG_IDX(pw), \ + _HSW_PWR_WELL_CTL1)) +#define HSW_PWR_WELL_CTL_DRIVER (pw) _MMIO(_PICK(_HSW_PW_REG_IDX(pw), \ + _HSW_PWR_WELL_CTL2)) +#define HSW_PWR_WELL_CTL_KVMR _MMIO(_HSW_PWR_WELL_CTL3) +#define HSW_PWR_WELL_CTL_DEBUG (pw) _MMIO(_PICK(_HSW_PW_REG_IDX(pw), \ + _HSW_PWR_WELL_CTL4)) +#define HSW_PWR_WELL_CTL_REQ (pw) (1 << (_HSW_PW_SHIFT(pw) + 1))#define HSW_PWR_WELL_CTL_STATE (pw) (1 << _HSW_PW_SHIFT(pw))#define HSW_PWR_WELL_CTL5 _MMIO(0x45410)
drivers/gpu/drm/i915/intel_display.c +4 -2
@@ -8768,7 +8768,8 @@ static void assert_can_disable_lcpll(struct drm_i915_private *dev_priv)I915_STATE_WARN (crtc->active,"CRTC for pipe %c enabled\n" ,pipe_name (crtc->pipe)); -I915_STATE_WARN (I915_READ (HSW_PWR_WELL_DRIVER ),"Power well on\n" ); +I915_STATE_WARN (I915_READ (HSW_PWR_WELL_CTL_DRIVER (HSW_DISP_PW_GLOBAL )), +"Display power well on\n" );I915_STATE_WARN (I915_READ (SPLL_CTL ) &SPLL_PLL_ENABLE ,"SPLL enabled\n" );I915_STATE_WARN (I915_READ (WRPLL_CTL (0 )) &WRPLL_PLL_ENABLE ,"WRPLL1 enabled\n" );I915_STATE_WARN (I915_READ (WRPLL_CTL (1 )) &WRPLL_PLL_ENABLE ,"WRPLL2 enabled\n" );
@@ -15309,7 +15310,8 @@ intel_display_capture_error_state(struct drm_i915_private *dev_priv)return NULL ;if (IS_HASWELL (dev_priv) ||IS_BROADWELL (dev_priv)) - error->power_well_driver =I915_READ (HSW_PWR_WELL_DRIVER ); + error->power_well_driver = +I915_READ (HSW_PWR_WELL_CTL_DRIVER (HSW_DISP_PW_GLOBAL ));for_each_pipe (dev_priv, i) { error->pipe[i].power_domain_on =
drivers/gpu/drm/i915/intel_runtime_pm.c +20 -17
@@ -307,7 +307,7 @@ static void hsw_wait_for_power_well_enable(struct drm_i915_private *dev_priv,/* Timeout for PW1:10 us, AUX:not specified, other PWs:20 us. */ WARN_ON (intel_wait_for_register (dev_priv, -HSW_PWR_WELL_DRIVER , +HSW_PWR_WELL_CTL_DRIVER (id),HSW_PWR_WELL_CTL_STATE (id),HSW_PWR_WELL_CTL_STATE (id),1 ));
@@ -319,10 +319,10 @@ static u32 hsw_power_well_requesters(struct drm_i915_private *dev_priv,u32 req_mask =HSW_PWR_WELL_CTL_REQ (id);u32 ret; - ret =I915_READ (HSW_PWR_WELL_BIOS ) & req_mask ?1 :0 ; - ret |=I915_READ (HSW_PWR_WELL_DRIVER ) & req_mask ?2 :0 ; - ret |=I915_READ (HSW_PWR_WELL_KVMR ) & req_mask ?4 :0 ; - ret |=I915_READ (HSW_PWR_WELL_DEBUG ) & req_mask ?8 :0 ; + ret =I915_READ (HSW_PWR_WELL_CTL_BIOS (id)) & req_mask ?1 :0 ; + ret |=I915_READ (HSW_PWR_WELL_CTL_DRIVER (id)) & req_mask ?2 :0 ; + ret |=I915_READ (HSW_PWR_WELL_CTL_KVMR ) & req_mask ?4 :0 ; + ret |=I915_READ (HSW_PWR_WELL_CTL_DEBUG (id)) & req_mask ?8 :0 ;return ret; }
@@ -343,7 +343,7 @@ static void hsw_wait_for_power_well_disable(struct drm_i915_private *dev_priv,* Skip the wait in case any of the request bits are set and print a * diagnostic message. */ -wait_for ((disabled = !(I915_READ (HSW_PWR_WELL_DRIVER ) & +wait_for ((disabled = !(I915_READ (HSW_PWR_WELL_CTL_DRIVER (id)) &HSW_PWR_WELL_CTL_STATE (id))) || (reqs =hsw_power_well_requesters (dev_priv, id)),1 );if (disabled)
@@ -384,8 +384,8 @@ static void hsw_power_well_enable(struct drm_i915_private *dev_priv,gen9_wait_for_power_well_fuses (dev_priv,SKL_PG0 ); } - val =I915_READ (HSW_PWR_WELL_DRIVER ); -I915_WRITE (HSW_PWR_WELL_DRIVER , val |HSW_PWR_WELL_CTL_REQ (id)); + val =I915_READ (HSW_PWR_WELL_CTL_DRIVER (id)); +I915_WRITE (HSW_PWR_WELL_CTL_DRIVER (id), val |HSW_PWR_WELL_CTL_REQ (id));hsw_wait_for_power_well_enable (dev_priv, power_well);if (wait_fuses)
@@ -403,8 +403,9 @@ static void hsw_power_well_disable(struct drm_i915_private *dev_priv,hsw_power_well_pre_disable (dev_priv, power_well->hsw.irq_pipe_mask); - val =I915_READ (HSW_PWR_WELL_DRIVER ); -I915_WRITE (HSW_PWR_WELL_DRIVER , val & ~HSW_PWR_WELL_CTL_REQ (id)); + val =I915_READ (HSW_PWR_WELL_CTL_DRIVER (id)); +I915_WRITE (HSW_PWR_WELL_CTL_DRIVER (id), + val & ~HSW_PWR_WELL_CTL_REQ (id));hsw_wait_for_power_well_disable (dev_priv, power_well); }
@@ -419,17 +420,19 @@ static bool hsw_power_well_enabled(struct drm_i915_private *dev_priv,enum i915_power_well_id id = power_well->id;u32 mask =HSW_PWR_WELL_CTL_REQ (id) |HSW_PWR_WELL_CTL_STATE (id); -return (I915_READ (HSW_PWR_WELL_DRIVER ) & mask) == mask; +return (I915_READ (HSW_PWR_WELL_CTL_DRIVER (id)) & mask) == mask; }static void assert_can_enable_dc9 (struct drm_i915_private *dev_priv) { +enum i915_power_well_id id =SKL_DISP_PW_2 ; +WARN_ONCE ((I915_READ (DC_STATE_EN ) &DC_STATE_EN_DC9 ),"DC9 already programmed to be enabled.\n" );WARN_ONCE (I915_READ (DC_STATE_EN ) &DC_STATE_EN_UPTO_DC5 ,"DC5 still not disabled to enable DC9.\n" ); -WARN_ONCE (I915_READ (HSW_PWR_WELL_DRIVER ) & -HSW_PWR_WELL_CTL_REQ (SKL_DISP_PW_2 ), +WARN_ONCE (I915_READ (HSW_PWR_WELL_CTL_DRIVER (id)) & +HSW_PWR_WELL_CTL_REQ (id),"Power well 2 on.\n" );WARN_ONCE (intel_irqs_enabled (dev_priv),"Interrupts not disabled yet.\n" );
@@ -630,15 +633,15 @@ static void hsw_power_well_sync_hw(struct drm_i915_private *dev_priv, {enum i915_power_well_id id = power_well->id;u32 mask =HSW_PWR_WELL_CTL_REQ (id); -u32 bios_req =I915_READ (HSW_PWR_WELL_BIOS ); +u32 bios_req =I915_READ (HSW_PWR_WELL_CTL_BIOS (id));/* Take over the request bit if set by BIOS. */ if (bios_req & mask) { -u32 drv_req =I915_READ (HSW_PWR_WELL_DRIVER ); +u32 drv_req =I915_READ (HSW_PWR_WELL_CTL_DRIVER (id));if (!(drv_req & mask)) -I915_WRITE (HSW_PWR_WELL_DRIVER , drv_req | mask); -I915_WRITE (HSW_PWR_WELL_BIOS , bios_req & ~mask); +I915_WRITE (HSW_PWR_WELL_CTL_DRIVER (id), drv_req | mask); +I915_WRITE (HSW_PWR_WELL_CTL_BIOS (id), bios_req & ~mask); } }
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Work around GCC anonymous union initialization bug
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/i915: Work around GCC anonymous union initialization bug
URL : https://patchwork.freedesktop.org/series/28753/
State : failure
== Summary ==
Series 28753v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/28753/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705
Subgroup suspend-read-crc-pipe-c:
pass -> INCOMPLETE (fi-skl-6260u)fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:454s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:438s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:355s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:549s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:520s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:523s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:505s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:613s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:445s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:417s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:417s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:508s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:473s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:473s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:588s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:593s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:529s fi-skl-6260u total:238 pass:230 dwarn:0 dfail:0 fail:0 skip:7 fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:474s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:486s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:435s fi-skl-x1585l total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:504s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:547s fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:411s
432898f42ee40cd8f542ce4fe13b34f9457035d6 drm-tip: 2017y-08m-14d-14h-51m-47s UTC integration manifest 2d8c2e8a771f drm/i915/hsw+: Add support for multiple power well regs52ba57c18c22 drm/i915: Work around GCC anonymous union initialization bug
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5395/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Work around GCC anonymous union initialization bug
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/i915: Work around GCC anonymous union initialization bug
URL : https://patchwork.freedesktop.org/series/28753/
State : success
== Summary ==
Series 28753v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/28753/revisions/1/mbox/
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:447s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:438s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:361s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:544s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:512s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:523s fi-byt-n2820 total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:507s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:601s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:446s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:418s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:417s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:501s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:475s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:471s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:585s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:591s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:527s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:460s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:472s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:482s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:440s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:471s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:548s fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:408s
919fe89189f91de8ab10a4821ca88f10df24411d drm-tip: 2017y-08m-15d-08h-06m-07s UTC integration manifest 6d1d2dd0cd18 drm/i915/hsw+: Add support for multiple power well regs59d564190116 drm/i915: Work around GCC anonymous union initialization bug
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5400/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Work around GCC anonymous union initialization bug
Quoted 5 lines · Patchwork
== Series Details ==
Series: series starting with [1/2] drm/i915: Work around GCC anonymous union initialization bug
URL : https://patchwork.freedesktop.org/series/28753/
State : success
Thanks for the reviews, I pushed both patches to -dinq.
--Imre
Quoted 31 lines
== Summary ==
Series 28753v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/28753/revisions/1/mbox/fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:447s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:438s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:361s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:544s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:512s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:523s fi-byt-n2820 total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:507s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:601s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:446s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:418s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:417s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:501s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:475s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:471s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:585s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:591s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:527s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:460s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:472s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:482s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:440s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:471s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:548s fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:408s
Quoted 7 lines
919fe89189f91de8ab10a4821ca88f10df24411ddrm-tip: 2017y-08m-15d-08h-06m-07s UTC integration manifest6d1d2dd0cd18drm/i915/hsw+: Add support for multiple power well regs59d564190116drm/i915: Work around GCC anonymous union initialization bug== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5400/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Imre Deak (2017-08-14 16:15:29)
Quoted 11 lines
GCC 4.4 can't cope with anonymous union initializers which seems to be a bug in that version (see the Reference) and is fixed since GCC version 4.6. A workaround which is also used elsewhere in the kernel for the same purpose is to wrap the initialization in curly braces, so do the same here.
Fixes b5565a2efc12 ("drm/i915/bxt, glk: Give a proper name to the power well struct phy field")Reference: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676
Reported-by Fengguang Wu <[email protected]>Cc Arkadiusz Hiler <[email protected]>Signed-off-by Imre Deak <[email protected]>
Still waiting for when gcc-4.4 is dropped,
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx