Skip to contentSkip to conversation

drm/amdgpu: add mjpeg check for uvd phycial mode msg buffer

PATCH In review Leo Liu 5 participants 6 messages Aug 15, 2017 – Aug 16, 2017 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

Leo Liu

author
#0 lore raw

PATCH 1/1 drm/amdgpu: add mjpeg check for uvd phycial mode msg buffer

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +4 -0
index ff8ae50..b464f62 100644
@@ -588,6 +588,10 @@ static int amdgpu_uvd_cs_msg_decode(struct amdgpu_device *adev, uint32_t *msg,
 		}
 		break;
 
+	case 8: /* MJPEG */
+		min_dpb_size = 0;
+		break;
+
 	case 16: /* H265 */
 		image_size = (ALIGN(width, 16) * ALIGN(height, 16) * 3) / 2;
 		image_size = ALIGN(image_size, 256);
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by Alex Deucher
#2 lore raw
Quoted 10 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Leo Liu
Sent: Tuesday, August 15, 2017 4:13 PM
To: [email protected]
Cc: Liu, Leo
Subject: [PATCH] drm/amdgpu: add mjpeg check for uvd phycial mode msg buffer

We need to bump the driver version as well so userspace knows which versions of the kernel driver support this. Please send a patch to bump the driver version as well, with that addressed:

Quoted 24 lines
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +4 -0
index ff8ae50..b464f62 100644
@@ -588,6 +588,10 @@ static int amdgpu_uvd_cs_msg_decode(struct
 amdgpu_device *adev, uint32_t *msg,
 		}
 		break;
 
+	case 8: /* MJPEG */
+		min_dpb_size = 0;
+		break;
+
 	case 16: /* H265 */
 		image_size = (ALIGN(width, 16) * ALIGN(height, 16) * 3) / 2;

image_size = ALIGN(image_size, 256);
--
2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw
In reply to a message not in the archive
Quoted 1 line · Leo Liu

There's a typo ("phycial") in the shortlog, and acronyms should always be written in upper case. So it should probably be:

drm/amdgpu: Add MJPEG check for UVD physical mode msg buffer

Signature · 6 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): a26184b0-2b42-6b4a-e0e0-7d470b127260-otUistvHUpPR7s880joybQ@public.gmane.org

#5 lore raw

Am 16.08.2017 um 02:37 schrieb Michel Dänzer:

Quoted 6 lines · Leo Liu
Quoted 1 line

There's a typo ("phycial") in the shortlog, and acronyms should always be written in upper case. So it should probably be:

drm/amdgpu: Add MJPEG check for UVD physical mode msg buffer

With Michels and Alex comments addressed the patch is Reviewed-by: Christian König <[email protected]> as well.

Christian.

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

author
#6 lore raw

PATCH 1/1 drm/amdgpu: bump version for support of UVD MJPEG decode

In reply to a message not in the archive
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +2 -1
index d5c63d6c8fb3..0186bf49d5c2 100644
@@ -68,9 +68,10 @@
  * - 3.16.0 - Add reserved vmid support
  * - 3.17.0 - Add AMDGPU_NUM_VRAM_CPU_PAGE_FAULTS.
  * - 3.18.0 - Export gpu always on cu bitmap
+ * - 3.19.0 - Add support for UVD MJPEG decode
  */
 #define KMS_DRIVER_MAJOR	3
-#define KMS_DRIVER_MINOR	18
+#define KMS_DRIVER_MINOR	19
 #define KMS_DRIVER_PATCHLEVEL	0
 
 int amdgpu_vram_limit = 0;
Signature · 6 lines
2.11.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by
#8 lore raw

Re: [PATCH] drm/amdgpu: bump version for support of UVD MJPEG decode

Quoted 1 line · Leo Liu
Quoted 23 lines
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +2 -2
index d5c63d6c8fb3..0186bf49d5c2 100644
@@ -68,9 +68,10 @@
  * - 3.16.0 - Add reserved vmid support
  * - 3.17.0 - Add AMDGPU_NUM_VRAM_CPU_PAGE_FAULTS.
  * - 3.18.0 - Export gpu always on cu bitmap
+ * - 3.19.0 - Add support for UVD MJPEG decode
  */
 #define KMS_DRIVER_MAJOR       3
-#define KMS_DRIVER_MINOR       18
+#define KMS_DRIVER_MINOR       19
 #define KMS_DRIVER_PATCHLEVEL  0
 
 int amdgpu_vram_limit = 0;
--

2.11.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx