Skip to contentSkip to conversation

ARM: mvebu: set correct mem_size for db-88f6820-amc

PATCH New Chris Packham 2 participants 3 messages Aug 17, 2017 – Aug 21, 2017

lore
Share & tools
lore

Chris Packham

author
#0 lore raw

PATCH 1/1 ARM: mvebu: set correct mem_size for db-88f6820-amc

The db-88f6820-amc has four chips with 2Gb density giving a total of 1GB DRAM. Update the board_topology_map to reflect the correct configuration.

Signed-off-by Chris Packham <[email protected]>

---
When I setup this board I misinterpreted 2 Gigabits as 2 Gigabytes. It happened to work so I never noticed it was wrong until I started seeing some unexpected mirroring of addresses.

 board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/Marvell/db-88f6820-amc/db-88f6820-amc.c +1 -1
index 40fa59986573..ac58f9085266 100644
@@ -66,7 +66,7 @@ static struct hws_topology_map board_topology_map = {
 	      {0x1, 0, 0, 0} },
 	    SPEED_BIN_DDR_1866L,	/* speed_bin */
 	    BUS_WIDTH_8,		/* memory_width */
-	    MEM_4G,			/* mem_size */
+	    MEM_2G,			/* mem_size */
 	    DDR_FREQ_800,		/* frequency */
 	    0, 0,			/* cas_l cas_wl */
 	    HWS_TEMP_LOW,		/* temperature */
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 ARM: mvebu: set correct mem_size for db-88f6820-amc

Quoted 19 lines · Chris Packham

The db-88f6820-amc has four chips with 2Gb density giving a total of 1GB DRAM. Update the board_topology_map to reflect the correct configuration.

Signed-off-by Chris Packham <[email protected]>

---
When I setup this board I misinterpreted 2 Gigabits as 2 Gigabytes. It happened to work so I never noticed it was wrong until I started seeing some unexpected mirroring of addresses.

  board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
board/Marvell/db-88f6820-amc/db-88f6820-amc.c +0 -0
index 40fa59986573..ac58f9085266 100644

board/Marvell/db-88f6820-amc/db-88f6820-amc.c static struct hws_topology_map board_topology_map = { · line 72

Quoted 8 lines
board/Marvell/db-88f6820-amc/db-88f6820-amc.c +1 -1
@@ -66,7 +66,7 @@ static struct hws_topology_map board_topology_map = {
  	      {0x1, 0, 0, 0} },
  	    SPEED_BIN_DDR_1866L,	/* speed_bin */
  	    BUS_WIDTH_8,		/* memory_width */
-	    MEM_4G,			/* mem_size */
+	    MEM_2G,			/* mem_size */
  	    DDR_FREQ_800,		/* frequency */
  	    0, 0,			/* cas_l cas_wl */
  	    HWS_TEMP_LOW,		/* temperature */
Reviewed-by Stefan Roese <[email protected]>

Thanks,
Stefan

#2 lore raw

PATCH 1/1 ARM: mvebu: set correct mem_size for db-88f6820-amc

Quoted 23 lines · Stefan Roese
Quoted 22 lines · Chris Packham

The db-88f6820-amc has four chips with 2Gb density giving a total of 1GB DRAM. Update the board_topology_map to reflect the correct configuration.

Signed-off-by Chris Packham <[email protected]>

---
When I setup this board I misinterpreted 2 Gigabits as 2 Gigabytes. It happened to work so I never noticed it was wrong until I started seeing some unexpected mirroring of addresses.

  board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
board/Marvell/db-88f6820-amc/db-88f6820-amc.c +0 -0
index 40fa59986573..ac58f9085266 100644
@@ -66,7 +66,7 @@ static struct hws_topology_map board_topology_map = {
            {0x1, 0, 0, 0} },
          SPEED_BIN_DDR_1866L,    /* speed_bin */
          BUS_WIDTH_8,        /* memory_width */
Quoted 8 lines

board/Marvell/db-88f6820-amc/db-88f6820-amc.c static struct hws_topology_map board_topology_map = { · line 72

Quoted 6 lines
board/Marvell/db-88f6820-amc/db-88f6820-amc.c +1 -1
-        MEM_4G,            /* mem_size */
+        MEM_2G,            /* mem_size */
          DDR_FREQ_800,        /* frequency */
          0, 0,            /* cas_l cas_wl */
          HWS_TEMP_LOW,        /* temperature */
Reviewed-by Stefan Roese <[email protected]>

Applied to u-boot-marvell/master.

Thanks,
Stefan