drm/i915/bxt: use NULL for GPIO connection ID
Subsystems (2)
PATCH v2 1/1 drm/i915/bxt: use NULL for GPIO connection ID
The commit 213e08ad60ba
("drm/i915/bxt: add bxt dsi gpio element support")
enables GPIO support for Broxton based platforms.
While using that API we might get into troubles in the future, because we can't rely on label name in the driver since vendor firmware might provide any GPIO pin there, e.g. "reset", and even mark it in _DSD (in which case the request will fail).
To avoid inconsistency and potential issues we have two options:
a) generate GPIO ACPI mapping table and supply it via acpi_dev_add_driver_gpios(), or
b) just pass NULL as connection ID.
The b) approach is much simpler and would work since the driver relies on GPIO indices only. Moreover, the _CRS fallback mechanism, when requesting GPIO, has been made stricter, and supplying non-NULL connection ID when neither _DSD, nor GPIO ACPI mapping is present, is making request fail.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101921
---
v2:
- adjust commit message for proper time tenses
- add Fixes: and Bugzilla: tags
drivers/gpu/drm/i915/intel_dsi_vbt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dsi_vbt.c +1 -1
@@ -306,7 +306,7 @@ static void bxt_exec_gpio(struct drm_i915_private *dev_priv,if (!gpio_desc) { gpio_desc =devm_gpiod_get_index (dev_priv->drm.dev, -"panel" , gpio_index, +NULL , gpio_index, value ?GPIOD_OUT_LOW :GPIOD_OUT_HIGH );
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01)
Quoted 49 lines · Andy Shevchenko
The commit
213e08ad60ba
("drm/i915/bxt: add bxt dsi gpio element support")
enables GPIO support for Broxton based platforms.While using that API we might get into troubles in the future, because
we can't rely on label name in the driver since vendor firmware might provide any GPIO pin there, e.g. "reset", and even mark it in_DSD(in
which case the request will fail).To avoid inconsistency and potential issues we have two options:
a) generate GPIO ACPI mapping table and supply it viaacpi_dev_add_driver_gpios(), or
b) just pass NULL as connection ID.The b) approach is much simpler and would work since the driver relies
on GPIO indices only. Moreover, the_CRSfallback mechanism, when requesting GPIO, has been made stricter, and supplying non-NULL connection ID when neither_DSD, nor GPIO ACPI mapping is present, is making request fail.Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101921
Fixes f10e4bf6632b ("gpio: acpi: Even more tighten up ACPI GPIOlookups")
Cc Mika Kahola <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>---
v2:
- adjust commit message for proper time tenses
- add Fixes: and Bugzilla: tags
drivers/gpu/drm/i915/intel_dsi_vbt.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi_vbt.c +0
-0@@ -306,7 +306,7 @@ static void bxt_exec_gpio(struct drm_i915_private *dev_priv,
if (!gpio_desc) {
gpio_desc= devm_gpiod_get_index(dev_priv->drm.dev,drivers/gpu/drm/i915/intel_dsi_vbt.c +0
-1- "panel",
gpio_index,drivers/gpu/drm/i915/intel_dsi_vbt.c +1
-0+ NULL, gpio_index,
Quoted 4 lines
value ?
GPIOD_OUT_LOW:
GPIOD_OUT_HIGH);
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
Acked-byQuoted 3 lines · Mika Kahola
Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01)
Tested-by Mika Kahola <[email protected]>
Do we have a bxt system available for testing this? With that,
BR,
Jani.
Quoted 55 lines · Andy Shevchenko
Quoted 53 lines
The commit
213e08ad60ba
("drm/i915/bxt: add bxt dsi gpio element support")
enables GPIO support for Broxton based platforms.While using that API we might get into troubles in the future, because
we can't rely on label name in the driver since vendor firmware might provide any GPIO pin there, e.g. "reset", and even mark it in_DSD(in
which case the request will fail).To avoid inconsistency and potential issues we have two options:
a) generate GPIO ACPI mapping table and supply it viaacpi_dev_add_driver_gpios(), or
b) just pass NULL as connection ID.The b) approach is much simpler and would work since the driver relies
on GPIO indices only. Moreover, the_CRSfallback mechanism, when requesting GPIO, has been made stricter, and supplying non-NULL connection ID when neither_DSD, nor GPIO ACPI mapping is present, is making request fail.Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101921
Fixes f10e4bf6632b ("gpio: acpi: Even more tighten up ACPI GPIOlookups")
Cc Mika Kahola <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>---
v2:
- adjust commit message for proper time tenses
- add Fixes: and Bugzilla: tags
drivers/gpu/drm/i915/intel_dsi_vbt.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi_vbt.c +0
-0@@ -306,7 +306,7 @@ static void bxt_exec_gpio(struct drm_i915_private *dev_priv,
if (!gpio_desc) {
gpio_desc= devm_gpiod_get_index(dev_priv->drm.dev,drivers/gpu/drm/i915/intel_dsi_vbt.c +0
-1- "panel",
gpio_index,drivers/gpu/drm/i915/intel_dsi_vbt.c +1
-0+ NULL, gpio_index,value ?
GPIOD_OUT_LOW:
GPIOD_OUT_HIGH);
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 1 line · Mika Kahola
Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01)
Tested also with APL + MIPI/DSI setup.
Quoted 66 lines
Tested-by Mika Kahola <[email protected]>Quoted 54 lines · Andy Shevchenko
The commit
213e08ad60ba
("drm/i915/bxt: add bxt dsi gpio element support")
enables GPIO support for Broxton based platforms.While using that API we might get into troubles in the future, because
we can't rely on label name in the driver since vendor firmware might
provide any GPIO pin there, e.g. "reset", and even mark it in_DSD(in
which case the request will fail).To avoid inconsistency and potential issues we have two options:
a) generate GPIO ACPI mapping table and supply it viaacpi_dev_add_driver_gpios(), or
b) just pass NULL as connection ID.The b) approach is much simpler and would work since the driver relies
on GPIO indices only. Moreover, the_CRSfallback mechanism, when requesting GPIO, has been made stricter, and supplying non-NULL connection ID when neither_DSD, nor GPIO ACPI mapping is present, is
making request fail.Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101921
Fixes f10e4bf6632b ("gpio: acpi: Even more tighten up ACPI GPIOlookups")
Cc Mika Kahola <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>---
v2:
- adjust commit message for proper time tenses
- add Fixes: and Bugzilla: tags
drivers/gpu/drm/i915/intel_dsi_vbt.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi_vbt.c +0
-0@@ -306,7 +306,7 @@ static void bxt_exec_gpio(struct
drm_i915_private*dev_priv,
if (!gpio_desc) {
gpio_desc= devm_gpiod_get_index(dev_priv-Quoted 1 line
drm.dev,
drivers/gpu/drm/i915/intel_dsi_vbt.c +0
-1- "panel",
gpio_index,drivers/gpu/drm/i915/intel_dsi_vbt.c +1
-0+ NULL, gpio_index,Quoted 4 lines
value ?
GPIOD_OUT_LOW:
GPIOD_OUT_HIGH);_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Mika Kahola - Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines · Mika Kahola
Quoted 1 line · Mika Kahola
Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01)
Tested also with APL + MIPI/DSI setup.
Pushed to drm-intel-next-queued, thanks for the patch and testing.
BR,
Jani.
Quoted 67 lines
Quoted 67 lines
Tested-by Mika Kahola <[email protected]>Quoted 54 lines · Andy Shevchenko
The commit
213e08ad60ba
("drm/i915/bxt: add bxt dsi gpio element support")
enables GPIO support for Broxton based platforms.While using that API we might get into troubles in the future, because
we can't rely on label name in the driver since vendor firmware might
provide any GPIO pin there, e.g. "reset", and even mark it in_DSD(in
which case the request will fail).To avoid inconsistency and potential issues we have two options:
a) generate GPIO ACPI mapping table and supply it viaacpi_dev_add_driver_gpios(), or
b) just pass NULL as connection ID.The b) approach is much simpler and would work since the driver relies
on GPIO indices only. Moreover, the_CRSfallback mechanism, when requesting GPIO, has been made stricter, and supplying non-NULL connection ID when neither_DSD, nor GPIO ACPI mapping is present, is
making request fail.Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101921
Fixes f10e4bf6632b ("gpio: acpi: Even more tighten up ACPI GPIOlookups")
Cc Mika Kahola <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>---
v2:
- adjust commit message for proper time tenses
- add Fixes: and Bugzilla: tags
drivers/gpu/drm/i915/intel_dsi_vbt.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dsi_vbt.c +0
-0@@ -306,7 +306,7 @@ static void bxt_exec_gpio(struct
drm_i915_private*dev_priv,
if (!gpio_desc) {
gpio_desc= devm_gpiod_get_index(dev_priv-Quoted 1 line
drm.dev,
drivers/gpu/drm/i915/intel_dsi_vbt.c +0
-1- "panel",
gpio_index,drivers/gpu/drm/i915/intel_dsi_vbt.c +1
-0+ NULL, gpio_index,Quoted 4 lines
value ?
GPIOD_OUT_LOW:
GPIOD_OUT_HIGH);_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/bxt: use NULL for GPIO connection ID (rev2)
In reply to Andy Shevchenko== Series Details ==
== Series Details ==
Series: drm/i915/bxt: use NULL for GPIO connection ID (rev2)
URL : https://patchwork.freedesktop.org/series/20011/
State : success
== Summary ==
Series 20011v2 drm/i915/bxt: use NULL for GPIO connection ID
https://patchwork.freedesktop.org/api/1.0/series/20011/revisions/2/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:454s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:452s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:364s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:552s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:524s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:531s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:518s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:617s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:447s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:426s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:425s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:511s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:476s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:479s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:596s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:595s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:524s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:478s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:482s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:493s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:437s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:489s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:548s fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:409s
ada53b43f81fe618f3f0f1dfbd3dd776bb277323 drm-tip: 2017y-08m-16d-15h-18m-56s UTC integration manifest 9920a7e829ce drm/i915/bxt: use NULL for GPIO connection ID
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5425/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx