dib0090: fix duplicated code for different branches

PATCH New Gustavo A. R. Silva 1 participant 1 message Aug 18, 2017 Media (V4L/DVB)

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-08-18 01:23 UTC #0 lore raw

PATCH 1/1 dib0090: fix duplicated code for different branches

Refactor code in order to avoid identical code for different branches.

This issue was detected with the help of Coccinelle.

Addresses-Coverity-ID: 1226795

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
This code was tested by compilation only.

 drivers/media/dvb-frontends/dib0090.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

drivers/media/dvb-frontends/dib0090.c +1 -8

index ae53a19..d9d730d 100644
@@ -2435,14 +2435,7 @@ static int dib0090_tune(struct dvb_frontend *fe)
 			Den = 1;
 
 			if (Rest > 0) {
-				if (state->config->analog_output)
-					lo6 |= (1 << 2) | 2;
-				else {
-					if (state->identity.in_soc)
-						lo6 |= (1 << 2) | 2;
-					else
-						lo6 |= (1 << 2) | 2;
-				}
+				lo6 |= (1 << 2) | 2;
 				Den = 255;
 			}
 			dib0090_write_reg(state, 0x15, (u16) FBDiv);

Signature · 1 line

2.5.0