Skip to contentSkip to conversation

genirq: fixup checks against nr_cpu_ids

PATCH New Alexey Dobriyan 2 participants 2 messages Aug 19, 2017 – Aug 20, 2017 IRQ

lore
Share & tools
lore

Alexey Dobriyan

author
#0 lore raw

PATCH 1/1 genirq: fixup checks against nr_cpu_ids

Valid CPU ids are [0, nr_cpu_ids-1] inclusive.

Signed-off-by Alexey Dobriyan <[email protected]>

---

 kernel/irq/ipi.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/irq/ipi.c +2 -2
@@ -165,7 +165,7 @@ irq_hw_number_t ipi_get_hwirq(unsigned int irq, unsigned int cpu)
 	struct irq_data *data = irq_get_irq_data(irq);
 	struct cpumask *ipimask = data ? irq_data_get_affinity_mask(data) : NULL;
 
-	if (!data || !ipimask || cpu > nr_cpu_ids)
+	if (!data || !ipimask || cpu >= nr_cpu_ids)
 		return INVALID_HWIRQ;
 
 	if (!cpumask_test_cpu(cpu, ipimask))

@@ -195,7 +195,7 @@ static int ipi_send_verify(struct irq_chip *chip, struct irq_data *data,
 	if (!chip->ipi_send_single && !chip->ipi_send_mask)
 		return -EINVAL;
 
-	if (cpu > nr_cpu_ids)
+	if (cpu >= nr_cpu_ids)
 		return -EINVAL;
 
 	if (dest) {
merge bot
#1 lore raw

[tip:irq/urgent] genirq/ipi: Fixup checks against nr_cpu_ids

genirq/ipi: Fixup checks against nr_cpu_ids
Commit-ID:  8fbbe2d7cc478d1544f41f2271787c993c23a4f6
Gitweb:     http://git.kernel.org/tip/8fbbe2d7cc478d1544f41f2271787c993c23a4f6
Author:     Alexey Dobriyan <[email protected]>
AuthorDate: Sat, 19 Aug 2017 12:57:51 +0300
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Sun, 20 Aug 2017 10:49:05 +0200

genirq/ipi: Fixup checks against nr_cpu_ids

Valid CPU ids are [0, nr_cpu_ids-1] inclusive.

Fixes 3b8e29a82dd1 ("genirq: Implement ipi_send_mask/single()")
Fixes f9bce791ae2a ("genirq: Add a new function to get IPI reverse mapping")
Signed-off-by Alexey Dobriyan <[email protected]>
Signed-off-by Thomas Gleixner <[email protected]>
Cc [email protected]
Link http://lkml.kernel.org/r/20170819095751.GB27864@avx2 open here
---
 kernel/irq/ipi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/irq/ipi.c +2 -2
index 1a9abc1..259a22a 100644
@@ -165,7 +165,7 @@ irq_hw_number_t ipi_get_hwirq(unsigned int irq, unsigned int cpu)
 	struct irq_data *data = irq_get_irq_data(irq);
 	struct cpumask *ipimask = data ? irq_data_get_affinity_mask(data) : NULL;
 
-	if (!data || !ipimask || cpu > nr_cpu_ids)
+	if (!data || !ipimask || cpu >= nr_cpu_ids)
 		return INVALID_HWIRQ;
 
 	if (!cpumask_test_cpu(cpu, ipimask))

@@ -195,7 +195,7 @@ static int ipi_send_verify(struct irq_chip *chip, struct irq_data *data,
 	if (!chip->ipi_send_single && !chip->ipi_send_mask)
 		return -EINVAL;
 
-	if (cpu > nr_cpu_ids)
+	if (cpu >= nr_cpu_ids)
 		return -EINVAL;
 
 	if (dest) {