qtwebengine: disable SECURITY_STRINGFORMAT to fix the build
PATCH 1/1 qtwebengine: disable SECURITY_STRINGFORMAT to fix the build
* meta/conf/distro/include/security_flags.inc adds -Wformat and -Wformat-security, but openh264 adds -Wno-format after that causing build to fail
--- recipes-qt/qt5/qtwebengine_git.bb | 8 ++++++++ 1 file changed, 8 insertions(+)
recipes-qt/qt5/qtwebengine_git.bb +8 -0
@@ -34,6 +34,14 @@ EXTRA_QMAKEVARS_PRE += "GYP_CONFIG+=use_system_yasm \ " EXTRA_QMAKEVARS_CONFIGURE += "-feature-system-ninja -no-feature-system-gn" +# chromium/third_party/openh264/openh264.gyp adds +# -Wno-format to openh264_cflags_add +# similarly chromium/third_party/openh264/BUILD.gn for newer qtwebengine +# causing following error, because -Wformat-security cannot be used together with -Wno-format +# cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security] +# http://errors.yoctoproject.org/Errors/Details/150333/ +SECURITY_STRINGFORMAT = "" + # To use system ffmpeg you need to enable also libwebp, opus, vpx # Only depenedencies available in oe-core are enabled by default PACKAGECONFIG ??= "libwebp flac libevent libxslt speex nss"
Signature · 1 line
2.14.0
Quoted 15 lines · Martin Jansa
* meta/conf/distro/include/security_flags.inc adds -Wformat and -Wformat-security, but openh264 adds -Wno-format after that causing build to fail
Signed-off-by Martin Jansa <[email protected]>--- recipes-qt/qt5/qtwebengine_git.bb | 8 ++++++++ 1 file changed, 8 insertions(+)recipes-qt/qt5/qtwebengine_git.bb +0
-0@@ -34,6 +34,14 @@ EXTRA_QMAKEVARS_PRE += "GYP_CONFIG+=use_system_yasm \ "
recipes-qt/qt5/qtwebengine_git.bb EXTRA_QMAKEVARS_PRE += "GYP_CONFIG+=use_system_yasm \ · line 44
Quoted 10 lines
recipes-qt/qt5/qtwebengine_git.bb +8
-0EXTRA_QMAKEVARS_CONFIGURE += "-feature-system-ninja -no-feature-system-gn" +# chromium/third_party/openh264/openh264.gyp adds +# -Wno-format to openh264_cflags_add +# similarly chromium/third_party/openh264/BUILD.gn for newer qtwebengine +# causing following error, because -Wformat-security cannot be used together with -Wno-format +# cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security] +# http://errors.yoctoproject.org/Errors/Details/150333/ +SECURITY_STRINGFORMAT = "" +
If its not happening in lot of files may be doing something like
QT_WARNING_PUSH
QT_WARNING_DISABLE_GCC("-Wformat-security")
#ifdef __clang__QT_WARNING_DISABLE_CLANG("-Wformat-security")
#endif
....
QT_WARNING_POP
is more targeted as it can be done per file.
Quoted 11 lines
recipes-qt/qt5/qtwebengine_git.bb +0
-1# To use system ffmpeg you need to enable also libwebp, opus, vpx # Only depenedencies available in oe-core are enabled by default PACKAGECONFIG ??= "libwebp flac libevent libxslt speex nss" --2.14.0
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
The -Wno-format is added for whole openh264 directory (I haven't checked why), so at least this whole directory shouldn't use -Wformat-security or -Wno-format should be removed/restricted to some files from gyp files for 5.8 and from gn files for 5.9.
Quoted 58 lines · Khem Raj
recipes-qt/qt5/
Quoted 10 lines · Martin Jansa
* meta/conf/distro/include/security_flags.inc adds -Wformat and -Wformat-security, but openh264 adds -Wno-format after that causing build to fail
Signed-off-by Martin Jansa <[email protected]>--- recipes-qt/qt5/qtwebengine_git.bb | 8 ++++++++ 1 file changed, 8 insertions(+)recipes-qt/qt5/ renamed from recipes-qt/qt5/qtwebengine_git.bb +0
-0qtwebengine_git.bb
recipes-qt/qt5/qtwebengine_git.bb EXTRA_QMAKEVARS_PRE += "GYP_CONFIG+=use_system_yasm \ · line 35
Quoted 6 lines
index 45b885c..830e640 100644
recipes-qt/qt5/qtwebengine_git.bb +0
-0@@ -34,6 +34,14 @@ EXTRA_QMAKEVARS_PRE += "GYP_CONFIG+=use_system_yasm \ " EXTRA_QMAKEVARS_CONFIGURE += "-feature-system-ninja-no-feature-system-gn"
recipes-qt/qt5/qtwebengine_git.bb EXTRA_QMAKEVARS_PRE += "GYP_CONFIG+=use_system_yasm \
Quoted 4 lines
recipes-qt/qt5/qtwebengine_git.bb +3
-0+# chromium/third_party/openh264/openh264.gyp adds +# -Wno-format to openh264_cflags_add +# similarly chromium/third_party/openh264/BUILD.gn for newerqtwebengine
recipes-qt/qt5/qtwebengine_git.bb EXTRA_QMAKEVARS_PRE += "GYP_CONFIG+=use_system_yasm \ · line 39
Quoted 1 line
recipes-qt/qt5/qtwebengine_git.bb +1
-0+# causing following error, because -Wformat-security cannot be usedtogether with -Wno-format
recipes-qt/qt5/qtwebengine_git.bb EXTRA_QMAKEVARS_PRE += "GYP_CONFIG+=use_system_yasm \ · line 40
Quoted 1 line
recipes-qt/qt5/qtwebengine_git.bb +1
-0+# cc1plus: error: -Wformat-security ignored without -Wformat[-Werror=format-security]
recipes-qt/qt5/qtwebengine_git.bb EXTRA_QMAKEVARS_PRE += "GYP_CONFIG+=use_system_yasm \ · line 44
Quoted 3 lines
recipes-qt/qt5/qtwebengine_git.bb +3
-0+# http://errors.yoctoproject.org/Errors/Details/150333/ +SECURITY_STRINGFORMAT = "" +If its not happening in lot of files may be doing something like
QT_WARNING_PUSH
QT_WARNING_DISABLE_GCC("-Wformat-security")
#ifdef__clang__QT_WARNING_DISABLE_CLANG("-Wformat-security")
#endif
....
QT_WARNING_POPis more targeted as it can be done per file.
Quoted 11 lines
recipes-qt/qt5/qtwebengine_git.bb +0
-1# To use system ffmpeg you need to enable also libwebp, opus, vpx # Only depenedencies available in oe-core are enabled by default PACKAGECONFIG ??= "libwebp flac libevent libxslt speex nss" --2.14.0
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 4 lines · Martin Jansa
The -Wno-format is added for whole openh264 directory (I haven't checked why), so at least this whole directory shouldn't use -Wformat-security or -Wno-format should be removed/restricted to some files from gyp files for 5.8 and from gn files for 5.9.
OK. I guess in this case if you added to gyp files along with -Wno-format would be nicer but then order of SECURITY_FLAGS might be problematic you might have to check they come before the gyp files specified flags
Quoted 62 lines · Khem Raj
Quoted 58 lines
Quoted 27 lines · Martin Jansa
* meta/conf/distro/include/security_flags.inc adds -Wformat and -Wformat-security, but openh264 adds -Wno-format after that causing build to fail
Signed-off-by Martin Jansa <[email protected]>--- recipes-qt/qt5/qtwebengine_git.bb | 8 ++++++++ 1 file changed, 8 insertions(+)recipes-qt/qt5/qtwebengine_git.bb +3
-1@@ -34,6 +34,14 @@ EXTRA_QMAKEVARS_PRE += "GYP_CONFIG+=use_system_yasm \ " EXTRA_QMAKEVARS_CONFIGURE += "-feature-system-ninja -no-feature-system-gn" +# chromium/third_party/openh264/openh264.gyp adds +# -Wno-format to openh264_cflags_add +# similarly chromium/third_party/openh264/BUILD.gn for newerqtwebengine
+# causing following error, because -Wformat-security cannot be used together with -Wno-format
+# cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security]recipes-qt/qt5/qtwebengine_git.bb EXTRA_QMAKEVARS_PRE += "GYP_CONFIG+=use_system_yasm \ · line 44
Quoted 3 lines
recipes-qt/qt5/qtwebengine_git.bb +3
-0+# http://errors.yoctoproject.org/Errors/Details/150333/ +SECURITY_STRINGFORMAT = "" +If its not happening in lot of files may be doing something like
QT_WARNING_PUSH
QT_WARNING_DISABLE_GCC("-Wformat-security")
#ifdef__clang__QT_WARNING_DISABLE_CLANG("-Wformat-security")
#endif
....
QT_WARNING_POPis more targeted as it can be done per file.
Quoted 11 lines
# To use system ffmpeg you need to enable also libwebp, opus, vpx # Only depenedencies available in oe-core are enabled by default PACKAGECONFIG ??= "libwebp flac libevent libxslt speex nss"
--
2.14.0--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel