Skip to contentSkip to conversation

blkcg: add a cleanup when active policy fail

PATCH New weiping zhang 1 participant 1 message Aug 21, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 blkcg: add a cleanup when active policy fail

if alloc memory fail, all cpds which were allocated before should be cleaned up.

---
 block/blk-cgroup.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
block/blk-cgroup.c +11 -0
index 0480892..7e21c4b 100644
@@ -1336,6 +1336,17 @@ int blkcg_activate_policy(struct request_queue *q,
 
 	spin_unlock_irq(q->queue_lock);
 out_bypass_end:
+	if (ret) {
+		spin_lock_irq(q->queue_lock);
+		list_for_each_entry(blkg, &q->blkg_list, q_node) {
+			if (blkg->pd[pol->plid]) {
+				if (pol->pd_free_fn)
+					pol->pd_free_fn(blkg->pd[pol->plid]);
+				blkg->pd[pol->plid] = NULL;
+			}
+		}
+		spin_unlock_irq(q->queue_lock);
+	}
 	if (q->mq_ops)
 		blk_mq_unfreeze_queue(q);
 	else
Signature · 1 line
2.9.4