tests/chamelium: Introduce fast basic hpd tests, with limited toggles
PATCH 1/3 tests/chamelium: Introduce fast basic hpd tests, with limited toggles
This introduces a fast fashion of testing basic hotplug detect, with only 3 toggles. It drastically reduces the run time of the test, which is necessary for the fast-feedback test list.
--- tests/chamelium.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
tests/chamelium.c +12 -0
@@ -48,6 +48,7 @@ typedef struct {#define HPD_TOGGLE_COUNT_VGA 5#define HPD_TOGGLE_COUNT_DP_HDMI 15 +#define HPD_TOGGLE_COUNT_FAST 3static void get_connectors_link_status_failed (data_t *data,bool *link_status_failed)
@@ -775,6 +776,10 @@ igt_maintest_basic_hotplug (&data, port,HPD_TOGGLE_COUNT_DP_HDMI ); + connector_subtest("dp-hpd-fast", DisplayPort) +test_basic_hotplug (&data, port, +HPD_TOGGLE_COUNT_FAST ); + connector_subtest("dp-edid-read", DisplayPort) {test_edid_read (&data, port, edid_id,igt_kms_get_base_edid ());
@@ -832,6 +837,10 @@ igt_maintest_basic_hotplug (&data, port,HPD_TOGGLE_COUNT_DP_HDMI ); + connector_subtest("hdmi-hpd-fast", HDMIA) +test_basic_hotplug (&data, port, +HPD_TOGGLE_COUNT_FAST ); + connector_subtest("hdmi-edid-read", HDMIA) {test_edid_read (&data, port, edid_id,igt_kms_get_base_edid ());
@@ -888,6 +897,9 @@ igt_main connector_subtest("vga-hpd", VGA)test_basic_hotplug (&data, port,HPD_TOGGLE_COUNT_VGA ); + connector_subtest("vga-hpd-fast", VGA) +test_basic_hotplug (&data, port,HPD_TOGGLE_COUNT_FAST ); + connector_subtest("vga-edid-read", VGA) {test_edid_read (&data, port, edid_id,igt_kms_get_base_edid ());
Signature · 6 lines
2.14.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/3 tests/chamelium: Introduce fast CRC tests, with a single mode
This introduces a fast fashion of testing display CRC, that only tests a single mode (the highest resolution). It drastically reduces the run time of the test, which is necessary for the fast-feedback test list.
--- tests/chamelium.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-)
tests/chamelium.c +16 -6
@@ -497,7 +497,8 @@ disable_output(data_t *data, }static void -test_display_crc (data_t *data,struct chamelium_port *port,int count) +test_display_crc (data_t *data,struct chamelium_port *port,int count, +bool fast) {igt_display_t display;igt_output_t *output;
@@ -509,6 +510,7 @@ test_display_crc(data_t *data, struct chamelium_port *port, int count)drmModeModeInfo *mode;drmModeConnector *connector;int fb_id, i, j, captured_frame_count; +int count_modes;reset_state (data, port);
@@ -517,7 +519,9 @@ test_display_crc(data_t *data, struct chamelium_port *port, int count) primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY );igt_assert (primary); -for (i =0 ; i < connector->count_modes; i++) { + count_modes = fast ?1 : connector->count_modes; + +for (i =0 ; i < count_modes; i++) { mode = &connector->modes[i]; fb_id = igt_create_color_pattern_fb(data->drm_fd, mode->hdisplay,
@@ -818,10 +822,13 @@ igt_main edid_id, alt_edid_id); connector_subtest("dp-crc-single", DisplayPort) -test_display_crc (&data, port,1 ); +test_display_crc (&data, port,1 , false); + + connector_subtest("dp-crc-fast", DisplayPort) +test_display_crc (&data, port,1 , true); connector_subtest("dp-crc-multiple", DisplayPort) -test_display_crc (&data, port,3 ); +test_display_crc (&data, port,3 , false); connector_subtest("dp-frame-dump", DisplayPort)test_display_frame_dump (&data, port);
@@ -879,10 +886,13 @@ igt_main edid_id, alt_edid_id); connector_subtest("hdmi-crc-single", HDMIA) -test_display_crc (&data, port,1 ); +test_display_crc (&data, port,1 , false); + + connector_subtest("hdmi-crc-fast", HDMIA) +test_display_crc (&data, port,1 , true); connector_subtest("hdmi-crc-multiple", HDMIA) -test_display_crc (&data, port,3 ); +test_display_crc (&data, port,3 , false); connector_subtest("hdmi-frame-dump", HDMIA)test_display_frame_dump (&data, port);
Signature · 6 lines
2.14.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/3 intel-ci: Add fast chamelium tests to the fast-feedback list
In reply to Paul KocialkowskiThis adds the fastest chamelium tests to the Intel CI fast-feedback list, with the objective of running in under a minute.
--- tests/intel-ci/fast-feedback.testlist | 9 +++++++++ 1 file changed, 9 insertions(+)
tests/intel-ci/fast-feedback.testlist +9 -0
@@ -1,5 +1,14 @@ # Keep alphabetically sorted by default +igt@chamelium@dp-hpd-fast +igt@chamelium@dp-edid-read +igt@chamelium@dp-crc-fast +igt@chamelium@hdmi-hpd-fast +igt@chamelium@hdmi-edid-read +igt@chamelium@hdmi-crc-fast +igt@chamelium@vga-hpd-fast +igt@chamelium@vga-edid-read +igt@chamelium@common-hpd-after-suspend igt@core_auth@basic-auth igt@core_prop_blob@basic igt@debugfs_test@read_all_entries
Signature · 6 lines
2.14.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/3] tests/chamelium: Introduce fast basic hpd tests, with limited toggles
In reply to Paul Kocialkowski== Series Details ==
== Series Details ==
Series: series starting with [1/3] tests/chamelium: Introduce fast basic hpd tests, with limited toggles
URL : https://patchwork.freedesktop.org/series/29218/
State : success
== Summary ==
IGT patchset tested on top of latest successful build 42b42c99cd9d1b890807ae97cbd1c593396ae051 tests/Makefile.am: Wrap audio test with dedicated conditional
with latest DRM-Tip kernel build CI_DRM_29952964b2f40295 drm-tip: 2017y-08m-23d-13h-11m-32s UTC integration manifest
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
pass -> FAIL (fi-snb-2600) fdo#100215 +1
Test kms_flip:
Subgroup basic-flip-vs-modeset:
pass -> SKIP (fi-skl-x1585l) fdo#101781fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:461s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:436s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:365s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:559s fi-bwr-2160 total:279 pass:184 dwarn:0 dfail:0 fail:0 skip:95 time:254s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:524s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:530s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:527s fi-elk-e7500 total:279 pass:230 dwarn:0 dfail:0 fail:0 skip:49 time:437s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:607s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:444s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:425s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:421s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:505s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:480s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:474s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:596s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:602s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:531s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:476s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:481s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:487s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:446s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:488s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:553s fi-snb-2600 total:279 pass:248 dwarn:0 dfail:0 fail:2 skip:29 time:411s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_89/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
R-B'd and pushed, thanks!
Quoted 57 lines · Paul Kocialkowski
This introduces a fast fashion of testing basic hotplug detect, with only 3 toggles. It drastically reduces the run time of the test, which
is necessary for the fast-feedback test list.Signed-off-by Paul Kocialkowski <[email protected]>--- tests/chamelium.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)tests/chamelium.c +1
-0@@ -48,6 +48,7 @@ typedef struct {#define HPD_TOGGLE_COUNT_VGA 5#define HPD_TOGGLE_COUNT_DP_HDMI 15 +#define HPD_TOGGLE_COUNT_FAST 3static void get_connectors_link_status_failed(data_t *data, bool
*link_status_failed)tests/chamelium.c +4
-0@@ -775,6 +776,10 @@ igt_maintest_basic_hotplug (&data, port,HPD_TOGGLE_COUNT_DP_HDMI ) ; + connector_subtest("dp-hpd-fast", DisplayPort) +test_basic_hotplug (&data, port, +HPD_TOGGLE_COUNT_FAST ); + connector_subtest("dp-edid-read", DisplayPort) { test_edid_read(&data, port, edid_id,tests/chamelium.c +4
-0igt_kms_get_base_edid());@@ -832,6 +837,10 @@ igt_maintest_basic_hotplug (&data, port,HPD_TOGGLE_COUNT_DP_HDMI ) ; + connector_subtest("hdmi-hpd-fast", HDMIA) +test_basic_hotplug (&data, port, +HPD_TOGGLE_COUNT_FAST ); + connector_subtest("hdmi-edid-read", HDMIA) { test_edid_read(&data, port, edid_id,tests/chamelium.c +3
-0igt_kms_get_base_edid());@@ -888,6 +897,9 @@ igt_main connector_subtest("vga-hpd", VGA)test_basic_hotplug (&data, port,HPD_TOGGLE_COUNT_VGA ); + connector_subtest("vga-hpd-fast", VGA) +test_basic_hotplug (&data, port,HPD_TOGGLE_COUNT_FAST ); + connector_subtest("vga-edid-read", VGA) {
tests/chamelium.c
Quoted 2 lines
tests/chamelium.c +0
-0test_edid_read (&data, port, edid_id,igt_kms_get_base_edid ());
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH i-g-t 3/3] intel-ci: Add fast chamelium tests to the fast-feedback list
In reply to Paul KocialkowskiQuoted 2 lines · Paul Kocialkowski
This adds the fastest chamelium tests to the Intel CI fast-feedback list, with the objective of running in under a minute.
For the record, here are average run times for the added tests:
dp-hpd-fast: 2.397s
dp-edid-read: 1.776s
dp-crc-fast: 6.458s
hdmi-hpd-fast: 2.732s
hdmi-edid-read: 2.165s
hdmi-crc-fast: 8.612s
vga-hpd-fast: 7.384s
vga-edid-read: 3.805s
common-hpd-after-suspend: 22.496s
total: 57.825s
Note that the CRC tests are especially slow because of the interface decoders on the Chamelium board. They take seconds to detect the video input as stable and there isn't much we can do about that.
Quoted 25 lines
Signed-off-by Paul Kocialkowski <[email protected]>--- tests/intel-ci/fast-feedback.testlist | 9 +++++++++ 1 file changed, 9 insertions(+)tests/intel- renamed from tests/intel-ci/fast-feedback.testlist +0
-0ci/fast-feedback.testlist
index 79160624..a8e9c5be 100644tests/intel-ci/fast-feedback.testlist +9
-0@@ -1,5 +1,14 @@ # Keep alphabetically sorted by default +igt@chamelium@dp-hpd-fast +igt@chamelium@dp-edid-read +igt@chamelium@dp-crc-fast +igt@chamelium@hdmi-hpd-fast +igt@chamelium@hdmi-edid-read +igt@chamelium@hdmi-crc-fast +igt@chamelium@vga-hpd-fast +igt@chamelium@vga-edid-read +igt@chamelium@common-hpd-after-suspend igt@core_auth@basic-auth igt@core_prop_blob@basic igt@debugfs_test@read_all_entries
Signature · 6 lines
Paul Kocialkowski <[email protected]> Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH i-g-t 3/3] intel-ci: Add fast chamelium tests to the fast-feedback list
In reply to Paul KocialkowskiI have to revert locally to use fast-feedback.testlist here today... it seems chamelium is not compiling by default...
first I thought it was a dirty build so I
make distclean && autogen && make
and chamelium wasn't still compiled...
I end up not investigating this here, but I can do this next week... just dropping the message here in case someone has a quick insight...
Quoted 34 lines · Paul Kocialkowski
This adds the fastest chamelium tests to the Intel CI fast-feedback list, with the objective of running in under a minute.
Signed-off-by Paul Kocialkowski <[email protected]>--- tests/intel-ci/fast-feedback.testlist | 9 +++++++++ 1 file changed, 9 insertions(+)tests/intel-ci/fast-feedback.testlist +9
-1@@ -1,5 +1,14 @@ # Keep alphabetically sorted by default +igt@chamelium@dp-hpd-fast +igt@chamelium@dp-edid-read +igt@chamelium@dp-crc-fast +igt@chamelium@hdmi-hpd-fast +igt@chamelium@hdmi-edid-read +igt@chamelium@hdmi-crc-fast +igt@chamelium@vga-hpd-fast +igt@chamelium@vga-edid-read +igt@chamelium@common-hpd-after-suspend igt@core_auth@basic-auth igt@core_prop_blob@basic igt@debugfs_test@read_all_entries --2.14.0
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH i-g-t 3/3] intel-ci: Add fast chamelium tests to the fast-feedback list
Hi,
Quoted 7 lines · Rodrigo Vivi
I have to revert locally to use fast-feedback.testlist here today... it seems chamelium is not compiling by default...
first I thought it was a dirty build so I
make distclean && autogen && make
and chamelium wasn't still compiled...
I end up not investigating this here, but I can do this next week... just dropping the message here in case someone has a quick insight...
Chamelium support needs to be explicitely enabled with --enable-chamelium
The configure script should print whether support for it is enabled or not in the summary, by the way.
Cheers,
Paul
Quoted 40 lines
Quoted 35 lines · Paul Kocialkowski
This adds the fastest chamelium tests to the Intel CI fast-feedback list, with the objective of running in under a minute.
Signed-off-by Paul Kocialkowski <[email protected]>--- tests/intel-ci/fast-feedback.testlist | 9 +++++++++ 1 file changed, 9 insertions(+)tests/intel- renamed from tests/intel-ci/fast-feedback.testlist +0
-0ci/fast-feedback.testlist
index 79160624..a8e9c5be 100644tests/intel-ci/fast-feedback.testlist +9
-1@@ -1,5 +1,14 @@ # Keep alphabetically sorted by default +igt@chamelium@dp-hpd-fast +igt@chamelium@dp-edid-read +igt@chamelium@dp-crc-fast +igt@chamelium@hdmi-hpd-fast +igt@chamelium@hdmi-edid-read +igt@chamelium@hdmi-crc-fast +igt@chamelium@vga-hpd-fast +igt@chamelium@vga-edid-read +igt@chamelium@common-hpd-after-suspend igt@core_auth@basic-auth igt@core_prop_blob@basic igt@debugfs_test@read_all_entries --2.14.0
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Paul Kocialkowski <[email protected]> Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH i-g-t 3/3] intel-ci: Add fast chamelium tests to the fast-feedback list
Quoted 11 lines · Paul Kocialkowski
Hi,
Quoted 7 lines · Rodrigo Vivi
I have to revert locally to use fast-feedback.testlist here today... it seems chamelium is not compiling by default...
first I thought it was a dirty build so I
make distclean && autogen && make
and chamelium wasn't still compiled...
I end up not investigating this here, but I can do this next week... just dropping the message here in case someone has a quick insight...
Quoted 5 lines
Chamelium support needs to be explicitely enabled with --enable-chamelium
The configure script should print whether support for it is enabled or not in the summary, by the way.
Hey,
A sidenote:
If you have a recent piglit you can continue using it with the testlit using the --ignore-missing switch - the missing tests from the list will be reported as "notrun" instead of blowing up the runner with random-looking python exception.
@Petri:
I think we should introduce a switch to './run-tests.sh' to make this usable through our wrapper. Any thoughts on making this the default behavior?
Signature · 6 lines
Cheers, Arek _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx