Skip to contentSkip to conversation

qf: Fix qf_help: Remove attempt to grab DIM_PREFIX.

PATCH In review Rodrigo Vivi 2 participants 2 messages Aug 23, 2017 – Aug 24, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qf: Fix qf_help: Remove attempt to grab DIM_PREFIX.

This is not available here nor will be available on qfrc. So let's avoid duplication and just grab the qf.rst file from whatever repository this command is called from.

Cc Jani Nikula <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Joonas Lahtinen <[email protected]>
---
 qf | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
qf +3 -6
index 1f056f90ef70..0373a089ff67 100755
@@ -171,13 +171,10 @@ function quilt_clean_check
 
 function qf_help
 {
-	manpage=$DIM_PREFIX/maintainer-tools/qf.rst
+	manpage=$(dirname $(readlink -f $0))/qf.rst
 	if [ ! -e "$manpage" ]; then
-		manpage=$(dirname $(readlink -f $0))/qf.rst
-		if [ ! -e "$manpage" ]; then
-			echo "Can't find the man page."
-			exit 1
-		fi
+		echo "Can't find the man page."
+		exit 1
 	fi
 
 	if hash rst2man 2>/dev/null; then
Signature · 6 lines
2.13.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 8 lines · Rodrigo Vivi

This is not available here nor will be available on qfrc. So let's avoid duplication and just grab the qf.rst file from whatever repository this command is called from.

Cc Jani Nikula <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Joonas Lahtinen <[email protected]>

Ack.
-Daniel

Quoted 28 lines
---
 qf | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
qf +3 -6
index 1f056f90ef70..0373a089ff67 100755
@@ -171,13 +171,10 @@ function quilt_clean_check
 
 function qf_help
 {
-	manpage=$DIM_PREFIX/maintainer-tools/qf.rst
+	manpage=$(dirname $(readlink -f $0))/qf.rst
 	if [ ! -e "$manpage" ]; then
-		manpage=$(dirname $(readlink -f $0))/qf.rst
-		if [ ! -e "$manpage" ]; then
-			echo "Can't find the man page."
-			exit 1
-		fi
+		echo "Can't find the man page."
+		exit 1
 	fi
 
 	if hash rst2man 2>/dev/null; then
Signature · 1 line
2.13.2
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx