Skip to contentSkip to conversation

staging: gdm724x: Rename variable for consistency

PATCH Superseded Nick Fox 2 participants 4 messages Aug 24, 2017 – Aug 31, 2017 Staging

lore
Share & tools
lore

Nick Fox

author
#0 lore raw

PATCH 1/1 staging: gdm724x: Rename variable for consistency

Rename dftEpsId variable to dft_eps_ID to be consistent with other variables in the source file.

Signed-off-by Nick Fox <[email protected]>
---
 drivers/staging/gdm724x/hci_packet.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/gdm724x/hci_packet.h +2 -2
index 22ce8b9477b6..d9e41e457f83 100644
@@ -50,7 +50,7 @@ struct tlv {
 struct sdu_header {
 	__dev16 cmd_evt;
 	__dev16 len;
-	__dev32 dftEpsId;
+	__dev32 dft_eps_ID;
 	__dev32 bearer_ID;
 	__dev32 nic_type;
 } __packed;

@@ -76,7 +76,7 @@ struct hci_pdn_table_ind {
 	__dev16 cmd_evt;
 	__dev16 len;
 	u8 activate;
-	__dev32 dft_eps_id;
+	__dev32 dft_eps_ID;
 	__dev32 nic_type;
 	u8 pdn_type;
 	u8 ipv4_addr[4];
Signature · 1 line
2.13.5
maintainer
#1 lore raw
Quoted 7 lines · Nick Fox

Rename dftEpsId variable to dft_eps_ID to be consistent with other variables in the source file.

Signed-off-by Nick Fox <[email protected]>
---
 drivers/staging/gdm724x/hci_packet.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Always test-build your patches, to not do so is rude to those of us you expect to apply your patch :(

greg k-h

author
#2 lore raw

PATCH v2 1/1 staging : gdm724x: Rename variable for consistency

v2: Undo the renaming of the dft_eps_id variable in hci_pdn_table_ind to resolve a compiler error.

Signed-off-by Nick Fox <[email protected]>
---
 drivers/staging/gdm724x/hci_packet.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gdm724x/hci_packet.h +1 -1
index 22ce8b9477b6..f8837c7103ac 100644
@@ -50,7 +50,7 @@ struct tlv {
 struct sdu_header {
 	__dev16 cmd_evt;
 	__dev16 len;
-	__dev32 dftEpsId;
+	__dev32 dft_eps_ID;
 	__dev32 bearer_ID;
 	__dev32 nic_type;
 } __packed;
Signature · 1 line
2.13.5
maintainer
#3 lore raw

Re: [PATCH v2] staging : gdm724x: Rename variable for consistency

Quoted 2 lines · Nick Fox

v2: Undo the renaming of the dft_eps_id variable in hci_pdn_table_ind to resolve a compiler error.

What compiler error? Who reported it?

And why put v2 here in the changelog area?

totally confused,

greg k-h